Add sup expression by lovek323 · Pull Request #610 · NixOS/nixpkgs

lovek323 · 2013-06-11T04:04:07Z

This is the first time I've contributed to nixpkgs, so bear with me if I've made some horrible mistakes. :)

jcumming · 2013-06-11T04:07:44Z

pkgs/applications/networking/mailreaders/sup/default.nix

Add yourself to lib/maintainers.nix, and then use maintainers = with stdenv.lib.maintainers; [ jason ] ; Or something.

No worries.

jcumming · 2013-06-11T04:13:44Z

Looks good. If you've tested it on a few platforms, you might consider adding a platforms = stdenv.lib.platforms.unix to the meta attribue, and then (IIRC) hydra will pick it up and test it.

lovek323 · 2013-06-11T06:27:39Z

I realised I needed a newer rake version than is in master, so I've added an expression for this too.

lovek323 · 2013-06-11T08:22:35Z

I made this way more complicated by deciding to add support for gpgme (which relied on a few things not working on darwin). They're fixed now.

peti · 2013-06-11T09:20:06Z

pkgs/top-level/all-packages.nix

Now that there are two different versions of rake, please make sure that it is possible to see the version of the old rake attribute in all-packages.nix, too. The common approach is to have an attribute rakexyz for every version x.y.z, plus an attribute rake that just refers to the version of rake we use by default. Also, the file ./development/ruby-modules/rake/default.nix should probably be renamed so that its filename is consistent with the newly added 10.nix expression.

No problems.

peti · 2013-06-11T09:21:05Z

Is it not possible to update rake globally, for all packages? Why do we need to keep the old version aronud?

lovek323 · 2013-06-11T22:52:27Z

I decided to keep the old version around only so I was affecting as few things as possible.

lovek323 · 2013-06-12T03:22:34Z

I'm just testing this on a CentOS box on EC2 -- I'll comment here when I've got it compiling there as well as on my mac.

peti · 2013-06-12T09:14:29Z

How does your new rake expression relate to the one we have in pkgs/development/interpreters/ruby/generated.nix already?

create separate expressions for gems requiring native extensions to be built: * gpgme * ncursesw_sup * xapian_full_alaveteli

lovek323 · 2013-06-13T00:49:46Z

Good question. I didn't see that there -- I stopped looking after I found the other rake expression. Seems to work fine using rubyLibs.rake_10_0_4.

I have removed the new rake version.

lovek323 · 2013-06-13T00:50:45Z

This is building fine on Darwin & CentOS.

vcunat · 2013-06-13T04:03:42Z

I quite don't see why you (need to) change gnupg?
Please change the name "gpgme-". Now when user does "nix-env -i gpgme", he gets non-deterministic choice between library and binding, AFAIK. Perhaps it should be "gpgme-ruby-", but I'm not sure, maybe there's some other naming custom.

lovek323 · 2013-06-13T04:09:29Z

gnupg wasn't building on Darwin:

it didn't have access to iconv.h, so I added libiconv to the build inputs
a spelling error in the gnupg source wrapped in a preprocessor conditional (only called when built on Darwin)

But gnupg is required to build gpgme (which in turn is required to compile the native extensions for the ruby-gpgme gem).

Changed to "ruby-gpgme-1.0.8".

vcunat · 2013-06-13T04:14:04Z

Ah, I was reading the diff badly. In that case, it's better use "] ++ libiconvOrEmpty" instead of "libiconv ]", because on glibc platforms it's an unnecessary dependency.

…c platforms)

lovek323 · 2013-06-13T04:17:34Z

Cool, thanks. That's fixed now.

vcunat · 2013-06-13T04:28:40Z

I tested builds at the two linux platforms, at least, when I was at it. @peti: any more comments (I know nothing about ruby)?

Add sup expression

vcunat · 2013-06-13T11:20:49Z

Ah, there seem to be some impurities... I see attempts to download during build.

lovek323 · 2013-06-13T12:35:31Z

Is that against the rules?

That will probably be the gem install commands in the installPhase. These could be separated out, I suppose.

lovek323 · 2013-06-13T12:35:44Z

Do you have any information about what's being downloaded?

vcunat · 2013-06-13T18:18:05Z

It's enough to watch Hydra builds http://hydra.nixos.org/build/5294334/nixlog/7/tail-reload

lovek323 · 2013-06-13T23:18:30Z

Thanks, @vcunat. I'll work on separating out those dependencies.

lovek323 · 2013-06-15T00:57:19Z

I've fixed this here: #626

Disables support for Javascript and PHP: - Javascript requires an old version of v8 - PHP requires a larger number of dependencies in addition to php-embed Changelog [1]: New features - core: add option weechat.look.nick_color_hash_salt to shuffle nick colors (issue NixOS#635) - core: add different icons sizes (16x16 to 512x512) (issue NixOS#1347) - core: add file weechat.desktop - core: add reverse of string for screen in evaluation of expressions with "revscr:" - core: add length of string (number of chars and on screen) in evaluation of expressions with "length:xxx" and "lengthscr:xxx" - core: add calculation of expression in evaluation of expressions with "calc:xxx" (issue NixOS#997) - core: add optional default path (evaluated) in completion "filename" - core: add support of modifiers in evaluation of expressions with "modifier:name,data,string" - api: add modifier "color_encode_ansi" (issue NixOS#528) - api: add modifier "eval_path_home" - irc: add filters on raw buffer (issue NixOS#1000) - irc: add option irc.look.display_pv_warning_address to display a warning in private buffer if the remote nick address has changed (issue NixOS#892) - irc: add server option "ssl_password" (issue NixOS#115, issue NixOS#1416) - irc: add "user" in output of irc_message_parse (issue NixOS#136) - irc: add options irc.color.message_kick and irc.color.reason_kick (issue NixOS#683, issue NixOS#684) - logger: add option logger.file.color_lines (issue NixOS#528, issue NixOS#621) - script: add options "-ol" and "-il" in command "/script list" to send translated string with list of scripts loaded, display "No scripts loaded" if no scripts are loaded - xfer: add option xfer.file.download_temporary_suffix with default value ".part" (issue NixOS#1237) Bug fixes - core: set buffer name, short name and title only if the value has changed - core: fix scrolling up in bare mode when switched to bare mode at the top of the buffer (issue NixOS#899, issue NixOS#978) - core: optimize load of configuration files - core: fix window separators not respecting window splits (issue NixOS#630) - core: fix cursor mode info when prefix_align is none and with words split across lines (issue NixOS#610, issue NixOS#617, issue NixOS#619) - core: add support of reverse video in ANSI color codes - core: fixed segfault during excessive evaluation in function string_repeat (issue NixOS#1400) - buflist: fix extra spaces between buffers when conditions are used to hide buffers (regression introduced in version 2.6) (issue NixOS#1403) - irc: do not automatically open a channel with name "0" (issue NixOS#1429) - irc: remove option irc.network.channel_encode, add server option "charset_message" to control which part of the IRC message is decoded/encoded to the target charset (issue NixOS#832) - irc: use path from option xfer.file.upload_path to complete filename in command "/dcc send" (issue NixOS#60) - logger: fix write in log file if it has been deleted or renamed (issue NixOS#123) - python: send "bytes" instead of "str" to callbacks in Python 3 when the string is not UTF-8 valid (issue NixOS#1389) - relay: send message "_buffer_title_changed" to clients only when the title is changed - xfer: fix memory leak when a xfer is freed and when the plugin is unloaded Tests - unit: add tests on GUI color functions Build - core: fix build on Haiku (issue NixOS#1420) - core: fix build on Alpine - core: remove file FindTCL.cmake - core: display an error on missing dependency in CMake (issue NixOS#916, issue NixOS#956) - debian: disable Javascript plugin on Debian Sid and Ubuntu Eoan - debian: build with Guile 2.2 - guile: add support of Guile 2.2, disable /guile eval (issue NixOS#1098) - python: add detection of Python 3.8 [1] https://weechat.org/files/changelog/ChangeLog-2.7.html

Disables support for Javascript and PHP: - Javascript requires an old version of v8 - PHP requires a larger number of dependencies in addition to php-embed Changelog [1]: New features - core: add option weechat.look.nick_color_hash_salt to shuffle nick colors (issue NixOS#635) - core: add different icons sizes (16x16 to 512x512) (issue NixOS#1347) - core: add file weechat.desktop - core: add reverse of string for screen in evaluation of expressions with "revscr:" - core: add length of string (number of chars and on screen) in evaluation of expressions with "length:xxx" and "lengthscr:xxx" - core: add calculation of expression in evaluation of expressions with "calc:xxx" (issue NixOS#997) - core: add optional default path (evaluated) in completion "filename" - core: add support of modifiers in evaluation of expressions with "modifier:name,data,string" - api: add modifier "color_encode_ansi" (issue NixOS#528) - api: add modifier "eval_path_home" - irc: add filters on raw buffer (issue NixOS#1000) - irc: add option irc.look.display_pv_warning_address to display a warning in private buffer if the remote nick address has changed (issue NixOS#892) - irc: add server option "ssl_password" (issue NixOS#115, issue NixOS#1416) - irc: add "user" in output of irc_message_parse (issue NixOS#136) - irc: add options irc.color.message_kick and irc.color.reason_kick (issue NixOS#683, issue NixOS#684) - logger: add option logger.file.color_lines (issue NixOS#528, issue NixOS#621) - script: add options "-ol" and "-il" in command "/script list" to send translated string with list of scripts loaded, display "No scripts loaded" if no scripts are loaded - xfer: add option xfer.file.download_temporary_suffix with default value ".part" (issue NixOS#1237) Bug fixes - core: set buffer name, short name and title only if the value has changed - core: fix scrolling up in bare mode when switched to bare mode at the top of the buffer (issue NixOS#899, issue NixOS#978) - core: optimize load of configuration files - core: fix window separators not respecting window splits (issue NixOS#630) - core: fix cursor mode info when prefix_align is none and with words split across lines (issue NixOS#610, issue NixOS#617, issue NixOS#619) - core: add support of reverse video in ANSI color codes - core: fixed segfault during excessive evaluation in function string_repeat (issue NixOS#1400) - buflist: fix extra spaces between buffers when conditions are used to hide buffers (regression introduced in version 2.6) (issue NixOS#1403) - irc: do not automatically open a channel with name "0" (issue NixOS#1429) - irc: remove option irc.network.channel_encode, add server option "charset_message" to control which part of the IRC message is decoded/encoded to the target charset (issue NixOS#832) - irc: use path from option xfer.file.upload_path to complete filename in command "/dcc send" (issue NixOS#60) - logger: fix write in log file if it has been deleted or renamed (issue NixOS#123) - python: send "bytes" instead of "str" to callbacks in Python 3 when the string is not UTF-8 valid (issue NixOS#1389) - relay: send message "_buffer_title_changed" to clients only when the title is changed - xfer: fix memory leak when a xfer is freed and when the plugin is unloaded Tests - unit: add tests on GUI color functions Build - core: fix build on Haiku (issue NixOS#1420) - core: fix build on Alpine - core: remove file FindTCL.cmake - core: display an error on missing dependency in CMake (issue NixOS#916, issue NixOS#956) - debian: disable Javascript plugin on Debian Sid and Ubuntu Eoan - debian: build with Guile 2.2 - guile: add support of Guile 2.2, disable /guile eval (issue NixOS#1098) - python: add detection of Python 3.8 [1] https://weechat.org/files/changelog/ChangeLog-2.7.html (cherry picked from commit d1cb8bf)

jcumming reviewed Jun 11, 2013
View reviewed changes

peti reviewed Jun 11, 2013
View reviewed changes

lovek323 added 4 commits June 13, 2013 10:42

Add sup expression

4fe22e2

Compile libusb with gccApple on darwin

593228f

Add gpgme build input for sup

ee00c7a

sup: separate dependencies

a5e65e6

create separate expressions for gems requiring native extensions to be built: * gpgme * ncursesw_sup * xapian_full_alaveteli

lovek323 added 2 commits June 13, 2013 14:14

Rename ruby gpgme gem to ruby-gpgme

150a6a7

gnupg: use libiconvOrEmpty instead of libiconv (not required for glib…

b62aa17

…c platforms)

sup: use libiconvOrEmpty instead of plain old libiconv

6f50a9d

peti added a commit that referenced this pull request Jun 13, 2013

Merge pull request #610 from lovek323/sup

71439b3

Add sup expression

peti merged commit 71439b3 into NixOS:master Jun 13, 2013

lovek323 deleted the sup branch June 13, 2013 06:34

Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023

Uh oh!

Conversation

lovek323 commented Jun 11, 2013

Uh oh!

jcumming Jun 11, 2013

Choose a reason for hiding this comment

Uh oh!

lovek323 Jun 11, 2013

Choose a reason for hiding this comment

Uh oh!

jcumming commented Jun 11, 2013

Uh oh!

lovek323 commented Jun 11, 2013

Uh oh!

lovek323 commented Jun 11, 2013

Uh oh!

peti Jun 11, 2013

Choose a reason for hiding this comment

Uh oh!

lovek323 Jun 11, 2013

Choose a reason for hiding this comment

Uh oh!

peti commented Jun 11, 2013

Uh oh!

lovek323 commented Jun 11, 2013

Uh oh!

lovek323 commented Jun 12, 2013

Uh oh!

peti commented Jun 12, 2013

Uh oh!

lovek323 commented Jun 13, 2013

Uh oh!

lovek323 commented Jun 13, 2013

Uh oh!

vcunat commented Jun 13, 2013

Uh oh!

lovek323 commented Jun 13, 2013

Uh oh!

vcunat commented Jun 13, 2013

Uh oh!

lovek323 commented Jun 13, 2013

Uh oh!

vcunat commented Jun 13, 2013

Uh oh!

vcunat commented Jun 13, 2013

Uh oh!

lovek323 commented Jun 13, 2013

Uh oh!

lovek323 commented Jun 13, 2013

Uh oh!

vcunat commented Jun 13, 2013

Uh oh!

lovek323 commented Jun 13, 2013

Uh oh!

lovek323 commented Jun 15, 2013

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants