Skip to content

nixos-19.03: fix hardened kernels#59461

Merged
joachifm merged 1 commit intoNixOS:release-19.03from
edwintorok:release-19.03
Apr 18, 2019
Merged

nixos-19.03: fix hardened kernels#59461
joachifm merged 1 commit intoNixOS:release-19.03from
edwintorok:release-19.03

Conversation

@edwintorok
Copy link

On NixOS 19.03 I get:

Error: modDirVersion 4.19.34 specified in the Nix expression is wrong, it should be: 4.19.34-hardened

Cherry-pick 922c07d from master to fix it.

Motivation for this change

I was using the 19.03 beta (or so I thought, apparently I was actually using the unstable channel) and tried to switch to the 19.03 release version yesterday, which failed.
After cherry-picking the above commit I was able to successfully switch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The script was wrecking `modDirVersion`, putting them back and
ensuring it will not break again.
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Apr 14, 2019
@teto
Copy link
Member

teto commented Apr 14, 2019

there was a PR to automatically set this. If you are interested #31610

@joachifm
Copy link
Contributor

@GrahamcOfBorg build linux_hardened

@joachifm joachifm merged commit 534d8ff into NixOS:release-19.03 Apr 18, 2019
@joachifm
Copy link
Contributor

Thank you. As an aside, cherry-pick commits should be created with cherry-pick -x to retain a pointer to the original in the commit message.

@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants