Skip to content

linux: Automatic modDirVersion / branch#31610

Closed
NeQuissimus wants to merge 1 commit intoNixOS:masterfrom
NeQuissimus:kernel_branch
Closed

linux: Automatic modDirVersion / branch#31610
NeQuissimus wants to merge 1 commit intoNixOS:masterfrom
NeQuissimus:kernel_branch

Conversation

@NeQuissimus
Copy link
Member

Motivation for this change

This allows for meta.branch and modDirVersion to be determined automatically.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@NeQuissimus NeQuissimus added 0.kind: enhancement Add something new or improve an existing system. 6.topic: kernel The Linux kernel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS labels Nov 13, 2017
@NeQuissimus NeQuissimus changed the title linux: Automatic modDirVersion / branch [WIP] linux: Automatic modDirVersion / branch Nov 13, 2017
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Nov 13, 2017
@NeQuissimus NeQuissimus force-pushed the kernel_branch branch 2 times, most recently from b212a91 to 883e2a8 Compare November 13, 2017 14:18
@NeQuissimus NeQuissimus changed the title [WIP] linux: Automatic modDirVersion / branch linux: Automatic modDirVersion / branch Nov 13, 2017
@GrahamcOfBorg GrahamcOfBorg added the 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. label Nov 13, 2017
@NeQuissimus
Copy link
Member Author

@GrahamcOfBorg build linuxPackages_4_13.kernel

@NeQuissimus
Copy link
Member Author

Paging the Borg Queen @grahamc since I don't think the drone listens to me :D

@GrahamcOfBorg GrahamcOfBorg removed the 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. label Nov 21, 2017
@grahamc
Copy link
Member

grahamc commented Nov 21, 2017

@NeQuissimus may I recommend you try again? :)

@NeQuissimus
Copy link
Member Author

@GrahamcOfBorg build linux_4_9
linux_4_13
linux_4_14

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

error: assertion failed at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/31610/pkgs/os-specific/linux/kernel/generic.nix:32:1

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
/nix/store/529vla80wpq18rac310krywbsx7k8mmc-linux-4.9.64
/nix/store/zijd4qgxydqg1p3bl1q833bihw0smnl7-linux-4.13.15
/nix/store/nwnw1ljh7zwmcy7i09q2ck9b61kdkagz-linux-4.14.1

@teto
Copy link
Member

teto commented Dec 6, 2017

I have to add a "+" to modDirVersion currently (I suppose because it's not a tagged kernel release ?!), this doesn't seem to be possible there, does it ?

@NeQuissimus
Copy link
Member Author

You can still override modVersion

@teto
Copy link
Member

teto commented Jan 24, 2018

Would you mind rebasing ? I consistently hit the problem so that would be a nice addition to nixpkgs.

@teto
Copy link
Member

teto commented May 10, 2018

Tried rebasing at https://github.com/teto/nixpkgs/tree/moddir. It won't work when modifying kernel config with a custom LOCALVERSION.

@NeQuissimus
Copy link
Member Author

If somebody wants to give this a shot, you are most welcome. I am closing this as it is far outdated...

@teto teto mentioned this pull request Apr 14, 2019
10 tasks
@NeQuissimus NeQuissimus deleted the kernel_branch branch February 14, 2021 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: enhancement Add something new or improve an existing system. 6.topic: kernel The Linux kernel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants