Skip to content

python.pkgs.pplpy: init at 0.8.4 #56911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timokau wants to merge 2 commits into from
Closed

python.pkgs.pplpy: init at 0.8.4 #56911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23530b8
python.pkgs.cysignals: propagate pari
timokau Mar 5, 2019
008b603
python.pkgs.pplpy: init at 0.8.4
timokau Mar 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions pkgs/development/python-modules/cysignals/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,13 @@ buildPythonPackage rec {
export PATH="$out/bin:$PATH"
'';

buildInputs = lib.optionals pariSupport [
pari
];

propagatedBuildInputs = [
cython
] ++ lib.optionals pariSupport [
# When cysignals is built with pari, including cysignals into the
# buildInputs of another python package will cause cython to link against
# pari.
pari
];

enableParallelBuilding = true;
Expand Down
42 changes: 42 additions & 0 deletions pkgs/development/python-modules/pplpy/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
{ lib
, fetchPypi
, buildPythonPackage
, gmp
, mpfr
, libmpc
, ppl
, pari
, cython
, cysignals
, gmpy2_2_1
}:

buildPythonPackage rec {
pname = "pplpy";
version = "0.8.4";

src = fetchPypi {
inherit pname version;
sha256 = "0dk8l5r3f2jbkkasddvxwvhlq35pjsiirh801lrapv8lb16r2qmr";
};

buildInputs = [
gmp
mpfr
libmpc
ppl
];

propagatedBuildInputs = [
cython
cysignals
gmpy2_2_1
];

meta = with lib; {
description = "A Python wrapper for ppl";
homepage = https://gitlab.com/videlec/pplpy;
maintainers = with maintainers; [ timokau ];
license = licenses.gpl3;
};
}
14 changes: 14 additions & 0 deletions pkgs/top-level/python-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,6 +570,8 @@ in {

poetry = callPackage ../development/python-modules/poetry { };

pplpy = callPackage ../development/python-modules/pplpy { };

pprintpp = callPackage ../development/python-modules/pprintpp { };

progress = callPackage ../development/python-modules/progress { };
Expand Down Expand Up @@ -1877,6 +1879,18 @@ in {

gmpy2 = callPackage ../development/python-modules/gmpy2 { };

# alpha release, big refactor, adds cython support
# see https://github.com/aleaxit/gmpy/issues/146, https://github.com/aleaxit/gmpy/issues/199
gmpy2_2_1 = (callPackage ../development/python-modules/gmpy2 {}).overridePythonAttrs (oldAttrs: rec {
Copy link
Member

@dotlambda dotlambda Mar 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do that for Python packages because having different versions of the same package in $PYTHONPATH is not supported. You could upgrade the default gmpy2 instead.

Copy link
Member

@dotlambda dotlambda Mar 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, I don't see a specific version requirement for gmpy2 in pplpy's setup.py.

Copy link
Member Author

@timokau timokau Mar 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Their readme specifies

gmpy2: version 2.1.0a4 from sources

There is a beta release coming probably soonish (gmpy2/gmpy2#199), so maybe upgrading after that makes sense.

(I meant to ping you in the PR, not domenkozar. Damn autocomplete)

version = "2.1a4";
src = pkgs.fetchFromGitHub {
owner = "aleaxit";
repo = "gmpy";
rev = "gmpy2-${version}";
sha256 = "1wg4w4q2l7n26ksrdh4rwqmifgfm32n7x29cgdvmmbv5lmilb5hz";
};
});

gmusicapi = callPackage ../development/python-modules/gmusicapi { };

gnureadline = callPackage ../development/python-modules/gnureadline { };
Expand Down