Closed
Conversation
This didn't cause issues earlier since all packages that depend on cysignals have a pari dependency anyways.
This is a new dependency for the upcoming sage version.
GrahamcOfBorg
added
6.topic: python
dotlambda
reviewed
Mar 23, 2019
|
|
||
| # alpha release, big refactor, adds cython support | ||
| # see https://github.com/aleaxit/gmpy/issues/146, https://github.com/aleaxit/gmpy/issues/199 | ||
| gmpy2_2_1 = (callPackage ../development/python-modules/gmpy2 {}).overridePythonAttrs (oldAttrs: rec { |
Member
There was a problem hiding this comment.
We can't do that for Python packages because having different versions of the same package in $PYTHONPATH is not supported. You could upgrade the default gmpy2 instead.
Member
There was a problem hiding this comment.
However, I don't see a specific version requirement for gmpy2 in pplpy's setup.py.
Member
Author
There was a problem hiding this comment.
Their readme specifies
gmpy2: version 2.1.0a4 from sources
There is a beta release coming probably soonish (gmpy2/gmpy2#199), so maybe upgrading after that makes sense.
(I meant to ping you in the PR, not domenkozar. Damn autocomplete)
Member
Author
|
I'll include this in #54690. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This package depends on a newer version (alpha) of
gmpy2, which has significant changes (including a cython interface).I've copied the way
shpinxadds multiple versions inpython-packages.nix. I'm not sure if that is the right way to do it. @FRidh @domenkozar?Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)