termonad: Add wrapper by NeQuissimus · Pull Request #50810 · NixOS/nixpkgs

NeQuissimus · 2018-11-20T00:39:41Z

Motivation for this change

Fixes cdepillabout/termonad#34

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

/cc @cdepillabout @puffnfresh

GrahamcOfBorg · 2018-11-20T00:59:35Z

Failure on x86_64-darwin (full log)

Attempted: termonad

Partial log (click to expand)

CallStack (from HasCallStack):
  error, called at lib/Data/GI/CodeGen/LibGIRepository.hs:167:8 in haskell-gi-0.21.5-8TMPbZXMdzR6DkzsG709n8:Data.GI.CodeGen.LibGIRepository
builder for '/nix/store/6qpi0yv2pd9533ffabs9lddmr51m1fip-gi-gdkpixbuf-2.0.16.drv' failed with exit code 1
cannot build derivation '/nix/store/ibhcqy0sppb0hrcxymazwndjgibf9p3j-gi-gdk-3.0.16.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/wwbc4wd5p70dbhyh27yj5cz8bc8jymad-gi-gtk-3.0.26.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/r1ggxjdlnfpy5g21wk6rkjn972qjjdi0-gi-vte-2.91.19.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/hfndigsvrksl5zymva0qy62bdxsg680s-termonad-1.0.0.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/8s8xg5cqkvw2j5d5rf3w1krxgnpmjr5x-ghc-8.4.4-with-packages.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/cf15q4yv5dim42z0f8b03wsvjih6fhwz-termonad-with-packages-8.4.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/cf15q4yv5dim42z0f8b03wsvjih6fhwz-termonad-with-packages-8.4.4.drv' failed

GrahamcOfBorg · 2018-11-20T00:59:53Z

Success on x86_64-linux (full log)

Attempted: termonad

Partial log (click to expand)

Warning: haddock-interfaces: /nix/store/w3zbgn9mq7210vqbw3n1r4vb158lv3v4-gi-atk-2.0.15/share/doc/x86_64-linux-ghc-8.4.4/gi-atk-2.0.15/html/gi-atk.haddock doesn't exist or isn't a file
Warning: haddock-html: /nix/store/w3zbgn9mq7210vqbw3n1r4vb158lv3v4-gi-atk-2.0.15/share/doc/x86_64-linux-ghc-8.4.4/gi-atk-2.0.15/html doesn't exist or isn't a directory
Warning: haddock-interfaces: /nix/store/pkc2m4zz4r87yb28rypjccdmggc44asl-gi-cairo-1.0.17/share/doc/x86_64-linux-ghc-8.4.4/gi-cairo-1.0.17/html/gi-cairo.haddock doesn't exist or isn't a file
Warning: haddock-html: /nix/store/pkc2m4zz4r87yb28rypjccdmggc44asl-gi-cairo-1.0.17/share/doc/x86_64-linux-ghc-8.4.4/gi-cairo-1.0.17/html doesn't exist or isn't a directory
Warning: haddock-interfaces: /nix/store/1hy32shqhb6yxwwcwznvxz09101b26wq-gi-gobject-2.0.16/share/doc/x86_64-linux-ghc-8.4.4/gi-gobject-2.0.16/html/gi-gobject.haddock doesn't exist or isn't a file
Warning: haddock-html: /nix/store/1hy32shqhb6yxwwcwznvxz09101b26wq-gi-gobject-2.0.16/share/doc/x86_64-linux-ghc-8.4.4/gi-gobject-2.0.16/html doesn't exist or isn't a directory
Warning: haddock-interfaces: /nix/store/4gyj9as8ajb2cqldpp5mi3s9lhid7fl9-haskell-gi-overloading-1.0/share/doc/x86_64-linux-ghc-8.4.4/haskell-gi-overloading-1.0/html/haskell-gi-overloading.haddock doesn't exist or isn't a file
Warning: haddock-html: /nix/store/4gyj9as8ajb2cqldpp5mi3s9lhid7fl9-haskell-gi-overloading-1.0/share/doc/x86_64-linux-ghc-8.4.4/haskell-gi-overloading-1.0/html doesn't exist or isn't a directory
building '/nix/store/yrw3l7fv9r75al0m7nnjyh20a1mm5cg4-termonad-with-packages-8.4.4.drv'...
/nix/store/hs5rmd9aw6gn538z8kq8dz8pq2b5lhcl-termonad-with-packages-8.4.4

GrahamcOfBorg · 2018-11-20T02:24:12Z

Timed out, unknown build status on aarch64-linux (full log)

Attempted: termonad

Partial log (click to expand)

cannot build derivation '/nix/store/4m29hcw70mmgi2i1dj0a833xaainayyx-gi-gio-2.0.18.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/gc0j1p3ipnhzri9b41s6p3ag29rywq5l-gi-pango-1.0.16.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/0wk8j5climq3l3b36vg8ik38wz11bnpp-gi-gdkpixbuf-2.0.16.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/bcrvqzgmf0zcf2sbcgb0kswdnxrz0pzs-gi-gdk-3.0.16.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/rd2daq6sm2hcq7vmc4l66kacs1ww7vsx-gi-gtk-3.0.26.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/87viqhysg1y6bc0ykifqsyqdnzhdafbw-gi-vte-2.91.19.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/5pji4289r9z2fd3g2b04b7rfbj74py7d-termonad-1.0.0.0.drv': 25 dependencies couldn't be built
cannot build derivation '/nix/store/sdm6j3xqahzhfp0y0nd9k4a75kxrgc87-ghc-8.4.4-with-packages.drv': 116 dependencies couldn't be built
cannot build derivation '/nix/store/gcrgqm22n24yargfhn9r021dwfwm00kz-termonad-with-packages-8.4.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/gcrgqm22n24yargfhn9r021dwfwm00kz-termonad-with-packages-8.4.4.drv' failed

cdepillabout · 2018-11-20T02:39:10Z

pkgs/top-level/all-packages.nix

This should probably not be placed in the section with other shells, but instead with other terminal emulators. It should go near where roxterm, sakura, etc are defined.

Also, I think this should maybe be called termonad-with-packages (to match the xmonad-with-packages derivation).

Or, maybe keep this as termonad and at some point try to get xmonad-with-packages to be called just xmonad. I think this would be the better solution, but there will probably be some pushback from people who have been using xmonad-with-packages for a long time.

I'll move it.
I figured if you wanted "termonad-without-packages", you could just grab it from "haskellPackages", so no need to suffix it.

Yeah, I think termonad is the better name as well.

However, in this case I think it might be better to keep a similar naming scheme with other similar packages (xmonad-with-packages is the only one I know of), rather than using something different.

I'll rename it and then I think we should be good to go

cdepillabout · 2018-11-20T02:51:17Z

pkgs/shells/termonad/default.nix

It would be great to have a default argument on packages. Something like (pkgSet: []). That way people wouldn't necessarily have to give a packages argument.

It would also be nice to have a little documentation at the top of this file explaining what the packages argument is and some examples of passing stuff to it.

I'd say most(?) Termonad users will want the colour and lens packages to be available for use in their Termonad config file.

I want to avoid people pulling in packages they don't need.
If you need colour and lens, you know it and can add them :)
I'll default to an empty list.

cdepillabout · 2018-11-20T02:52:23Z

@NeQuissimus Thanks for putting together this PR!

cdepillabout · 2018-11-20T03:01:09Z

The failure on darwin is because of #46310.

@jtojnar I'd like this PR to go ahead and be merged, but is there any ETA on #46310? It'd be great to be able to compile Termonad on OSX again.

jtojnar · 2018-11-20T05:39:47Z

It will be merged just after #45950. Hopefully, it will not take much longer now that #46020 was merged.

cdepillabout · 2018-11-20T06:04:08Z

@jtojnar Okay, that sounds great! Thanks for your work on the gnome stuff.

GrahamcOfBorg · 2018-11-20T14:47:24Z

Success on x86_64-linux (full log)

Attempted: termonad

Partial log (click to expand)

cannot link '/nix/store/.links/10viy9vvg9qvp9g8yc96wxy5b05qkd5cy8gfahnl9lpnw72qiwn0' to '/nix/store/1ha0ldfgmxbf2fv0pkwm1hal2vbyknp6-ghc-8.4.4-with-packages/lib/ghc-8.4.4/x86_64-linux-ghc-8.4.4/gi-glib-2.0.17-7nKi1YphhtaFXP1jVQPMk7/GI/GLib/Structs/String.p_hi': No space left on device
cannot link '/nix/store/.links/0d9ccil9cplc4q4552byswajydr3845pv9rn90igimcwl5bfzraf' to '/nix/store/1ha0ldfgmxbf2fv0pkwm1hal2vbyknp6-ghc-8.4.4-with-packages/lib/ghc-8.4.4/x86_64-linux-ghc-8.4.4/tf-random-0.5-BZa4jMFCdGCK8yjkzN18lQ/System/Random/TF.dyn_hi': No space left on device
cannot link '/nix/store/.links/1z9lwfgmifbj5risfi6w6fkv816xn33h6s02i7w2nkbf4r824f7k' to '/nix/store/1ha0ldfgmxbf2fv0pkwm1hal2vbyknp6-ghc-8.4.4-with-packages/lib/ghc-8.4.4/x86_64-linux-ghc-8.4.4/free-5.0.2-9YwOntPoa3ICp0MejrYokl/Control/Alternative/Free/Final.hi': No space left on device
cannot link '/nix/store/.links/01a8gdv1xfxbmcs8x628abvrxl0rg5gc6c87gdyrlcad3l89w85q' to '/nix/store/1ha0ldfgmxbf2fv0pkwm1hal2vbyknp6-ghc-8.4.4-with-packages/lib/ghc-8.4.4/x86_64-linux-ghc-8.4.4/StateVar-1.1.1.1-95mVnsqAWWrCsY5lrWtwY9/libHSStateVar-1.1.1.1-95mVnsqAWWrCsY5lrWtwY9_p.a': No space left on device
cannot link '/nix/store/.links/0ms8z35rbyypld1wnwwv1wfi9lvi04y6pdxxbym8335jkg7zal6q' to '/nix/store/1ha0ldfgmxbf2fv0pkwm1hal2vbyknp6-ghc-8.4.4-with-packages/lib/ghc-8.4.4/x86_64-linux-ghc-8.4.4/gi-gio-2.0.18-96GK5aAuJiKFPWF5P4Swp5/GI/Gio/Objects/SocketControlMessage.hi': No space left on device
cannot link '/nix/store/.links/03k7hdb46bl532szssf3x0siqdy2lajdrkklmhjm2dmqacxddpz5' to '/nix/store/1ha0ldfgmxbf2fv0pkwm1hal2vbyknp6-ghc-8.4.4-with-packages/lib/ghc-8.4.4/x86_64-linux-ghc-8.4.4/blaze-builder-0.4.1.0-CjLn59HtBD2K57iSylQxeq/Blaze/ByteString/Builder/Html/Word.dyn_hi': No space left on device
cannot link '/nix/store/.links/1wnm9drhkl5q3fmsf7305cgg2dh13hhkvjg3mmrzxbz92srckb47' to '/nix/store/1ha0ldfgmxbf2fv0pkwm1hal2vbyknp6-ghc-8.4.4-with-packages/lib/ghc-8.4.4/x86_64-linux-ghc-8.4.4/th-desugar-1.8-K49xPnGHhnaEgW9zVWFfhd/Language/Haskell/TH/Desugar/Match.hi': No space left on device
cannot link '/nix/store/.links/1h10zgpnqax14m06za447ix47v4x3kmn5zh6khwd51mwwclskrha' to '/nix/store/1ha0ldfgmxbf2fv0pkwm1hal2vbyknp6-ghc-8.4.4-with-packages/lib/ghc-8.4.4/ghc-8.4.4/Plugins.dyn_hi': No space left on device
building '/nix/store/55qpr9ajw6xriz8fl8hciyv1bppn66i1-termonad-with-packages-8.4.4.drv'...
/nix/store/xxyvyxw0crnx9fq1dird790a8srb6zis-termonad-with-packages-8.4.4

GrahamcOfBorg · 2018-11-20T15:32:57Z

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: termonad

Partial log (click to expand)

#if ENABLE_OVERLOADING
building of '/nix/store/6wzk2y72v9d0j99ci9jp5ps4ddl52sjs-gi-gio-2.0.18.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/wq5x9y28b1vzymphld1mc0y498f7a71i-gi-gdkpixbuf-2.0.16.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/hjqf94my09g4yx97lmkhdn8fb497md2m-gi-gdk-3.0.16.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/y7hcj6jnsvkvsk3vv9v52x5akyw1g675-gi-gtk-3.0.26.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/gq3gbf3y52azd07sd7y8d7ni3kw08aly-gi-vte-2.91.19.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/cbjc9s7rhh6cymhjshxr2ypx0cqk6p97-termonad-1.0.0.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/iy5qp3b8qxx230i2azs5dj05fiwpsjs2-ghc-8.4.4-with-packages.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/csh9dw7hlfkznffhzyfwm52jb4p2l9d9-termonad-with-packages-8.4.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/csh9dw7hlfkznffhzyfwm52jb4p2l9d9-termonad-with-packages-8.4.4.drv' failed

GrahamcOfBorg · 2018-11-20T15:42:50Z

Timed out, unknown build status on aarch64-linux (full log)

Attempted: termonad

Partial log (click to expand)

cannot build derivation '/nix/store/mxbzxqfb7vjmkzk5713ki63acjfb4kz8-gi-gio-2.0.18.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/igc148d6sjhjbdmfi3dri38f7b70fhlr-gi-pango-1.0.16.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/dfvlj5m6pqsq9qb1a1vs7i06927ja226-gi-gdkpixbuf-2.0.16.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/k43kapw779bsd47n62bmnc4dnj8j96k5-gi-gdk-3.0.16.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/5ykfih7hdzqj3gnqdwmcm9g6dnmb15rz-gi-gtk-3.0.26.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/2rb63918m66pxdwa51d1lk8rxfq882b9-gi-vte-2.91.19.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/w9n3xrg8j5aaw1v0nwjdm5613kqzqgds-termonad-1.0.0.0.drv': 25 dependencies couldn't be built
cannot build derivation '/nix/store/laz348k46pi4jswmk9yq75rn0wajwjpj-ghc-8.4.4-with-packages.drv': 116 dependencies couldn't be built
cannot build derivation '/nix/store/zn4ysk0sjrsynxydx41y462lgk0jhmws-termonad-with-packages-8.4.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/zn4ysk0sjrsynxydx41y462lgk0jhmws-termonad-with-packages-8.4.4.drv' failed

NeQuissimus added the 8.has: package (new) This PR adds a new package label Nov 20, 2018

NeQuissimus force-pushed the termonad branch from c5f2cb5 to 12c32cf Compare November 20, 2018 00:40

GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 20, 2018

cdepillabout reviewed Nov 20, 2018

View reviewed changes

NeQuissimus force-pushed the termonad branch from 12c32cf to 1934ba3 Compare November 20, 2018 14:27

termonad: Add wrapper

3dd96c6

NeQuissimus force-pushed the termonad branch from 1934ba3 to 3dd96c6 Compare November 21, 2018 13:11

NeQuissimus merged commit 823cd6e into NixOS:master Nov 22, 2018

NeQuissimus deleted the termonad branch November 22, 2018 01:27

cdepillabout mentioned this pull request Nov 22, 2018

get termonad-with-packages into nixpkgs cdepillabout/termonad#34

Closed

Uh oh!

Conversation

NeQuissimus commented Nov 20, 2018

Motivation for this change

Things done

Uh oh!

GrahamcOfBorg commented Nov 20, 2018

Uh oh!

GrahamcOfBorg commented Nov 20, 2018

Uh oh!

GrahamcOfBorg commented Nov 20, 2018

Uh oh!

cdepillabout Nov 20, 2018

Choose a reason for hiding this comment

Uh oh!

cdepillabout Nov 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NeQuissimus Nov 20, 2018

Choose a reason for hiding this comment

Uh oh!

cdepillabout Nov 20, 2018

Choose a reason for hiding this comment

Uh oh!

NeQuissimus Nov 21, 2018

Choose a reason for hiding this comment

Uh oh!

cdepillabout Nov 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NeQuissimus Nov 20, 2018

Choose a reason for hiding this comment

Uh oh!

cdepillabout commented Nov 20, 2018

Uh oh!

cdepillabout commented Nov 20, 2018

Uh oh!

jtojnar commented Nov 20, 2018

Uh oh!

cdepillabout commented Nov 20, 2018

Uh oh!

GrahamcOfBorg commented Nov 20, 2018

Uh oh!

GrahamcOfBorg commented Nov 20, 2018

Uh oh!

GrahamcOfBorg commented Nov 20, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cdepillabout Nov 20, 2018 •

edited

Loading

cdepillabout Nov 20, 2018 •

edited

Loading