gobject-introspection: Fix macos shared lib paths

[hamishmack]

This applies the proposed upstream patch (described in https://gitlab.gnome.org/GNOME/gobject-introspection/issues/222) before applying the current nixpkgs patches (which had to be updated slightly to apply on top of the upsteam patch).

I tested this fix by building haskellPackages.gi-atk and haskellPackages.gi-gdkpixbuf build on macos (both of which had were broken by #40599). I also checked the @rpath was gone in:

$ cat $(nix-build ./default.nix -A atk.dev --system x86_64-darwin)/share/gir-1.0/Atk-1.0.gir | grep shared-library
             shared-library="/nix/store/25659xy1p1naj0c0rc1xf9bfj4l1ryij-atk-2.28.1/lib/libatk-1.0.0.dylib"

Things done:

• Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
• Built on platform(s)
  • NixOS
  • OS X
  • Linux
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

More

Fixes issue #

cc @

---

Please note, that points are not mandatory, but rather desired.

[jtojnar]

Can't submit a PR because the code has changed and seems to be overall not working at all

https://gitlab.gnome.org/GNOME/gobject-introspection/issues/222#note_302924

[jtojnar]

Also relevant #45950, which updates gobject-introspection.

[hamishmack]

Can't submit a PR because the code has changed and seems to be overall not working at all

@jtojnar I presume that is in reference to the upstream git repo for gobject-introspection.

Also relevant #45950, which updates gobject-introspection.

I have sent PR #46312 to to update the gnome-3.30 branch. Should we close this PR in favour of that one? Will gnome-3.30 be merged soon?

[jtojnar]

Will this fix https://hydra.nixos.org/build/82003202?

[hamishmack]

Yes

[matthewbauer]

Looks good to me! Make sure it goes into staging though.

[cdepillabout]

@matthewbauer @hamishmack @jtojnar
Any update on this PR or #46312?

The gi-atk Haskell package is not building for me on darwin, and I think either this PR or #46312 would fix it.

[jtojnar]

It would be nice to have some tests, otherwise most of us really cannot ensure it works.

[cdepillabout]

@jtojnar What sort of tests are you thinking of?

I would think that if the haskellPackages.gi-atk package can be built, it would be a sign that this PR works?

I cherry-picked the change from this PR to the top of current master and confirmed that both ATK and haskellPackages.gi-atk compiled on darwin:

cdepillabout@d753fb7

(However, now I am having trouble with #41340. I don't think it is related to this patch.)