Skip to content

cctag: use boost186 to fix build error#496871

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
hesiod:cctag-fix
Mar 10, 2026
Merged

cctag: use boost186 to fix build error#496871
Aleksanaa merged 1 commit intoNixOS:masterfrom
hesiod:cctag-fix

Conversation

@hesiod
Copy link
Contributor

@hesiod hesiod commented Mar 5, 2026

cctag is incompatible with Boost 1.89 at the moment due to the dropped Boost.System find_package component and boost::system meta library.
Also includes some random cleanups (finalAttrs pattern, use of lib.cmakeBool).

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@hesiod hesiod mentioned this pull request Mar 5, 2026
15 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 5, 2026
@hesiod
Copy link
Contributor Author

hesiod commented Mar 5, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 496871
Commit: a59b64c25450e34c4def58dedf9f19f76b6831a9 (subsequent changes)
Merge: 571371381397e50ab882360a8408c39d31656a4a

Logs: https://github.com/hesiod/nixpkgs-review-gha/actions/runs/22717509893


x86_64-linux

✅ 2 packages built:
  • cctag
  • cctag.dev

aarch64-linux

✅ 2 packages built:
  • cctag
  • cctag.dev

x86_64-darwin (sandbox = relaxed)

✅ 2 packages built:
  • cctag
  • cctag.dev

aarch64-darwin (sandbox = relaxed)

✅ 2 packages built:
  • cctag
  • cctag.dev

@hesiod hesiod marked this pull request as ready for review March 5, 2026 12:24
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Mar 5, 2026
@hesiod
Copy link
Contributor Author

hesiod commented Mar 6, 2026

Just removed a stray comment in the last push, the derivation is identical to the one reviewed using nixpkgs-review.


"-DCCTAG_BUILD_TESTS=${if doCheck then "ON" else "OFF"}"
"-DCCTAG_BUILD_APPS=OFF"
(lib.cmakeBool "CCTAG_BUILD_TESTS" finalAttrs.doCheck)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(lib.cmakeBool "CCTAG_BUILD_TESTS" finalAttrs.doCheck)
(lib.cmakeBool "CCTAG_BUILD_TESTS" finalAttrs.finalPackage.doCheck)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I applied this - I've seen this pattern in lots of places but haven't found any rationale so far. Would you mind explaining why this is the preferred version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finalAttrs is for attributes of the builder, but finalPackage is for the final applied attributes of the derivation. In this case doCheck can be overriden by lower mkDerivation function in cross compilation: https://github.com/NixOS/nixpkgs/blob/master/pkgs/stdenv/generic/make-derivation.nix#L385

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Mar 7, 2026
cctag is incompatible with Boost 1.89 at the moment due to the dropped
Boost.System find_package component and boost::system meta library.
@hesiod hesiod requested a review from Aleksanaa March 9, 2026 19:08
@Aleksanaa Aleksanaa enabled auto-merge March 10, 2026 02:33
@Aleksanaa Aleksanaa added this pull request to the merge queue Mar 10, 2026
Merged via the queue into NixOS:master with commit e607cb5 Mar 10, 2026
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants