cctag: use boost186 to fix build error#496871
Conversation
|
|
Just removed a stray comment in the last push, the derivation is identical to the one reviewed using nixpkgs-review. |
pkgs/by-name/cc/cctag/package.nix
Outdated
|
|
||
| "-DCCTAG_BUILD_TESTS=${if doCheck then "ON" else "OFF"}" | ||
| "-DCCTAG_BUILD_APPS=OFF" | ||
| (lib.cmakeBool "CCTAG_BUILD_TESTS" finalAttrs.doCheck) |
There was a problem hiding this comment.
| (lib.cmakeBool "CCTAG_BUILD_TESTS" finalAttrs.doCheck) | |
| (lib.cmakeBool "CCTAG_BUILD_TESTS" finalAttrs.finalPackage.doCheck) |
There was a problem hiding this comment.
Thanks, I applied this - I've seen this pattern in lots of places but haven't found any rationale so far. Would you mind explaining why this is the preferred version?
There was a problem hiding this comment.
finalAttrs is for attributes of the builder, but finalPackage is for the final applied attributes of the derivation. In this case doCheck can be overriden by lower mkDerivation function in cross compilation: https://github.com/NixOS/nixpkgs/blob/master/pkgs/stdenv/generic/make-derivation.nix#L385
cctag is incompatible with Boost 1.89 at the moment due to the dropped Boost.System find_package component and boost::system meta library.
cctag is incompatible with Boost 1.89 at the moment due to the dropped Boost.System find_package component and boost::system meta library.
Also includes some random cleanups (finalAttrs pattern, use of lib.cmakeBool).
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.