x265: enable multibitdepth on aarch64-linux#493861
Closed
JamieMagee wants to merge 0 commit intoNixOS:stagingfrom
Closed
x265: enable multibitdepth on aarch64-linux#493861JamieMagee wants to merge 0 commit intoNixOS:stagingfrom
JamieMagee wants to merge 0 commit intoNixOS:stagingfrom
Conversation
Contributor
There was a problem hiding this comment.
The PR's base branch is set to master, but this PR causes 13832 rebuilds.
It is therefore considered a mass rebuild.
Please change the base branch to the right base branch for your changes (probably staging).
Contributor
There was a problem hiding this comment.
The PR's base branch is set to staging, but 8 commits from the master branch are included. Make sure you know the right base branch for your changes, then:
- If the changes should go to the
masterbranch, change the base branch. - If the changes should go to the
stagingbranch, rebase your PR onto the correct merge-base:# git rebase --onto $(git merge-base upstream/staging HEAD) $(git merge-base upstream/master HEAD) git rebase --onto 46ca68c26436e0678e396ce7acd756d482401942 22874fc8a1c78712f082120ae9555eb57cd57dd1 git push --force-with-lease
250086a to
f4b1044
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
multibitdepthSupportparameter currently excludes aarch64-linux:This exclusion was added with the original multibitdepth support in #92052 (2020), back when x265 3.x didn't have 10-bit or 12-bit aarch64 assembly primitives. The
PFXmacro would expand to symbols likex265_12bit_pixel_satd_4x4_neonthat didn't exist, causing link failures (see #154347 for details).x265 has had working aarch64 HBD support since 4.0 (release notes).
Without multibitdepth, the only supported pixel format on aarch64 is
yuv420p(8-bit). Any 10-bit input, which is common from modern cameras, causes ffmpeg's libx265 encoder to fail with:I hit this running Home Assistant's
streamcomponent on a Raspberry Pi 5. Camera streams using HEVC would crash in PyAV'savcodec_open2(libx265)call.This PR removes the aarch64-linux exclusion so
multibitdepthSupportis juststdenv.hostPlatform.is64bit.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.