tree-sitter-grammars: fix version attributes to follow nixpkgs conventions#492132
Merged
teto merged 1 commit intoNixOS:masterfrom Feb 24, 2026
Merged
tree-sitter-grammars: fix version attributes to follow nixpkgs conventions#492132teto merged 1 commit intoNixOS:masterfrom
teto merged 1 commit intoNixOS:masterfrom
Conversation
This was referenced Feb 19, 2026
tree-sitter-grammars.tree-sitter-xml: 0-unstable-2023-01-17 -> rel-0.0.2-unstable-2023-01-17
#491951
Closed
Closed
tree-sitter-grammars.tree-sitter-pascal: 0-unstable-2025-05-17 -> 0.10.2-unstable-2025-12-23
#491945
Closed
Closed
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yesterday I've been flooded by automatic updates by @r-ryantm for a lot of grammars. @NickCao closed them referencing #491704 (you can see the list there).
Today it sent another 6 PRs that are both updated just
version(same rev) and also update one version.To my understanding the
versionI've used isn't following the convention and this is why @r-ryantm updates is.I've also realized that for several grammars there were real stable versions available so I updated them, probably an oversight by me when I first added them (they were too many).
The entire reason why these grammars were added was because of #452275 so in theory they are used only by it (which overrides the versions anyway). Instead
diffsitterwill be affected since it depends on all the grammars. For the rest it should harmless and safe to merge 🤞Things done
upstream tag: awk, bicep, blade, csv, dbml, diff, gitcommit, hurl,
inko, pascal, pest, ponylang, powershell, purescript, robot,
sourcepawn, t32, teal, xit
incorrectly used
0-unstable-*: capnp, clarity, cylc, d, dhall,fsharp, gas, ghostty, gren, hoon, htmldjango, ini, ink, koto, matlab,
nim, odin, openscad, org, php-only, pkl, prolog, properties, rescript,
ron, slang, smali, snakemake, sway, tact, thrift, vhdl, yuck
vprefix (nim, hoon,gas, dhall, xit, ghostty), use
recwith expliciturlcontaining?ref=${version}to construct the correct flake referencepascal, t32, robot, matlab, openscad)
I've tried running
nixpkgs-updateand it does nothing now, so I hope that after this PR I'll not be flooded anymore and I'll be able to process only real ones.Tagging all the people who has been involved into this somethow: @teto @kimburgess @andresilva
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.