Skip to content

minio: mark package as insecure#491337

Draft
britter wants to merge 2 commits intoNixOS:masterfrom
britter:britter/mark-minio-insecure
Draft

minio: mark package as insecure#491337
britter wants to merge 2 commits intoNixOS:masterfrom
britter:britter/mark-minio-insecure

Conversation

@britter
Copy link
Contributor

@britter britter commented Feb 17, 2026

Context: #490996

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 17, 2026
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 17, 2026
@britter britter requested a review from herbetom February 17, 2026 13:34
@britter
Copy link
Contributor Author

britter commented Feb 17, 2026

@herbetom good idea. Applied your suggestion. Do you know when would be a good point in time to remove the package completely for 26.05?

@herbetom
Copy link
Member

herbetom commented Feb 17, 2026

Thinking about it, it might make sense to have a slightly better (a bit more elaborate, or some link to some place where alternatives are mentioned (thinking about this comment)) message and then backport this to 25.11.
That way stable users also get a headsup it's unmaintained and will be dropped. But not so sure about the customs in that regard.
My gut feeling for removal on unstable would then be like 4 weeks from now. Surely not a long time but 26.05 also isn't far away.

@bachp
Copy link
Member

bachp commented Feb 17, 2026

Do any of the proposed alternatives already have a nixos module?

@mweinelt
Copy link
Member

Ceph and Garage have modules and tests

@britter
Copy link
Contributor Author

britter commented Feb 18, 2026

@herbetom how about f7b1609?

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 18, 2026
@bachp
Copy link
Member

bachp commented Feb 18, 2026

@britter minio was moved to pkgs-by-name in #486114.

Can you resolve the merge conflict.

@britter britter force-pushed the britter/mark-minio-insecure branch from f7b1609 to 2a00b09 Compare February 19, 2026 07:40
@britter britter requested a review from mweinelt February 19, 2026 07:40
@britter
Copy link
Contributor Author

britter commented Feb 19, 2026

@bachp done!

Copy link
Member

@herbetom herbetom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

$ nix-build -A minio
[...]
       error: Package ‘minio-2025-10-15T17-29-55Z’ in /home/tom/git/NixOS/nixpkgs/pkgs/by-name/mi/minio/package.nix:69 is marked as insecure, refusing to evaluate.


       Known issues:
        - minio has been abandoned by upstream and will be removed for 26.05. Users should migrate to alternatives such as Garage, SeaweedFS, or Ceph. S3-compatible clients such as rclone can be used to move data.

       You can install it anyway by allowing this package, using the
       following methods:
[...]

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 2.status: merge conflict This PR has merge conflicts with the target branch 12.approvals: 1 This PR was reviewed and approved by one person. labels Feb 19, 2026
@LeSuisse
Copy link
Member

This will require a bit more work, it will impact too many packages right now if we mark it insecure.

We might need to disable the S3 tests in pkgs/by-name/ar/arrow-cpp/package.nix and pkgs/by-name/ce/ceph/arrow-cpp-19.nix until arrow-cpp upstream do something about it.
apache/arrow#47908

@britter
Copy link
Contributor Author

britter commented Feb 19, 2026

This will require a bit more work, it will impact too many packages right now if we mark it insecure.

What do you mean specifically other than disabling the tests that you've listed?

@LeSuisse
Copy link
Member

We have a bunch of NixOS tests that would be great to convert to an alternative:

  • nixos/tests/atticd.nix
  • nixos/tests/clickhouse/s3.nix
  • nixos/tests/ente/default.nix
  • nixos/tests/nextcloud/with-objectstore.nix
  • nixos/tests/thanos.nix
  • nixos/tests/web-apps/lasuite-docs.nix

I suppose the NixOS modules depending on Minio in some ways can be adjusted later on, users will need to handle the move between the services.

  • nixos/modules/services/development/athens.nix
  • nixos/modules/services/misc/gitea.nix
  • nixos/modules/services/web-apps/ente.md (documentation update)
  • nixos/modules/services/web-apps/hedgedoc.nix (documentation update)
  • nixos/modules/services/web-apps/outline.nix (documentation update)
  • nixos/modules/virtualisation/incus.nix

(Did not look at the usage of minio-client...)

@britter

This comment was marked as outdated.

@britter britter closed this Feb 19, 2026
@britter britter deleted the britter/mark-minio-insecure branch February 19, 2026 13:43
@britter britter restored the britter/mark-minio-insecure branch February 19, 2026 18:46
@britter britter reopened this Feb 19, 2026
@britter britter marked this pull request as draft February 19, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants