Skip to content

various: refactor and move to pkgs/by-name#486114

Merged
gepbird merged 17 commits intoNixOS:masterfrom
quantenzitrone:move-to-pkgs-by-name-5
Feb 18, 2026
Merged

various: refactor and move to pkgs/by-name#486114
gepbird merged 17 commits intoNixOS:masterfrom
quantenzitrone:move-to-pkgs-by-name-5

Conversation

@quantenzitrone
Copy link
Contributor

@quantenzitrone quantenzitrone commented Feb 2, 2026 •
edited
Loading

Things done

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Feb 2, 2026
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Feb 2, 2026
@quantenzitrone quantenzitrone force-pushed the move-to-pkgs-by-name-5 branch 2 times, most recently from 74b02f2 to 670ff14 Compare February 2, 2026 05:32
@quantenzitrone quantenzitrone marked this pull request as ready for review February 2, 2026 05:36
@nixpkgs-ci nixpkgs-ci bot requested review from MarcWeber and yurrriq February 2, 2026 05:37
@quantenzitrone quantenzitrone changed the title various: move to pkgs/by-name & refactor various: move to pkgs/by-name & refactor some a bit Feb 2, 2026
qweered
qweered approved these changes Feb 3, 2026
View reviewed changes
Copy link
Contributor

@qweered qweered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified commit by commit, lgtm

@nixpkgs-ci nixpkgs-ci bot added 2.status: merge conflict This PR has merge conflicts with the target branch 12.approvals: 1 This PR was reviewed and approved by one person. labels Feb 3, 2026
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 3, 2026
@quantenzitrone quantenzitrone changed the title various: move to pkgs/by-name & refactor some a bit various: refactor and move to pkgs/by-name Feb 10, 2026
@quantenzitrone
Copy link
Contributor Author

quantenzitrone commented Feb 10, 2026

i made a few more refactorial changes, switching everything to finalAttrs, hash and tag

gepbird
gepbird reviewed Feb 10, 2026
View reviewed changes
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lilypond refactor is a slightly bigger change, I suggest splitting it up to multiple commits or even into a new PR.
openlilylib-fonts could be also moved to by-name, but not in this PR.

I tested the update scripts, otherwise looks good.

pkgs/by-name/sh/shishi/package.nix
Comment on lines 38 to 41
Copy link
Contributor

@gepbird gepbird Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you wanted to keep a nice 0 rebuild count. Do you plan to resolve this in a follow up PR?

Copy link
Contributor Author

@quantenzitrone quantenzitrone Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is about the rebuild count.
I don't plan to make a follow-up pr specifically for this, but refactoring usages of null packages is a thing i might do in the future.

github-actions[bot]

This comment was marked as outdated.

Sign in to view

@nixpkgs-ci nixpkgs-ci bot requested review from bachp and ryan4yin February 11, 2026 11:22
@quantenzitrone quantenzitrone mentioned this pull request Feb 14, 2026
Open
3 tasks
@gepbird
Copy link
Contributor

gepbird commented Feb 14, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 486114 --package pkgsStatic.sks
Commit: 3976349d53cc4872186b2f9b9ed9b929718309e4

x86_64-linux

✅ 2 packages built:
  • pkgsStatic.sks
  • pkgsStatic.sks.webSamples (pkgsStatic.sks.webSamples.webSamples)

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Feb 14, 2026
@quantenzitrone
lilypond{,-unstable,-with-fonts}: refactor and move to pkgs/by-name
311ab4c 
especially refactor updateScript

this shouldn't create any rebuilds
@quantenzitrone
adwaita-qt: refactor and move to pkgs/by-name
6cb35db 
this shouldn't create any rebuilds
@quantenzitrone
isso: refactor and move to pkgs/by-name
dec64f6 
this shouldn't create any rebuilds
@quantenzitrone
dcnnt: refactor and move to pkgs/by-name
be06328 
this shouldn't create any rebuilds
@quantenzitrone
persistent-evdev: refactor and move to pkgs/by-name
1fb6041 
this shouldn't create any rebuilds
@quantenzitrone
shairplay: refactor and move to pkgs/by-name
76b4072 
this shouldn't create any rebuilds
@quantenzitrone
shishi: refactor and move to pkgs/by-name
677f75b 
this shouldn't create any rebuilds
@quantenzitrone
tang: refactor and move to pkgs/by-name
9625797 
this shouldn't create any rebuilds
@quantenzitrone
tautulli: refactor and move to pkgs/by-name
d93d34d 
this shouldn't create any rebuilds
@quantenzitrone
minio: refactor and move to pkgs/by-name
668e706 
this shouldn't create any rebuilds
@quantenzitrone
libasn1c: refactor and move to pkgs/by-name
6a41df4 
this shouldn't create any rebuilds
@quantenzitrone
polaris{,-web}: refactor and move to pkgs/by-name
6d8153d 
this shouldn't create any rebuilds
@quantenzitrone
sks: refactor and move to pkgs/by-name
fbec393 
this shouldn't create any rebuilds
@quantenzitrone
prosody: move to pkgs/by-name
0128258 
this shouldn't create any rebuilds
@quantenzitrone
jackett: refactor and move to pkgs/by-name
85a2e4f 
refactor: switch to nix-update instead of custom script

this shouldn't create any rebuilds
@quantenzitrone
qremotecontrol-server: move to pkgs/by-name
8cdd194 
this shouldn't create any rebuilds
@quantenzitrone
sks: fix on static
9230e29
@quantenzitrone
Copy link
Contributor Author

quantenzitrone commented Feb 18, 2026

rebased to fix merge conflicts

@gepbird gepbird added this pull request to the merge queue Feb 18, 2026
Merged via the queue into NixOS:master with commit c2bb61a Feb 18, 2026
27 checks passed
@quantenzitrone quantenzitrone deleted the move-to-pkgs-by-name-5 branch February 18, 2026 06:54
@bachp bachp mentioned this pull request Feb 18, 2026
Draft
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@bachp bachp bachp approved these changes

@gepbird gepbird gepbird approved these changes

@MarcWeber MarcWeber Awaiting requested review from MarcWeber

@yurrriq yurrriq Awaiting requested review from yurrriq

@ryan4yin ryan4yin Awaiting requested review from ryan4yin

+1 more reviewer

@qweered qweered qweered approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@quantenzitrone @gepbird @bachp @qweered