[Backport release-25.11] various: use finalAttrs

[matthiasbeyer]

Warning

This will most likely conflict with the normal package updates being backported.

I think it is worth it though.

Let's see what my CI run tells us about this patchset.

(And thanks to the original contributor at #486938 - @chrjabs ❤️ )

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

[github-actions]

This report is automatically generated by the PR / Check / cherry-pick CI workflow.

Some of the commits in this PR require the author's and reviewer's attention.

Sometimes it is not possible to cherry-pick exactly the same patch.
This most frequently happens when resolving merge conflicts.
The range-diff will help to review the resolution of conflicts.

If you need to merge this PR despite the warnings, please dismiss this review shortly before merging.

Warning

Difference between d8c54cc and original 6d511b3 may warrant inspection.

Show diff

@@ Metadata
  ## Commit message ##
     cargo-nextest: use finalAttrs
 
+    (cherry picked from commit 6d511b35b920229fec5cbbef897816641b7d6273)
+    Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
+
  ## pkgs/by-name/ca/cargo-nextest/package.nix ##
 @@
    nix-update-script,
@@ pkgs/by-name/ca/cargo-nextest/package.nix
 -rustPlatform.buildRustPackage rec {
 +rustPlatform.buildRustPackage (finalAttrs: {
    pname = "cargo-nextest";
-   version = "0.9.124";
+   version = "0.9.114";
  
    src = fetchFromGitHub {
      owner = "nextest-rs";
      repo = "nextest";
--    tag = "cargo-nextest-${version}";
+-    rev = "cargo-nextest-${version}";
 +    tag = "cargo-nextest-${finalAttrs.version}";
-     hash = "sha256-qvJ/dqbls2fVSPY++kYBIeiu14eDD8ORuvcD8dEtMZ8=";
+     hash = "sha256-0l8+YKIdKhvwdEbvSgYcX1deq+aRZkxXUCw2zMSO4cU=";
    };
  
 @@ pkgs/by-name/ca/cargo-nextest/package.nix: rustPlatform.buildRustPackage rec {
-       chrjabs
+       matthiasbeyer
      ];
    };
 -}

Hint: The full diffs are also available in the runner logs with slightly better highlighting.

Patches could not be cherry-picked automatically because of different package versions on master and release branch. TL;DR: Resolved conflicts by hand

[matthiasbeyer]

I am not sure how I can trigger the CI here... nixpkgs-review won't run until github actions ran apparently 🤔

[figsoda]

I don't think buildPython* supports finalAttrs on release-25.11, the backport pr for it (#476950) is not merged yet

[github-actions]

This report is automatically generated by the PR / Check / cherry-pick CI workflow.

Some of the commits in this PR require the author's and reviewer's attention.

Sometimes it is not possible to cherry-pick exactly the same patch.
This most frequently happens when resolving merge conflicts.
The range-diff will help to review the resolution of conflicts.

If you need to merge this PR despite the warnings, please dismiss this review shortly before merging.

Warning

Difference between d8c54cc and original 6d511b3 may warrant inspection.

Show diff

@@ Metadata
  ## Commit message ##
     cargo-nextest: use finalAttrs
 
+    (cherry picked from commit 6d511b35b920229fec5cbbef897816641b7d6273)
+    Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
+
  ## pkgs/by-name/ca/cargo-nextest/package.nix ##
 @@
    nix-update-script,
@@ pkgs/by-name/ca/cargo-nextest/package.nix
 -rustPlatform.buildRustPackage rec {
 +rustPlatform.buildRustPackage (finalAttrs: {
    pname = "cargo-nextest";
-   version = "0.9.124";
+   version = "0.9.114";
  
    src = fetchFromGitHub {
      owner = "nextest-rs";
      repo = "nextest";
--    tag = "cargo-nextest-${version}";
+-    rev = "cargo-nextest-${version}";
 +    tag = "cargo-nextest-${finalAttrs.version}";
-     hash = "sha256-qvJ/dqbls2fVSPY++kYBIeiu14eDD8ORuvcD8dEtMZ8=";
+     hash = "sha256-0l8+YKIdKhvwdEbvSgYcX1deq+aRZkxXUCw2zMSO4cU=";
    };
  
 @@ pkgs/by-name/ca/cargo-nextest/package.nix: rustPlatform.buildRustPackage rec {
-       chrjabs
+       matthiasbeyer
      ];
    };
 -}

Hint: The full diffs are also available in the runner logs with slightly better highlighting.

[matthiasbeyer]

Ah okay, I removed the buildPython commit 😉

its okay