various: use finalAttrs#486938
Conversation
|
Nice initiative! But yes, please split this per-package and commit it with Besides that I'd approve! |
Would you say keep it in one PR, or split it into multiple PRs as well? |
|
one PR is fine for me. |
2376f5c to
26b3fbc
Compare
|
Alright, split into separate commits now |
|
matthiasbeyer
left a comment
There was a problem hiding this comment.
Approved automatically following the successful run of nixpkgs-review.
matthiasbeyer
left a comment
There was a problem hiding this comment.
Awesome!
I reviewed the patches individually (thanks again for splitting them) and am building now.
If everything is green I'll merge!
|
Enough said... that build run was really fast, probably because the outputs didn't change at all 👀 🤔 Lets gooo 🚀 |
|
@NixOS/nixpkgs-merge-bot merge |
|
@matthiasbeyer wants to merge this PR. Requirements to merge this PR with
Tip Maintainers eligible to merge are:
❌ Pull Request could not be merged (#305350) |
|
Lets see whether this is backportable. |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.11
git worktree add -d .worktree/backport-486938-to-release-25.11 origin/release-25.11
cd .worktree/backport-486938-to-release-25.11
git switch --create backport-486938-to-release-25.11
git cherry-pick -x 95b818aef4928a61bdc842f442ffb1eac1963cbb 7072712e6c7e7010b988e70a33924065be3418fe 6d511b35b920229fec5cbbef897816641b7d6273 034a17fc0e931263ff014144e846f40f7515e8cc 4a52bbaaa50303ba431850f46673f309a11993e9 35a0098b984216bf0ca7f32f8392ca9c80a2734a f5f2f5e5b1d1e460b862ea2c8addf4d60c9f85ae d37f2a1961732415cafacd74af027ee064a4e104 6a8d682e258c63458d11e9643270cd60b8d4892a 5d04ea3062555470d30c94a2f41c77c1dfddf43d 3d460ad397775ba106f10122c7f43a4c2ccbd720 97061e298c02003fe38ea9c9d8e0ea6fffca03f2 26b3fbc4ce2c491823c53c966822502c2bdced81 |
|
Okay, by hand then! |
finalAttrsmigration for all packages I'm a maintainer for.Let me know if I should split this out into separate commits/PRs or what the commit message for a single commit should be.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.