Skip to content

various: use finalAttrs#486938

Merged
matthiasbeyer merged 13 commits intoNixOS:masterfrom
chrjabs:push-zqxwzmnkzrro
Feb 5, 2026
Merged

various: use finalAttrs#486938
matthiasbeyer merged 13 commits intoNixOS:masterfrom
chrjabs:push-zqxwzmnkzrro

Conversation

@chrjabs
Copy link
Contributor

@chrjabs chrjabs commented Feb 4, 2026

finalAttrs migration for all packages I'm a maintainer for.
Let me know if I should split this out into separate commits/PRs or what the commit message for a single commit should be.

  • cadical
  • cargo-machete
  • cargo-nextest
  • cargo-rdme
  • cargo-semver-checks
  • cargo-show-asm
  • cargo-spellcheck
  • cargo-udeps
  • cargo-valgrind
  • kissat
  • release-plz
  • typos
  • python3Packages.python-sat

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 6.topic: python Python is a high-level, general-purpose programming language. labels Feb 4, 2026
@matthiasbeyer
Copy link
Contributor

matthiasbeyer commented Feb 4, 2026

Nice initiative!

But yes, please split this per-package and commit it with <package name>: Move to finalAttrs or something like that.

Besides that I'd approve!

@chrjabs
Copy link
Contributor Author

chrjabs commented Feb 4, 2026

Nice initiative!

But yes, please split this per-package and commit it with <package name>: Move to finalAttrs or something like that.

Besides that I'd approve!

Would you say keep it in one PR, or split it into multiple PRs as well?

@matthiasbeyer
Copy link
Contributor

one PR is fine for me.

@chrjabs
Copy link
Contributor Author

chrjabs commented Feb 5, 2026

Alright, split into separate commits now

@matthiasbeyer
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 486938
Commit: 26b3fbc4ce2c491823c53c966822502c2bdced81

Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

I reviewed the patches individually (thanks again for splitting them) and am building now.

If everything is green I'll merge!

@matthiasbeyer
Copy link
Contributor

Enough said... that build run was really fast, probably because the outputs didn't change at all 👀 🤔

Lets gooo 🚀

@matthiasbeyer
Copy link
Contributor

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Feb 5, 2026

@matthiasbeyer wants to merge this PR.

Requirements to merge this PR with @NixOS/nixpkgs-merge-bot merge:

  • ✅ PR targets a development branch.
  • ❌ PR touches only files of packages in pkgs/by-name/.
  • ✅ PR is at least one of:
    • ✅ Approved by a committer.
    • ⬜ Backported via label.
    • ⬜ Opened by a committer.
    • ⬜ Opened by r-ryantm.
  • ✅ matthiasbeyer is a member of @NixOS/nixpkgs-maintainers.

Tip

Maintainers eligible to merge are:

  • chrjabs

❌ Pull Request could not be merged (#305350)

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Feb 5, 2026
@matthiasbeyer matthiasbeyer added this pull request to the merge queue Feb 5, 2026
Merged via the queue into NixOS:master with commit 02dd9a3 Feb 5, 2026
30 checks passed
@matthiasbeyer
Copy link
Contributor

Lets see whether this is backportable.

@matthiasbeyer matthiasbeyer added the backport release-25.11 Backport PR automatically label Feb 5, 2026
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Feb 5, 2026

Backport failed for release-25.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.11
git worktree add -d .worktree/backport-486938-to-release-25.11 origin/release-25.11
cd .worktree/backport-486938-to-release-25.11
git switch --create backport-486938-to-release-25.11
git cherry-pick -x 95b818aef4928a61bdc842f442ffb1eac1963cbb 7072712e6c7e7010b988e70a33924065be3418fe 6d511b35b920229fec5cbbef897816641b7d6273 034a17fc0e931263ff014144e846f40f7515e8cc 4a52bbaaa50303ba431850f46673f309a11993e9 35a0098b984216bf0ca7f32f8392ca9c80a2734a f5f2f5e5b1d1e460b862ea2c8addf4d60c9f85ae d37f2a1961732415cafacd74af027ee064a4e104 6a8d682e258c63458d11e9643270cd60b8d4892a 5d04ea3062555470d30c94a2f41c77c1dfddf43d 3d460ad397775ba106f10122c7f43a4c2ccbd720 97061e298c02003fe38ea9c9d8e0ea6fffca03f2 26b3fbc4ce2c491823c53c966822502c2bdced81

@matthiasbeyer
Copy link
Contributor

Okay, by hand then!

@chrjabs chrjabs deleted the push-zqxwzmnkzrro branch February 11, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. backport release-25.11 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants