Skip to content

nixos/n8n: add custom nodes option#484577

Merged
gepbird merged 2 commits intoNixOS:masterfrom
sweenu:n8n_custom_nodes
Jan 29, 2026
Merged

nixos/n8n: add custom nodes option#484577
gepbird merged 2 commits intoNixOS:masterfrom
sweenu:n8n_custom_nodes

Conversation

@sweenu
Copy link
Contributor

@sweenu sweenu commented Jan 28, 2026 •
edited by gepbird
Loading

Adds an option to the n8n module for custom nodes.
Also added a first custom node: n8n-nodes-carbonejs

I wonder if the custom node packages should be built in the n8n directory rather than their own?

Fixes #435198

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot added 8.has: package (new) This PR adds a new package 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 28, 2026
@sweenu sweenu force-pushed the n8n_custom_nodes branch 3 times, most recently from f7caaba to ce6a5ee Compare January 28, 2026 01:41
@sweenu sweenu marked this pull request as draft January 28, 2026 01:42
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jan 28, 2026
@sweenu sweenu marked this pull request as ready for review January 28, 2026 12:21
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jan 28, 2026
@sweenu sweenu requested a review from gepbird January 28, 2026 21:08
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jan 28, 2026
gepbird
gepbird reviewed Jan 28, 2026
View reviewed changes
Copy link
Contributor

@gepbird gepbird left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I wonder if the custom node packages should be built in the n8n directory rather than their own?

It should go separate directories, so the current one is good. Later we may move it into something like a package set, but currently this is the best solution as otherwise you'd need to do callPackage ../by-name/n8/n8n/xyz-plugin.nix { } in all-packages.nix which is an anti-pattern.

I briefly tested it, I see the carbone node in the web app.

gepbird
gepbird reviewed Jan 29, 2026
View reviewed changes
Copy link
Contributor

@gepbird gepbird left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge your last commit into the init package commit. Also run nix fmt or make sure the files are formatted.

gepbird
gepbird reviewed Jan 29, 2026
View reviewed changes
@sweenu
Copy link
Contributor Author

sweenu commented Jan 29, 2026

@gepbird Could the current CI error be unrelated to my changes?

@gepbird
Copy link
Contributor

gepbird commented Jan 29, 2026 •
edited
Loading

@gepbird Could the current CI error be unrelated to my changes?

It looks unrelated, I restarted it once and got the same error.
Maybe rebasing to latest master will help. I see this for other recently updated PRs too. Hopefully it will be fixed in a few hours, most likely by #485118.

@gepbird
Copy link
Contributor

gepbird commented Jan 29, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 484577 --package nixosTests.n8n
Commit: cf277b7d086322093cbffb784c35111608ea2146

x86_64-linux

✅ 1 test built:
  • nixosTests.n8n

@gepbird
Copy link
Contributor

gepbird commented Jan 29, 2026

Can you rebase again? The supposed fix was merged.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 29, 2026
@gepbird gepbird added this pull request to the merge queue Jan 29, 2026
Merged via the queue into NixOS:master with commit d8a10b4 Jan 29, 2026
64 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gepbird gepbird gepbird approved these changes

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature Request: Support Community Nodes in the n8n Module

2 participants

@sweenu @gepbird