Skip to content

pkgs/by-name: nested by-name for package sets proof of concept#483432

Draft
quantenzitrone wants to merge 2 commits intoNixOS:masterfrom
quantenzitrone:nested-by-name
Draft

pkgs/by-name: nested by-name for package sets proof of concept#483432
quantenzitrone wants to merge 2 commits intoNixOS:masterfrom
quantenzitrone:nested-by-name

Conversation

@quantenzitrone
Copy link
Contributor

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 24, 2026
@Sigmanificient
Copy link
Member

Sigmanificient commented Jan 24, 2026

While this seems better to me than #483128, i am still more fan of the first proposed solution with pkgs/sets to be honest.

My main issue with this approach it that it break my expectation of pkgs/by-name with the introduction of nesting. Having conditional behavior with if lib.pathIsRegularFile seems like a bit wanky, and it would be solved by having a simple of pkgs/sets grouping everything together to in a flat structure.

I am also concern about the possibility of some sets being hidden from simple github navigation, as it would be the case with lixPackageSets, since it end up at the end of pkgs/by-name/li which is already truncated.

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 24, 2026
@gepbird gepbird mentioned this pull request Jan 28, 2026
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants