Skip to content

Comments

wasm: add as temporary alias to proglodyte-wasm#48444

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
Ekleog:wasm-alias
Oct 21, 2018
Merged

wasm: add as temporary alias to proglodyte-wasm#48444
Mic92 merged 1 commit intoNixOS:masterfrom
Ekleog:wasm-alias

Conversation

@Ekleog
Copy link
Member

@Ekleog Ekleog commented Oct 15, 2018

Motivation for this change

Completion of #44962, esp. #44962 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 15, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: wasm

Partial log (click to expand)

these paths will be fetched (18.25 MiB download, 95.39 MiB unpacked):
  /nix/store/2v3whmcll5hiffwxdjbf68i9vamq6y9y-wasm-0.0.1
  /nix/store/9r816i9apd5f0aqj5mbqcwqmm89c2p1v-icu4c-58.2
  /nix/store/fyd0fji91l1j8lxw6rla7vh7fyp9gvqp-v8-5.4.232
  /nix/store/fzdlk99zl4cnjip2zvxc1r5khycs09h4-sexpr_wasm_prototype
copying path '/nix/store/fzdlk99zl4cnjip2zvxc1r5khycs09h4-sexpr_wasm_prototype' from 'https://cache.nixos.org'...
copying path '/nix/store/9r816i9apd5f0aqj5mbqcwqmm89c2p1v-icu4c-58.2' from 'https://cache.nixos.org'...
copying path '/nix/store/fyd0fji91l1j8lxw6rla7vh7fyp9gvqp-v8-5.4.232' from 'https://cache.nixos.org'...
copying path '/nix/store/2v3whmcll5hiffwxdjbf68i9vamq6y9y-wasm-0.0.1' from 'https://cache.nixos.org'...
/nix/store/2v3whmcll5hiffwxdjbf68i9vamq6y9y-wasm-0.0.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: wasm

Partial log (click to expand)

  /nix/store/8zfcy60in5fb7q8ca5qg12bqayzags4l-wasm-0.0.1
  /nix/store/giph2ybkq543x8ngv3g38ridxyzdqiq0-icu4c-58.2
  /nix/store/svhhjyj6j7g8ki080xllcibqwpdsgban-gcc-6.4.0-lib
  /nix/store/yrphky8j1a6qiklp8fnq9x7snsj2zna6-v8-5.4.232
copying path '/nix/store/svhhjyj6j7g8ki080xllcibqwpdsgban-gcc-6.4.0-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/2d1242aay9zdf26pymljkwjq2vppnr0n-sexpr_wasm_prototype' from 'https://cache.nixos.org'...
copying path '/nix/store/giph2ybkq543x8ngv3g38ridxyzdqiq0-icu4c-58.2' from 'https://cache.nixos.org'...
copying path '/nix/store/yrphky8j1a6qiklp8fnq9x7snsj2zna6-v8-5.4.232' from 'https://cache.nixos.org'...
copying path '/nix/store/8zfcy60in5fb7q8ca5qg12bqayzags4l-wasm-0.0.1' from 'https://cache.nixos.org'...
/nix/store/8zfcy60in5fb7q8ca5qg12bqayzags4l-wasm-0.0.1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have pkgs/top-level/aliases.nix for that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know about it, thanks! :) I've just pushed a version using aliases.nix, though the lib.warn appears to still be necessary as I didn't get any warning when trying to build without it.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 16, 2018
@Mic92 Mic92 merged commit ec488f6 into NixOS:master Oct 21, 2018
@pbogdan
Copy link
Member

pbogdan commented Oct 22, 2018

FYI this seems to make the tarball job unhappy https://hydra.nixos.org/build/83154880/nixlog/1.

@Ekleog
Copy link
Member Author

Ekleog commented Oct 22, 2018

Yeah, sounds like the tarball job denies warnings. A bit of digging showed it's due to nix-env -qa displaying all these warnings. I opened #48810 (already cherry-picked on master, don't know what GitHub currently shows :)), doing what other packages appear to do: just rename and add a line to release notes. Kind of sad we don't have a better deprecation mechanism, though :/

@ryantm
Copy link
Member

ryantm commented Oct 22, 2018

There's an open RFC for deprecation NixOS/rfcs#33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants