wasm: rename unofficial package into proglodyte-wasm#44962
wasm: rename unofficial package into proglodyte-wasm#44962matthewbauer merged 1 commit intoNixOS:masterfrom
Conversation
|
This will probably need an alias. |
|
Hmmm, so alias for 18.09, and after branch-off remove the alias? (the idea, at least for me, is to avoid tricking people into thinking that's a kind of “official” wasm interpreter, as that was what I thought until I came upon Anyway, the following plan would likely make for less disruption than my initial idea of just removing the
Does that sound good to you? |
|
@matthewbauer Up. Does that sound good to you? (we already missed the 18.09 branch-off)
|
|
Yeah sounds ok. |
|
@matthewbauer Erhm… the PR wasn't actually adding the alias yet, as I was unsure this was OK with you :'( I've opened #48444 to add the alias back, think it'd be great if this could get merged ASAP to avoid in-between hydra bumps. (either that or live with the absence of alias, but that was the original issue :/) |
Motivation for this change
The package is a concurrent to the official wasm interpreter (available as
ocamlPackages.wasm), so I think the name is treacherous :)If this could get in before 18.09 branch-off it'd likely be best, as it's a breaking change.
cc @proglodyte
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)