Skip to content

.devcontainer: change nixfmt-rfc-style to nixfmt#483193

Merged
SigmaSquadron merged 1 commit intoNixOS:masterfrom
ethancedwards8:devcontainer-nixfmt
Jan 23, 2026
Merged

.devcontainer: change nixfmt-rfc-style to nixfmt#483193
SigmaSquadron merged 1 commit intoNixOS:masterfrom
ethancedwards8:devcontainer-nixfmt

Conversation

@ethancedwards8
Copy link
Member

@ethancedwards8 ethancedwards8 commented Jan 23, 2026

It has been 5 months. We're probably good to go now.

Related:

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

It has been 5 months. We're probably good to go now.

Signed-off-by: Ethan Carter Edwards <ethan@ethancedwards.com>
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 23, 2026
Copy link
Contributor

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nixfmt package now refers to the new RFC style in all supported Nixpkgs versions (25.11 and 26.05-unstable). 25.05 support was dropped roughly a month ago in #476384

On that basis, I agree. This is good to go, thanks!

(FYI for topics like this, you can ping the @NixOS/nix-formatting team rather than individuals)

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Jan 23, 2026
@SigmaSquadron SigmaSquadron added this pull request to the merge queue Jan 23, 2026
Merged via the queue into NixOS:master with commit 1d9d406 Jan 23, 2026
34 of 37 checks passed
@MattSturgeon MattSturgeon added the backport release-25.11 Backport PR automatically label Jan 24, 2026
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 24, 2026

Successfully created backport PR for release-25.11:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. backport release-25.11 Backport PR automatically

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants