Skip to content

.devcontainer: nixfmt-rfc-style -> nixfmt#430330

Merged
drupol merged 1 commit intoNixOS:masterfrom
drupol:push-rumtomvwqmqw
Aug 4, 2025
Merged

.devcontainer: nixfmt-rfc-style -> nixfmt#430330
drupol merged 1 commit intoNixOS:masterfrom
drupol:push-rumtomvwqmqw

Conversation

@drupol
Copy link
Contributor

@drupol drupol commented Aug 2, 2025

Follow up of #425068

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@drupol drupol requested a review from infinisil August 2, 2025 10:08
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 2, 2025
@drupol drupol merged commit 66023e4 into NixOS:master Aug 4, 2025
27 of 29 checks passed
@drupol drupol deleted the push-rumtomvwqmqw branch August 4, 2025 13:50
@infinisil
Copy link
Member

Wait is devcontainer using the in-tree version of Nixpkgs? Because if it's not doing that, then this PR shouldn't be done, because out-of-tree version of Nixpkgs still sometimes have nixfmt pointing at the classic version, see #425583

@infinisil
Copy link
Member

And make sure to ping/request reviews @NixOS/nix-formatting for formatting-related things, not just me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants