python2Packages.buildPytonPackage: restructure with lib.extendMkDerivation#481423
Open
ShamrockLee wants to merge 7 commits intoNixOS:masterfrom
Open
python2Packages.buildPytonPackage: restructure with lib.extendMkDerivation#481423ShamrockLee wants to merge 7 commits intoNixOS:masterfrom
ShamrockLee wants to merge 7 commits intoNixOS:masterfrom
Conversation
Port to python2/mk-python-derivation.nix commit 21a1cf9 ("mkPythonPackage, mkPythonApplication: handle passthru with mkDerivation").
…hru attrs Port to python2/mk-python-derivation.nix commit d6a757b ("buildPython*: prioritize user-specified passthru attrs").
Port to python2/mk-python-derivation.nix commit 8fd082e ("mk-python-derivation: passthru disabled"). Co-authored-by: Peder Bergebakken Sundt <pbsds@hotmail.com>
…rrideAttrs Port to python2/mk-python-derivation.nix commit bb3a41f ("buildPython*: fix the disabled functionality for overrideAttrs-")
…ttrs Port to python2/mk-python-derivation.nix commit bc122a6 ("python3Packages.buildPythonPackage: remove ineffective outputs cleanAttrs").
…ation Port to python2/mk-python-derivation.nix commit 0969c66 (buildPython*: support fixed-point arguments via lib.extendMkDerivation") Postpone formatting to minimize diff.
…dMkDerivation restructuring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially addresses issue #477098
This PR ports the following PRs:
passthruwithstdenv.mkDerivationinstead oflib.extendDerivation#347130disabled#328421disabledeffect after<pkg>.overrideAttrs#376419and partially ports the following PRs:
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.