Skip to content

mk-python-derivation: passthru disabled#328421

Merged
mweinelt merged 1 commit intoNixOS:masterfrom
pbsds:feat-python-passthru-disable-1721390585
Jan 8, 2025
Merged

mk-python-derivation: passthru disabled#328421
mweinelt merged 1 commit intoNixOS:masterfrom
pbsds:feat-python-passthru-disable-1721390585

Conversation

@pbsds
Copy link
Member

@pbsds pbsds commented Jul 19, 2024

Description of changes

Enables outside testing of whether a package is supported for the current interpreter

nix-repl> python311.pkgs.nose.disabled 
false

nix-repl> python312.pkgs.nose.disabled 
true

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pbsds pbsds marked this pull request as ready for review July 19, 2024 12:16
@pbsds pbsds requested a review from natsukium as a code owner July 19, 2024 12:16
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 19, 2024
@pbsds pbsds requested a review from mweinelt July 19, 2024 12:16
@pbsds pbsds force-pushed the feat-python-passthru-disable-1721390585 branch from 8998c9f to f9cbc7f Compare July 19, 2024 12:17
@pbsds pbsds changed the title mkPythonDerivation: passthru disabled mk-python-derivation: passthru disabled Jul 19, 2024
@pbsds
Copy link
Member Author

pbsds commented Jul 19, 2024

I also want disabled to affect meta.available so we get better feedback on hydra, any preferences about how that could be done?

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 19, 2024
@pbsds
Copy link
Member Author

pbsds commented Sep 12, 2024

bump

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 1, 2024
@pbsds pbsds force-pushed the feat-python-passthru-disable-1721390585 branch from f9cbc7f to 69634ce Compare January 8, 2025 19:10
@pbsds pbsds removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 8, 2025
@pbsds
Copy link
Member Author

pbsds commented Jan 8, 2025

rebased, and made it overrideable

Enables outside testing of whether a package is supported for the current interpreter
@pbsds pbsds force-pushed the feat-python-passthru-disable-1721390585 branch from 69634ce to 8fd082e Compare January 8, 2025 23:37
@mweinelt mweinelt merged commit a9e2a5b into NixOS:master Jan 8, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants