python3Packages.fints: 4.2.4 -> 5.0.0

[devurandom]

As far as I could tell there is no change log. Breaking changes are listed in https://github.com/raphaelm/python-fints/blob/v5.0.0/docs/upgrading_4_5.rst

Also: Pin pretix-banktool and saldo to fints v4.

Closes: #466577

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[devurandom]

Input from "hexa" on Matrix: This will break pretix-banktool, cf. https://github.com/pretix/pretix-banktool/blob/0ba22e16e40a15139c271513e756a075ff207490/pyproject.toml#L21. I created an upstream issue to track this: pretix/pretix-banktool#13

[dotlambda]

Maybe we should use pythonRelaxDeps to unbreak pretix-banktool?

[devurandom]

TIL: https://nixos.org/manual/nixpkgs/unstable/#using-pythonrelaxdepshook
Thanks for pointing this out!

Applied in https://github.com/NixOS/nixpkgs/compare/37c3a511b7a0402b94d1714acb71a3113b8a5876..347b5465a5e921b3e8e9d4d80c8ffd594200ee3a

Other packages:

• home-assistant (unaffected):

  • nixpkgs/pkgs/servers/home-assistant/component-packages.nix

    Lines 1770 to 1773 in cc3ab37

    	"fints" =
    	ps: with ps; [
    	fints
    	];

  • https://github.com/home-assistant/core/blob/bdbce57217cf681415de259ed9701c10ee74dbbb/requirements_all.txt#L961-L962
  • Already relaxes all deps:

    nixpkgs/pkgs/servers/home-assistant/default.nix

    Line 330 in cc3ab37

    pythonRelaxDeps = true;

• saldo (unaffected):

  • nixpkgs/pkgs/by-name/sa/saldo/package.nix

    Line 58 in cc3ab37

    fints

  • Already does not depend on a specific version: https://gitlab.com/tabos/saldo/-/blob/7775aa22a0be73c45b9ad0eacf339c97fd2d2a46/requirements.txt#L1

[mweinelt]

Maybe we should use pythonRelaxDeps to unbreak pretix-banktool?

Have you checked for API breakage before suggesting that?

[dotlambda]

Maybe we should use pythonRelaxDeps to unbreak pretix-banktool?

Have you checked for API breakage before suggesting that?

No, that's why it was formulated as a question.

[devurandom]

Maybe we should use pythonRelaxDeps to unbreak pretix-banktool?

Have you checked for API breakage before suggesting that?

I did a quick check by reading the source code and left my findings in pretix/pretix-banktool#13 (comment) (might be interesting not just to NixOS).

[devurandom]

@mweinelt: Is there anything else I could do, apart from pretix/pretix-banktool#13 (comment), to move this PR forward?

[mweinelt]

We could pin pretix-banktool at fints 4.2.4 for now.

[devurandom]

Thanks for your review, @dotlambda ! I split my changes into multiple commits and created a version-pinned copy of the fints package, similar to what I saw elsewhere when people were pinning a version. Is this PR now in the shape you'd expect?

[SuperSandro2000]

LGTM

[devurandom]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 478074 --additional-package saldo --additional-package pretix-banktool
Commit: 4d21579e0ac6e003b60803cd59f3b3e713eb5115

(nixpkgs-review missed that pretix-banktool and saldo had changed, so I passed them via --additional-package.)

---

x86_64-linux

✅ 8 packages built:

• pretix-banktool
• pretix-banktool.dist
• python313Packages.fints
• python313Packages.fints.dist
• python314Packages.fints
• python314Packages.fints.dist
• saldo
• tests.home-assistant-component-tests.fints

[devurandom]

I found nixpkgs-review and through it noticed that:

• I had forgotten to expose fints_4 into python3Packages
• saldo was also affected, so I also pinned that
• pkgs/servers/home-assistant/ has a "component" that depends on fints, but to pin that, too, I'll need more time -- it was not immediately obvious to me where a good place for a pin would be.

[dotlambda]

• pkgs/servers/home-assistant/ has a "component" that depends on fints, but to pin that, too, I'll need more time -- it was not immediately obvious to me where a good place for a pin would be.

Why do you want to pin that if it builds fine with version 5?
This would be the required diff:

diff --git a/pkgs/servers/home-assistant/default.nix b/pkgs/servers/home-assistant/default.nix
index 706a3ff038b9..313a6d3da2e4 100644
--- a/pkgs/servers/home-assistant/default.nix
+++ b/pkgs/servers/home-assistant/default.nix
@@ -87,6 +87,8 @@ let
         ];
       });
 
+      fints = self.fints_4;
+
       gspread = super.gspread.overridePythonAttrs (oldAttrs: rec {
         version = "5.12.4";
         src = fetchFromGitHub {

[dotlambda]

nixpkgs-review missed that pretix-banktool and saldo had changed

They didn't change because you pinned fints to the old version, so they evaluate to the exact same derivation as before.

[dotlambda]

saldo builds fine with fints v5, so it shouldn't use fints_4

[devurandom]

pkgs/servers/home-assistant/ has a "component" that depends on fints

Why do you want to pin that if it builds fine with version 5?

I thought the same that applies to pretix-banktool also applies here: Just knowing that it builds does not mean it'll actually work, and since I don't have a setup to actually confirm that it works, I'll pin it. (Which is also why I thought I'd have to pin saldo as well.)

saldo builds fine with fints v5, so it shouldn't use fints_4

Changed in https://github.com/NixOS/nixpkgs/compare/4d21579e0ac6e003b60803cd59f3b3e713eb5115..b6759cb075e728884d3c89328ea65b7912696ec0.

[dotlambda]

I thought the same that applies to pretix-banktool also applies here: Just knowing that it builds does not mean it'll actually work, and since I don't have a setup to actually confirm that it works, I'll pin it. (Which is also why I thought I'd have to pin saldo as well.)

I wouldn't worry about saldo as much because it doesn't pin a certain version of fints.

[dotlambda]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 478074
Commit: b6759cb075e728884d3c89328ea65b7912696ec0

---

x86_64-linux

✅ 6 packages built:

• python313Packages.fints
• python313Packages.fints.dist
• python314Packages.fints
• python314Packages.fints.dist
• saldo
• tests.home-assistant-component-tests.fints

[dotlambda]

Approved automatically following the successful run of nixpkgs-review.