python3Packages.mitmproxy: fix build error and aioquic dependency issue#494138
Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom Feb 26, 2026
Merged
python3Packages.mitmproxy: fix build error and aioquic dependency issue#494138SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Conversation
eetwas
force-pushed
the
fix/python-mitmproxy
branch
from
16ea6d9 to
39ee0a0
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
eetwas
force-pushed
the
fix/python-mitmproxy
branch
2 times, most recently
from
24a22dd to
1df1a7f
Compare
eetwas
force-pushed
the
fix/python-mitmproxy
branch
from
1df1a7f to
5b77ac0
Compare
Member
|
Thanks for opening the PR btw. That helps me a lot while fixing other things ❤️ |
SuperSandro2000
approved these changes
Feb 26, 2026
nixpkgs-ci
bot
added
12.approvals: 1
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
devurandom
reviewed
Feb 26, 2026
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix mitmproxy build failure due to python dependency updates (as seen in #493860).
These fixes include pinning aioquic to version 1.2.0 for mitmproxy due to breaking changes within the 1.3.0 update and mitmproxy not yet having a patch ready for it (see mitmproxy/mitmproxy#7953 as well as aiortc/aioquic@773ec8a).
I am happy for feedback on this, since this solution is less than ideal, but with the 1.3.0 update already having been committed, this felt like the quickest least intrusive way to solve this issue.
Closes #493860
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.