coloquinte: 0.3.1 -> 0.4.3

[gonsolo]

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[gonsolo]

Could you review, @eljamm?

[gonsolo]

I updated because it fails as a dependency of my lemon-graph PR at
#477756:

      > /build/source/src/place_detailed/tetris_legalizer.cpp: In member function 'std::pair<bool, int> coloquinte::TetrisLegalizer::attemptPlacement(int, int) const':
       > /build/source/src/place_detailed/tetris_legalizer.cpp:48:20: error: 'clamp' is not a member of 'std'
       >    48 |     int pos = std::clamp(x, b, e);
       >       |                    ^~~~~

lemon-graph is needed for openroad, which is needed for Librelane which I am trying to package for Nix.
@NixOS/nixpkgs-committers This is one of seven PRs for Librelane.

[eljamm]

lemon-graph is needed for openroad, which is needed for Librelane which I am trying to package for Nix.

I've opened a fix for openroad to unbreak the build until it's updated.

NixOS/nixpkgs-committers This is one of seven PRs for Librelane.

You probably know this by know, but I just want to add my voice to this comment and kindly ask you to refrain from pinging all committers in the future.

[eljamm]

nixpkgs-review result for #477801

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 477801
Commit: 7fed1f3ae63e2ed1e5e1377ae74d1159387f02a1 (subsequent changes)
Merge: 29def4060bacaae5b1e034586e834d41f7e12d15

Logs: https://github.com/eljamm/nixpkgs-review-gha/actions/runs/20813967052

---

x86_64-linux

✅ 1 package built:

• coloquinte

---

aarch64-linux

✅ 1 package built:

• coloquinte

[eljamm]

Can't request review from package maintainer @Coloquinte through GitHub, so I'm manually pinging him, instead.

[gonsolo]

I've opened a fix for openroad to unbreak the build until it's updated.

Thanks.

You probably know this by know, but I just want to add my voice to this comment and kindly ask you to refrain from pinging all committers in the future.

I just read my email and already responded to that. And of course I will refain from doing that.
Thanks for your patience!

[gonsolo]

Can't request review from package maintainer @Coloquinte through GitHub, so I'm manually pinging him, instead.

Thanks.

Since the dependency graph is something like this
coloquinte <- lemon-graph <- openroad upgrade <- librelane
, @donn or @mole99 may be interested.

[donn]

Coloquinte Place&Route depends on lemon-graph, not the other way around. We don't currently have anything that depends on Coloquinte Place&Route. If the tests pass I say go for it.

[gonsolo]

Duplicate: #475612

[gonsolo]

Since the maintainer is on Github but not in Nix, maybe @GaetanLepage or @NickCao can help out?

[Hythera]

Can we close this PR as #475612 already covers the update or is this needed for the other issue?

[gonsolo]

Can we close this PR as #475612 already covers the update or is this needed for the other issue?

I wasn't sure which PR would get merged first so I let it open. But if you think the other one gets merged, yes.

[Hythera]

Usually the first (older) PR gets priority 👍

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2725