Skip to content

netgen-vlsi: init at 1.5.314#477797

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
gonsolo:netgen-vlsi
Jan 12, 2026
Merged

netgen-vlsi: init at 1.5.314#477797
GaetanLepage merged 1 commit intoNixOS:masterfrom
gonsolo:netgen-vlsi

Conversation

@gonsolo
Copy link
Contributor

@gonsolo gonsolo commented Jan 7, 2026

Part of mission to package Librelane.

@nixpkgs-ci nixpkgs-ci bot added 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Jan 7, 2026
@gonsolo gonsolo changed the title Netgen vlsi netgen-vlsi: init at 1.5.269 Jan 8, 2026
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Jan 8, 2026
@nixpkgs-ci nixpkgs-ci bot removed the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 8, 2026
@gonsolo gonsolo marked this pull request as ready for review January 8, 2026 20:51
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jan 8, 2026
@gonsolo
Copy link
Contributor Author

gonsolo commented Jan 8, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 477797
Commit: df14128b25c78c269c866632039264a6d87c2b08


x86_64-linux

✅ 1 package built:
  • netgen-vlsi

@gonsolo gonsolo requested review from donn, eljamm and hzeller January 8, 2026 20:58
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jan 8, 2026
Copy link
Member

@donn donn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly fine, though a bit bloated? You may use https://github.com/fossi-foundation/nix-eda/blob/main/nix/netgen.nix as a reference which is a simpler derivation we've been using since 2013 2023, albeit, we don't support X11 so you have a strict upgrade in terms of that.

@gonsolo
Copy link
Contributor Author

gonsolo commented Jan 9, 2026

Broadly fine, though a bit bloated? You may use https://github.com/fossi-foundation/nix-eda/blob/main/nix/netgen.nix as a reference which is a simpler derivation we've been using since 2013 2023, albeit, we don't support X11 so you have a strict upgrade in terms of that.

Thanks for reviewing.
I applied all your suggestions.

@donn donn self-requested a review January 9, 2026 12:44
@gonsolo gonsolo force-pushed the netgen-vlsi branch 2 times, most recently from ebbed51 to 7707584 Compare January 10, 2026 12:32
@gonsolo gonsolo changed the title netgen-vlsi: init at 1.5.269 netgen-vlsi: init at 1.5.314 Jan 10, 2026
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 477797
Commit: 7707584edb335a422e20c14b184cac1f83b18c49


x86_64-linux

✅ 1 package built:
  • netgen-vlsi

aarch64-linux

✅ 1 package built:
  • netgen-vlsi

x86_64-darwin

✅ 1 package built:
  • netgen-vlsi

aarch64-darwin

✅ 1 package built:
  • netgen-vlsi

@GaetanLepage
Copy link
Contributor

Some patching might be necessary. When I run the executable I get:

bash: ./results/netgen-vlsi-x86_64-linux/bin/netgen: /bin/bash: bad interpreter: No such file or directory

@gonsolo
Copy link
Contributor Author

gonsolo commented Jan 10, 2026

Some patching might be necessary. When I run the executable I get:

bash: ./results/netgen-vlsi-x86_64-linux/bin/netgen: /bin/bash: bad interpreter: No such file or directory

That's weird:

gonsolo nixpkgs:nix build .#netgen-vlsi
gonsolo nixpkgs:./result/bin/netgen -batch
Netgen 1.5.314 compiled on Sat Jan 10 10:55:32 UTC 2026
Warning: netgen command 'format' use fully-qualified name '::netgen::format'
Warning: netgen command 'global' use fully-qualified name '::netgen::global'

Without -batch it opens a window. No error here.

Do you have an idea why we get different result?

I added wrapProgram. It should work now.

@gonsolo gonsolo force-pushed the netgen-vlsi branch 3 times, most recently from 921893a to ada35cd Compare January 10, 2026 15:12
@gonsolo
Copy link
Contributor Author

gonsolo commented Jan 10, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 477797
Commit: ada35cdf1abbb3fe30b89330c13567ee468d4695


x86_64-linux

✅ 1 package built:
  • netgen-vlsi

@GaetanLepage
Copy link
Contributor

I added wrapProgram. It should work now.

I don't think it's a matter of wrapping. You should try using patchShebangs instead: https://nixos.org/manual/nixpkgs/unstable/#patch-shebangs.sh

@gonsolo
Copy link
Contributor Author

gonsolo commented Jan 11, 2026

I don't think it's a matter of wrapping. You should try using patchShebangs instead: https://nixos.org/manual/nixpkgs/unstable/#patch-shebangs.sh

I tried various variations of patchShebangs; nothing worked. EDA tools are notorious for their creative Makefiles.
I opted for a sed script instead. Are you ok with that @GaetanLepage?

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@gonsolo
Copy link
Contributor Author

gonsolo commented Jan 12, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 477797
Commit: 2becf50c5f400895de3d6316847d75e9db26bd08


x86_64-linux

✅ 1 package built:
  • netgen-vlsi

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 477797
Commit: 2becf50c5f400895de3d6316847d75e9db26bd08


x86_64-linux

✅ 1 package built:
  • netgen-vlsi

aarch64-linux

✅ 1 package built:
  • netgen-vlsi

x86_64-darwin

✅ 1 package built:
  • netgen-vlsi

aarch64-darwin

✅ 1 package built:
  • netgen-vlsi

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@GaetanLepage GaetanLepage added this pull request to the merge queue Jan 12, 2026
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Jan 12, 2026
@gonsolo
Copy link
Contributor Author

gonsolo commented Jan 12, 2026

Thanks very much for your work, @GaetanLepage! Much appreciated!! 😄

Merged via the queue into NixOS:master with commit a9852c2 Jan 12, 2026
32 of 34 checks passed
@gonsolo gonsolo deleted the netgen-vlsi branch January 12, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants