Skip to content

temporal_capi: improve pkg-config integration#477738

Merged
nixpkgs-ci[bot] merged 1 commit intoNixOS:masterfrom
aduh95:temporal-capi
Jan 7, 2026
Merged

temporal_capi: improve pkg-config integration#477738
nixpkgs-ci[bot] merged 1 commit intoNixOS:masterfrom
aduh95:temporal-capi

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 7, 2026

Things done

It was brought to my attention in #476902 (comment) that lib name can be added to the package metadata, so this PR updates this derivation to match the recommendations in https://nixos.org/manual/nixpkgs/stable/#pkg-config-writing-packages

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Jan 7, 2026
@aduh95
Copy link
Contributor Author

aduh95 commented Jan 7, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 477738
Commit: 25b7e2baa4df8ec8de18b2803eb0c42e332516a6


aarch64-darwin

✅ 1 package built:
  • temporal_capi

@aduh95
Copy link
Contributor Author

aduh95 commented Jan 7, 2026

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 7, 2026

@aduh95 wants to merge this PR.

Requirements to merge this PR with @NixOS/nixpkgs-merge-bot merge:

  • ✅ PR targets a development branch.
  • ✅ PR touches only files of packages in pkgs/by-name/.
  • ✅ PR is at least one of:
    • ⬜ Approved by a committer.
    • ⬜ Backported via label.
    • ✅ Opened by a committer.
    • ⬜ Opened by r-ryantm.
  • ✅ aduh95 is a member of @NixOS/nixpkgs-maintainers.
  • ✅ aduh95 is a maintainer of all touched packages.

✔️ Queued for merge (#306934)

@nixpkgs-ci nixpkgs-ci bot added this pull request to the merge queue Jan 7, 2026
Merged via the queue into NixOS:master with commit 67f6c11 Jan 7, 2026
32 checks passed
@aduh95 aduh95 deleted the temporal-capi branch January 7, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant