Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
ethancedwards8
suggested changes
Jan 4, 2026
nixpkgs-ci
bot
removed
the
9.needs: reviewer
aduh95
force-pushed
the
nbytes
branch
2 times, most recently
from
5d4a037 to
35aac05
Compare
13 tasks
aduh95
force-pushed
the
nbytes
branch
2 times, most recently
from
61f4df7 to
05b3393
Compare
Contributor
Author
|
13 tasks
FliegendeWurst
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
https://github.com/nodejs/nbytes
Nice to have for #401454. I took inspiration from
pkgs/by-name/pr/protonmail-bridge-gui/use-nix-googletest.patchfor googletest handling – given that that version has not moved since the repo creation (https://github.com/nodejs/nbytes/commits/main/CMakeLists.txt), I don't expect the patch to be high maintenance.passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.