Skip to content

shaderc: move to by-name, unvendor glslang, 2025.3 -> 2025.5#477464

Merged
philiptaron merged 4 commits intoNixOS:stagingfrom
marcin-serwin:push-zswmwyyqzvpo
Jan 8, 2026
Merged

shaderc: move to by-name, unvendor glslang, 2025.3 -> 2025.5#477464
philiptaron merged 4 commits intoNixOS:stagingfrom
marcin-serwin:push-zswmwyyqzvpo

Conversation

@marcin-serwin
Copy link
Contributor

Depends on #477412

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

Signed-off-by: Marcin Serwin <marcin@serwin.dev>
Signed-off-by: Marcin Serwin <marcin@serwin.dev>
Signed-off-by: Marcin Serwin <marcin@serwin.dev>
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 6, 2026
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, doing a build (of Ghostty)

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 7, 2026
@philiptaron
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 477464 --package ghostty
Commit: 401c6239203fcf984b57e0b0002c90f297d39476


x86_64-linux

✅ 5 packages built:
  • ghostty
  • ghostty.man (ghostty.man.man, ghostty.man.shell_integration, ghostty.man.terminfo, ghostty.man.vim)
  • ghostty.shell_integration (ghostty.shell_integration.man, ghostty.shell_integration.shell_integration, ghostty.shell_integration.terminfo, ghostty.shell_integration.vim)
  • ghostty.terminfo (ghostty.terminfo.man, ghostty.terminfo.shell_integration, ghostty.terminfo.terminfo, ghostty.terminfo.vim)
  • ghostty.vim (ghostty.vim.man, ghostty.vim.shell_integration, ghostty.vim.terminfo, ghostty.vim.vim)

@philiptaron philiptaron added this pull request to the merge queue Jan 8, 2026
Merged via the queue into NixOS:staging with commit 02b487a Jan 8, 2026
34 of 36 checks passed
@K900
Copy link
Contributor

K900 commented Jan 15, 2026

This broke ffmpeg_full builds, specifically tests fail to link with

┃        > /nix/store/nki6kv8c7ljlcgvihm7xnwrqi8i49cvn-binutils-2.44/bin/ld: libavfilter/libavfilter.a(vulkan_shaderc.o): undefined reference to symbol 'shaderc_compile_options_initialize'
┃        > /nix/store/nki6kv8c7ljlcgvihm7xnwrqi8i49cvn-binutils-2.44/bin/ld: /nix/store/bf5s4smqcx5vhb6jvwdcd3502lfq2dql-shaderc-2025.5-lib/lib/libshaderc_shared.so.1: error adding symbols: DSO missing from command line

Or similar. I'm going to skip the tests for ffmpeg builds with shaderc for now, but we'll want a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments