Skip to content

glslang: modernize#477412

Merged
philiptaron merged 6 commits intoNixOS:stagingfrom
marcin-serwin:push-snvwurwnqmkq
Jan 7, 2026
Merged

glslang: modernize#477412
philiptaron merged 6 commits intoNixOS:stagingfrom
marcin-serwin:push-snvwurwnqmkq

Conversation

@marcin-serwin
Copy link
Contributor

Tested by building shader-slang.tests.hello

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

Signed-off-by: Marcin Serwin <marcin@serwin.dev>
Signed-off-by: Marcin Serwin <marcin@serwin.dev>
Signed-off-by: Marcin Serwin <marcin@serwin.dev>
@nixpkgs-ci nixpkgs-ci bot requested a review from Ralith January 6, 2026 11:29
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. labels Jan 6, 2026
Signed-off-by: Marcin Serwin <marcin@serwin.dev>
marcin-serwin added a commit to marcin-serwin/nixpkgs that referenced this pull request Jan 6, 2026
This was added with initial implemention of multiple outputs:
<NixOS#7701>.

Problems with the generated pkg-config modules should be addressed at
the package level through correct configuration. The current approach
hides problems that resurface later (e.g., incorrectly generated cmake
config files in <NixOS#477258>) and is
sometimes not enough requiring further patching (e.g., see the removed
`postFixup` in <NixOS#477412>).

Signed-off-by: Marcin Serwin <marcin@serwin.dev>
@philiptaron
Copy link
Contributor

I built Ghostty with this change to validate; runs great.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Jan 6, 2026
Signed-off-by: Marcin Serwin <marcin@serwin.dev>
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". label Jan 6, 2026
@philiptaron philiptaron added this pull request to the merge queue Jan 7, 2026
Merged via the queue into NixOS:staging with commit 0065511 Jan 7, 2026
27 of 30 checks passed
@marcin-serwin marcin-serwin deleted the push-snvwurwnqmkq branch February 3, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants