Merged
Conversation
Signed-off-by: Marcin Serwin <marcin@serwin.dev>
Signed-off-by: Marcin Serwin <marcin@serwin.dev>
Signed-off-by: Marcin Serwin <marcin@serwin.dev>
Signed-off-by: Marcin Serwin <marcin@serwin.dev>
13 tasks
marcin-serwin
added a commit
to marcin-serwin/nixpkgs
that referenced
this pull request
Jan 6, 2026
This was added with initial implemention of multiple outputs: <NixOS#7701>. Problems with the generated pkg-config modules should be addressed at the package level through correct configuration. The current approach hides problems that resurface later (e.g., incorrectly generated cmake config files in <NixOS#477258>) and is sometimes not enough requiring further patching (e.g., see the removed `postFixup` in <NixOS#477412>). Signed-off-by: Marcin Serwin <marcin@serwin.dev>
13 tasks
philiptaron
reviewed
Jan 6, 2026
philiptaron
approved these changes
Jan 6, 2026
Contributor
|
I built Ghostty with this change to validate; runs great. |
d9f448b to
fe01a9e
Compare
Signed-off-by: Marcin Serwin <marcin@serwin.dev>
fe01a9e to
77ea24c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested by building
shader-slang.tests.helloThings done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.