Skip to content

fetchFromGithub: use fetchgit when postCheckout is not an empty string#477213

Closed
marcin-serwin wants to merge 1 commit intoNixOS:masterfrom
marcin-serwin:push-knpulopyorsl
Closed

fetchFromGithub: use fetchgit when postCheckout is not an empty string#477213
marcin-serwin wants to merge 1 commit intoNixOS:masterfrom
marcin-serwin:push-knpulopyorsl

Conversation

@marcin-serwin
Copy link
Contributor

Following #465497 it's possible to specify postCheckout to perform actions after repo is fetched but before .git is deleted.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

Following NixOS#465497 it's possible
to specify `postCheckout` to perform actions after repo is fetched but
before `.git` is deleted.

Signed-off-by: Marcin Serwin <marcin@serwin.dev>
@nixpkgs-ci nixpkgs-ci bot requested a review from philiptaron January 5, 2026 17:06
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) labels Jan 5, 2026
@ShamrockLee
Copy link
Contributor

There exists a PR with a similar title and some tests:

@marcin-serwin
Copy link
Contributor Author

Sorry for that, I should've checked.

@ShamrockLee
Copy link
Contributor

Sorry for that, I should've checked.

Nevermind. Thank gou for reviewing and approval.

@marcin-serwin marcin-serwin deleted the push-knpulopyorsl branch January 9, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants