Skip to content

fetchFromGitHub: use fetchgit when postCheckout is not empty#473958

Merged
philiptaron merged 2 commits intoNixOS:masterfrom
ShamrockLee:fetchgithub-postCheckout
Jan 6, 2026
Merged

fetchFromGitHub: use fetchgit when postCheckout is not empty#473958
philiptaron merged 2 commits intoNixOS:masterfrom
ShamrockLee:fetchgithub-postCheckout

Conversation

@ShamrockLee
Copy link
Contributor

@ShamrockLee ShamrockLee commented Dec 24, 2025 •
edited
Loading

Description

This PR makes fetchFromGitHub choose fetchgit as its base fetcher if postCheckout is specified as a non-empty string.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) labels Dec 25, 2025
@ShamrockLee ShamrockLee marked this pull request as ready for review December 25, 2025 00:05
@ShamrockLee ShamrockLee marked this pull request as draft December 25, 2025 00:06
@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Dec 25, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 473958
Commit: 7cf93cdb9667e44b7fea2b3aa7c5cbf9f1205e50 (subsequent changes)
Merge: 6aef2868cd582bdbf78578947956f58681b32b84

Logs: https://github.com/ShamrockLee/nixpkgs-review-gha/actions/runs/20495860765

x86_64-linux

✅ 2 packages built:
  • tests.fetchFromGitHub.describe-tag
  • tests.fetchFromGitHub.simple-tag

aarch64-linux

✅ 2 packages built:
  • tests.fetchFromGitHub.describe-tag
  • tests.fetchFromGitHub.simple-tag

x86_64-darwin (sandbox = relaxed)

✅ 2 packages built:
  • tests.fetchFromGitHub.describe-tag
  • tests.fetchFromGitHub.simple-tag

aarch64-darwin (sandbox = relaxed)

✅ 2 packages built:
  • tests.fetchFromGitHub.describe-tag
  • tests.fetchFromGitHub.simple-tag

@ShamrockLee ShamrockLee marked this pull request as ready for review December 26, 2025 00:56
@nixpkgs-ci nixpkgs-ci bot requested a review from philiptaron December 26, 2025 01:13
@ShamrockLee ShamrockLee mentioned this pull request Jan 5, 2026
Closed
13 tasks
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Jan 5, 2026
@philiptaron philiptaron added this pull request to the merge queue Jan 6, 2026
Merged via the queue into NixOS:master with commit 5880aaf Jan 6, 2026
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philiptaron philiptaron philiptaron approved these changes

@marcin-serwin marcin-serwin marcin-serwin approved these changes

Assignees

No one assigned

Labels

6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShamrockLee @philiptaron @marcin-serwin