Skip to content

superscs: fix build with gcc 15#477003

Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom
Sigmanificient:gcc15/superscs
Jan 10, 2026
Merged

superscs: fix build with gcc 15#477003
wolfgangwalther merged 1 commit intoNixOS:masterfrom
Sigmanificient:gcc15/superscs

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Jan 5, 2026

While migrating my python packages to finalAttrs, I encountered this build failures, as i am indirectly dependent.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot requested a review from nim65s January 5, 2026 00:53
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Jan 5, 2026
Copy link
Contributor

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

I'll forward that to upstream, even if they do not seem super reactive

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 5, 2026
@Aleksanaa
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 477003 -p superscs
Commit: 7c7d6ac789e8ace559bc381368604f4871e33ba5 (subsequent changes)
Merge: 8a9799493332c599f4edd6e9a742d8a907d78381

Logs: https://github.com/Aleksanaa/nixpkgs-review-gha/actions/runs/20704720359


x86_64-linux

✅ 1 package built:
  • superscs

aarch64-linux

✅ 1 package built:
  • superscs

x86_64-darwin (sandbox = relaxed)

❌ 1 package failed to build:
  • superscs

Error logs: `x86_64-darwin`
superscs
src/unit_test_util.c:43:29: error: function cannot return function type 'bool' (aka 'int (int *)')
   43 | bool scs_assert_equals_float(const scs_float a, const scs_float b, const scs_float tol) {
      |                             ^
src/unit_test_util.c:47:29: error: function cannot return function type 'bool' (aka 'int (int *)')
   47 | bool scs_assert_equals_array(
      |                             ^
src/unit_test_util.c:55:33: error: function cannot return function type 'bool' (aka 'int (int *)')
   55 | bool scs_assert_equals_array_int(
      |                                 ^
src/unit_test_util.c:60:10: error: illegal initializer (only variables can be initialized)
   60 |     bool all_equal = 1;
      |          ^
src/unit_test_util.c:67:21: error: unknown type name 'unitTest_t'
   67 | bool scs_test(const unitTest_t ut, const char* name) {
      |                     ^
src/unit_test_util.c:67:14: error: function cannot return function type 'bool' (aka 'int (int *)')
   67 | bool scs_test(const unitTest_t ut, const char* name) {
      |              ^
16 errors generated.
make: *** [Makefile:59: out/obj/unit_test_util.o] Error 1

aarch64-darwin (sandbox = relaxed)

❌ 1 package failed to build:
  • superscs

Error logs: `aarch64-darwin`
superscs
src/unit_test_util.c:43:29: error: function cannot return function type 'bool' (aka 'int (int *)')
   43 | bool scs_assert_equals_float(const scs_float a, const scs_float b, const scs_float tol) {
      |                             ^
src/unit_test_util.c:47:29: error: function cannot return function type 'bool' (aka 'int (int *)')
   47 | bool scs_assert_equals_array(
      |                             ^
src/unit_test_util.c:55:33: error: function cannot return function type 'bool' (aka 'int (int *)')
   55 | bool scs_assert_equals_array_int(
      |                                 ^
src/unit_test_util.c:60:10: error: illegal initializer (only variables can be initialized)
   60 |     bool all_equal = 1;
      |          ^
src/unit_test_util.c:67:21: error: unknown type name 'unitTest_t'
   67 | bool scs_test(const unitTest_t ut, const char* name) {
      |                     ^
src/unit_test_util.c:67:14: error: function cannot return function type 'bool' (aka 'int (int *)')
   67 | bool scs_test(const unitTest_t ut, const char* name) {
      |              ^
16 errors generated.
make: *** [Makefile:59: out/obj/unit_test_util.o] Error 1

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Jan 5, 2026
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Jan 5, 2026
@Aleksanaa
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 477003 -p superscs
Commit: 8edaedac0de6a219980a0e598921b40a5012a436 (subsequent changes)
Merge: fc5f7413cf40d3618bc3d27c318d6ebfa7601a11

Logs: https://github.com/Aleksanaa/nixpkgs-review-gha/actions/runs/20718922258


x86_64-linux

✅ 1 package built:
  • superscs

aarch64-linux

✅ 1 package built:
  • superscs

x86_64-darwin (sandbox = relaxed)

✅ 1 package built:
  • superscs

aarch64-darwin (sandbox = relaxed)

✅ 1 package built:
  • superscs

@nim65s nim65s mentioned this pull request Jan 10, 2026
13 tasks
@wolfgangwalther wolfgangwalther added this pull request to the merge queue Jan 10, 2026
Merged via the queue into NixOS:master with commit 9639dc0 Jan 10, 2026
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants