treewide: move python packages I maintain to finalAttrs#476981
Merged
MattSturgeon merged 69 commits intoNixOS:masterfrom Jan 7, 2026
Merged
treewide: move python packages I maintain to finalAttrs#476981MattSturgeon merged 69 commits intoNixOS:masterfrom
MattSturgeon merged 69 commits intoNixOS:masterfrom
Conversation
3ee954f to
c15035b
Compare
13 tasks
c15035b to
04cd43e
Compare
123a082 to
4f79e46
Compare
Member
Author
|
@ambroisie mind taking a lot? |
Contributor
|
@Sigmanificient please see last fixup commit and squash it to the appropriate commit. I found it out in a local checkout with: git log -n 60 --format=format:'%s' | cut -d: -f1 | cut -d. -f2 | while read pattr; do
grep "^ $pattr,$" pkgs/development/python-modules/"$pattr"/default.nix
done |
Contributor
Can confirm PR causes no real changes to derivations, only to how they're expressed. Testing script does work on x86_64-linux. |
Contributor
|
MithicSpirit
approved these changes
Jan 5, 2026
ambroisie
approved these changes
Jan 5, 2026
doronbehar
requested changes
Jan 5, 2026
Contributor
doronbehar
left a comment
There was a problem hiding this comment.
I'm submitting a review "requesting for changes" just to make sure this won't get merged without the fixup commit I pushed being squashed to its appropriate commit.
6679e51 to
054cdd5
Compare
doronbehar
approved these changes
Jan 7, 2026
Contributor
|
Caused minor eval failure in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing:
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.