Skip to content

treewide: move python packages I maintain to finalAttrs#476981

Merged
MattSturgeon merged 69 commits intoNixOS:masterfrom
Sigmanificient:python/finalAttrs-migration-sigma
Jan 7, 2026
Merged

treewide: move python packages I maintain to finalAttrs#476981
MattSturgeon merged 69 commits intoNixOS:masterfrom
Sigmanificient:python/finalAttrs-migration-sigma

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Jan 4, 2026

Testing:

PYPKGS=$( \
  git log -n 70 --oneline \
  | grep -Po "python3Packages.([^:]+)" \
  | cut -d '.' -f 2 \
  | tr '\n' ' '     \
) \
  nix-build -E '
    { pypkgs }:
    (import ./. { }).python3.withPackages pypkgs
  ' --arg pypkgs "p: with p; [ $PYPKGS ]"

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient force-pushed the python/finalAttrs-migration-sigma branch 5 times, most recently from 3ee954f to c15035b Compare January 5, 2026 00:39
@Sigmanificient Sigmanificient force-pushed the python/finalAttrs-migration-sigma branch from c15035b to 04cd43e Compare January 5, 2026 01:01
@Sigmanificient Sigmanificient force-pushed the python/finalAttrs-migration-sigma branch 4 times, most recently from 123a082 to 4f79e46 Compare January 5, 2026 10:33
@Sigmanificient Sigmanificient marked this pull request as ready for review January 5, 2026 10:37
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 6.topic: python Python is a high-level, general-purpose programming language. labels Jan 5, 2026
@Sigmanificient Sigmanificient changed the title treewide: move python packages i maintain to finalAttrs treewide: move python packages I maintain to finalAttrs Jan 5, 2026
@Sigmanificient
Copy link
Member Author

@ambroisie mind taking a lot?

@doronbehar
Copy link
Contributor

@Sigmanificient please see last fixup commit and squash it to the appropriate commit. I found it out in a local checkout with:

git log -n 60 --format=format:'%s' | cut -d: -f1 | cut -d. -f2 | while read pattr; do
  grep "^  $pattr,$" pkgs/development/python-modules/"$pattr"/default.nix
done

@MithicSpirit
Copy link
Contributor

Nothing to be built.

Can confirm PR causes no real changes to derivations, only to how they're expressed. Testing script does work on x86_64-linux.

@MithicSpirit
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 476981
Commit: 68024d685a9c369d426b595b51524e69cd893431

Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm submitting a review "requesting for changes" just to make sure this won't get merged without the fixup commit I pushed being squashed to its appropriate commit.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Jan 5, 2026
@Sigmanificient Sigmanificient force-pushed the python/finalAttrs-migration-sigma branch from 6679e51 to 054cdd5 Compare January 7, 2026 01:21
@MattSturgeon MattSturgeon enabled auto-merge January 7, 2026 09:08
@MattSturgeon MattSturgeon added this pull request to the merge queue Jan 7, 2026
Merged via the queue into NixOS:master with commit db54ac3 Jan 7, 2026
27 checks passed
@trofi
Copy link
Contributor

trofi commented Jan 17, 2026

Caused minor eval failure in python3Packages.raylib-python-cffi.tests attribute on master. Proposed the fix as:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants