fish: Revert "disable checks on darwin"#476001
Closed
mdaniels5757 wants to merge 1 commit intomasterfrom
Closed
Conversation
mdaniels5757
force-pushed
the
revert-462589-push-onkskmsvxkmt
branch
from
1bcd321 to
b9afe66
Compare
Member
Author
nixpkgs-ci
bot
requested review from
SigmaSquadron,
adamcstephens,
cole-h,
lonerOrz,
r-vdp and
winterqt
nixpkgs-ci
bot
added
10.rebuild-darwin: 11-100
Contributor
|
I tried re-enabling these in #477300, but there are multiple failures. |
Member
|
(What failures, for posterity?) |
Contributor
Member
|
Maybe these are worth reporting upstream, as they shouldn’t be flaky? 🤔 |
Contributor
|
Possibly. I'm not going to diagnose the darwin test failures further myself though, in case someone else wants to take that on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #462589, it can be reverted "once #462090 is through the staging cycles". #462090 is now in master, so this PR reverts #462589.