fish: disable checks on darwin#462589
Merged
adamcstephens merged 1 commit intoNixOS:masterfrom Nov 17, 2025
Merged
Conversation
3 tasks
nixpkgs-ci
bot
requested review from
SigmaSquadron,
cole-h,
lonerOrz,
r-vdp and
winterqt
nixpkgs-ci
bot
added
10.rebuild-darwin: 11-100
Aleksanaa
approved these changes
Nov 17, 2025
landreussi
approved these changes
Nov 17, 2025
lonerOrz
approved these changes
Nov 17, 2025
nixpkgs-ci
bot
added
12.approvals: 3+
sheeeng
added a commit
to sheeeng/nix
that referenced
this pull request
Nov 18, 2025
NixOS/nixpkgs#462589 NixOS/nixpkgs#461406 Signed-off-by: Leonard Sheng Sheng Lee <leonard.sheng.sheng.lee@gmail.com>
cullenmcdermott
pushed a commit
to cullenmcdermott/nix-config
that referenced
this pull request
Nov 20, 2025
Investigated removing the nixpkgs pin now that fish 4.2.1 test failures are resolved (PR #462589 disabled checks on darwin as temporary fix while PR #462090's Python wrapper fixes go through staging). However, latest nixpkgs-unstable (Nov 20) has a new issue: pyarrow build failures on darwin due to multiple conflicting protobuf versions (30, 31, 33) in the dependency closure causing memory corruption. Issue: NixOS/nixpkgs#461396 Pending fixes: PRs #461569, #461572 (still in staging, not merged) Keeping the Nov 8 pin until the protobuf fixes land in nixpkgs-unstable. The fish issue won't affect builds since checks are disabled on darwin. Related: NixOS/nixpkgs#461406 (fish), NixOS/nixpkgs#462090, NixOS/nixpkgs#462589
cullenmcdermott
pushed a commit
to cullenmcdermott/nix-config
that referenced
this pull request
Nov 20, 2025
Investigated removing the nixpkgs pin now that fish 4.2.1 test failures are resolved (PR #462589 disabled checks on darwin as temporary fix while PR #462090's Python wrapper fixes go through staging). However, latest nixpkgs-unstable (Nov 20) has a new issue: pyarrow build failures on darwin due to multiple conflicting protobuf versions (30, 31, 33) in the dependency closure causing memory corruption. Issue: NixOS/nixpkgs#461396 Pending fixes: PRs #461569, #461572 (still in staging, not merged) Keeping the Nov 8 pin until the protobuf fixes land in nixpkgs-unstable. The fish issue won't affect builds since checks are disabled on darwin. Related: NixOS/nixpkgs#461406 (fish), NixOS/nixpkgs#462090, NixOS/nixpkgs#462589
dixslyf
added a commit
to dixslyf/dotfiles
that referenced
this pull request
Nov 23, 2025
sheeeng
added a commit
to sheeeng/nix
that referenced
this pull request
Dec 2, 2025
NixOS/nixpkgs#462589 NixOS/nixpkgs#461406 Signed-off-by: Leonard Sheng Sheng Lee <leonard.sheng.sheng.lee@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can re-enable once #462090 is through the staging cycles.
Closes #461406
Closes #461779
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.