Skip to content

duktape: fix for structuredAttrs#473906

Merged
fgaz merged 1 commit intoNixOS:masterfrom
SFrijters:duktape-structuredattrs
Dec 26, 2025
Merged

duktape: fix for structuredAttrs#473906
fgaz merged 1 commit intoNixOS:masterfrom
SFrijters:duktape-structuredattrs

Conversation

@SFrijters
Copy link
Member

Without this change the build succees, but packages that use the library can run into linking issues (e.g. qt6declarative).

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

Without this change the build succees, but packages that use the library
can run into linking issues (e.g. qt6declarative).
@nixpkgs-ci nixpkgs-ci bot requested a review from fgaz December 24, 2025 18:51
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 24, 2025
@DieracDelta
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 473906
Commit: c57a7ee43f9bd5e325df94a99ecb497595b1475d


x86_64-linux

✅ 1 package built:
  • nixpkgs-manual

@fgaz fgaz added this pull request to the merge queue Dec 26, 2025
Merged via the queue into NixOS:master with commit 0000417 Dec 26, 2025
31 of 33 checks passed
kfiz pushed a commit to kfiz/nixpkgs that referenced this pull request Dec 26, 2025
kfiz pushed a commit to kfiz/nixpkgs that referenced this pull request Dec 26, 2025
@SFrijters SFrijters deleted the duktape-structuredattrs branch January 23, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants