Skip to content

qt6.qtbase: prepare for structuredAttrs#472656

Merged
philiptaron merged 1 commit intoNixOS:stagingfrom
SFrijters:qt6-base-replacevars-structuredattrs
Jan 31, 2026
Merged

qt6.qtbase: prepare for structuredAttrs#472656
philiptaron merged 1 commit intoNixOS:stagingfrom
SFrijters:qt6-base-replacevars-structuredattrs

Conversation

@SFrijters
Copy link
Member

@SFrijters SFrijters commented Dec 20, 2025 •
edited
Loading

#237216

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@SFrijters SFrijters marked this pull request as draft December 20, 2025 10:00
@SFrijters SFrijters mentioned this pull request Dec 20, 2025
Open
4 tasks
@SFrijters SFrijters force-pushed the qt6-base-replacevars-structuredattrs branch from 048db42 to 2174d8d Compare December 20, 2025 10:07
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Dec 20, 2025
@SFrijters SFrijters force-pushed the qt6-base-replacevars-structuredattrs branch from 2174d8d to 3875954 Compare December 23, 2025 00:00
@SFrijters
Copy link
Member Author

SFrijters commented Dec 24, 2025

Also requires #473906 .

@SFrijters SFrijters marked this pull request as ready for review December 24, 2025 23:27
@SFrijters SFrijters force-pushed the qt6-base-replacevars-structuredattrs branch from 3875954 to e69dd2e Compare December 24, 2025 23:29
@SFrijters SFrijters force-pushed the qt6-base-replacevars-structuredattrs branch from e69dd2e to ceec85b Compare December 24, 2025 23:33
@SFrijters SFrijters changed the title qt6.qtbase: use replaceVars for setup hook qt6.qtbase: prepare for structuredAttrs Dec 24, 2025
@SFrijters SFrijters requested a review from philiptaron January 30, 2026 11:26
philiptaron
philiptaron approved these changes Jan 30, 2026
View reviewed changes
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, doing a build

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 30, 2026
@K900
Copy link
Contributor

K900 commented Jan 30, 2026

Diff LGTM, how the hell did this ever work actually.

@philiptaron philiptaron added this pull request to the merge queue Jan 31, 2026
Merged via the queue into NixOS:staging with commit 38945fd Jan 31, 2026
33 checks passed
@SFrijters SFrijters deleted the qt6-base-replacevars-structuredattrs branch February 1, 2026 20:24
@Stebalien Stebalien mentioned this pull request Feb 25, 2026
Open
3 tasks
@SFrijters SFrijters mentioned this pull request Feb 25, 2026
Merged
13 tasks
Stebalien added a commit to Stebalien/nixpkgs that referenced this pull request Feb 28, 2026
@Stebalien
calibre: fix build until NixOS#472656 lands on master
e18fec7 
This applies a workaround suggested by @wrvsrv. Unfortunately, the
correct fix (NixOS#472656) requires a mass rebuild so it'll take a while to
pass through staging.

fixes NixOS#493843
wrvsrx pushed a commit to wrvsrx/nixpkgs that referenced this pull request Feb 28, 2026
@Stebalien @wrvsrx
calibre: fix build until NixOS#472656 lands on master
4335016 
This applies a workaround suggested by @wrvsrv. Unfortunately, the
correct fix (NixOS#472656) requires a mass rebuild so it'll take a while to
pass through staging.

fixes NixOS#493843
Stebalien added a commit to Stebalien/nixpkgs that referenced this pull request Mar 1, 2026
@Stebalien
calibre: fix build until NixOS#472656 lands on master
d598ab6 
This applies a workaround suggested by @wrvsrv. Unfortunately, the
correct fix (NixOS#472656) requires a mass rebuild so it'll take a while to
pass through staging.

fixes NixOS#493843
wrvsrx pushed a commit to wrvsrx/nixpkgs that referenced this pull request Mar 1, 2026
@Stebalien @wrvsrx
calibre: fix build until NixOS#472656 lands on master
4066562 
This applies a workaround suggested by @wrvsrv. Unfortunately, the
correct fix (NixOS#472656) requires a mass rebuild so it'll take a while to
pass through staging.

fixes NixOS#493843
Stebalien added a commit to Stebalien/nixpkgs that referenced this pull request Mar 2, 2026
@Stebalien
calibre: fix build until NixOS#472656 lands on master
0431d32 
This applies a workaround suggested by @wrvsrv. Unfortunately, the
correct fix (NixOS#472656) requires a mass rebuild so it'll take a while to
pass through staging.

fixes NixOS#493843
Stebalien added a commit to Stebalien/nixpkgs that referenced this pull request Mar 2, 2026
@Stebalien
calibre: fix build until NixOS#472656 lands on master
e9241b6 
This applies a workaround suggested by @wrvsrv. Unfortunately, the
correct fix (NixOS#472656) requires a mass rebuild so it'll take a while to
pass through staging.

fixes NixOS#493843
wrvsrx pushed a commit to wrvsrx/nixpkgs that referenced this pull request Mar 2, 2026
@Stebalien @wrvsrx
calibre: fix build until NixOS#472656 lands on master
dcd96f6 
This applies a workaround suggested by @wrvsrv. Unfortunately, the
correct fix (NixOS#472656) requires a mass rebuild so it'll take a while to
pass through staging.

fixes NixOS#493843
Stebalien added a commit to Stebalien/nixpkgs that referenced this pull request Mar 2, 2026
@Stebalien
calibre: fix build until NixOS#472656 lands on master
f50833e 
This applies a workaround suggested by @wrvsrv. Unfortunately, the
correct fix (NixOS#472656) requires a mass rebuild so it'll take a while to
pass through staging.

fixes NixOS#493843
wrvsrx pushed a commit to wrvsrx/nixpkgs that referenced this pull request Mar 3, 2026
@Stebalien @wrvsrx
calibre: fix build until NixOS#472656 lands on master
c048ca8 
This applies a workaround suggested by @wrvsrv. Unfortunately, the
correct fix (NixOS#472656) requires a mass rebuild so it'll take a while to
pass through staging.

fixes NixOS#493843
@SFrijters SFrijters mentioned this pull request Mar 3, 2026
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philiptaron philiptaron philiptaron approved these changes

@K900 K900 Awaiting requested review from K900

@LunNova LunNova Awaiting requested review from LunNova

@NickCao NickCao Awaiting requested review from NickCao

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees

No one assigned

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SFrijters @K900 @philiptaron