nix-prefetch-git: fix tag fetching and restore .git hash compatibility for postCheckout PR#473411
Conversation
|
|
Confirmed this change fixes things in my tests, although I've not verified anything using a tag as a ref. |
postVhechout PR
postVhechout PRpostChechout PR
|
Thanks, restores previous behavior for my derivations without having to manually set fetchTags. |
|
2440b6c to
9b00e7e
Compare
|
I squashed the last two commits into one. |
|
|
Could someone with MacOS hardware help verify
Pinging @purcell @nyanloutre @tie (maintainers) and @veprbl (people I know with a working MacOS setup). |
When leaveDotGit == true, restore the cloning behaviour before commit 7e08567 ("nix-prefetch-git: dont't fetch tags when deep clone unless leaving .git") to preserve the fragile hashes of .git sources. Clean up fetchTagsCompat, as fetchTagsCompat is no longer needed after restoring the old tag-fetching flags.
9b00e7e to
0903096
Compare
postChechout PRpostCheckout PR
|
|
Description
Fixes #473332
Restores hash compatibility for PR #465497, fixing #465497 (comment)
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.