Skip to content

nix-prefetch-git: fix tag fetching and restore .git hash compatibility for postCheckout PR#473411

Merged
ShamrockLee merged 2 commits intoNixOS:masterfrom
ShamrockLee:fetchgit-ref-tag-fix
Dec 26, 2025
Merged

nix-prefetch-git: fix tag fetching and restore .git hash compatibility for postCheckout PR#473411
ShamrockLee merged 2 commits intoNixOS:masterfrom
ShamrockLee:fetchgit-ref-tag-fix

Conversation

@ShamrockLee
Copy link
Contributor

@ShamrockLee ShamrockLee commented Dec 22, 2025

Description

Fixes #473332

Restores hash compatibility for PR #465497, fixing #465497 (comment)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) labels Dec 22, 2025
@ShamrockLee
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 473411
Commit: 62b2dbef6884a88ed3e53ef827f2996c55410479 (subsequent changes)
Merge: 36c4e935a7d713d3d6c1a689757c0e024cad5cc7

Logs: https://github.com/ShamrockLee/nixpkgs-review-gha/actions/runs/20448327378


x86_64-linux

✅ 92 packages built:
  • bundix
  • cabal2nix
  • chirpstack-concentratord
  • corto
  • crate2nix
  • crush
  • crystal2nix
  • dub-to-nix
  • gcalcli
  • gcalcli.dist
  • git-unroll
  • haskellPackages.cli-nix
  • haskellPackages.cli-nix.doc
  • haskellPackages.nix-thunk
  • haskellPackages.nix-thunk.doc
  • haskellPackages.nvfetcher
  • haskellPackages.nvfetcher.doc
  • haskellPackages.update-nix-fetchgit
  • haskellPackages.update-nix-fetchgit.doc
  • kcl
  • lixPackageSets.git.nix-update
  • lixPackageSets.git.nix-update.dist
  • lixPackageSets.latest.nix-update (lixPackageSets.lix_2_94.nix-update)
  • lixPackageSets.latest.nix-update.dist (lixPackageSets.lix_2_94.nix-update.dist)
  • lixPackageSets.stable.nix-update (lixPackageSets.lix_2_93.nix-update)
  • lixPackageSets.stable.nix-update.dist (lixPackageSets.lix_2_93.nix-update.dist)
  • localtunnel
  • lon
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • mdwatch
  • meshlab
  • mlv-app
  • nim_lk
  • nix-prefetch-git
  • nix-prefetch-scripts
  • nix-update
  • nix-update-source
  • nix-update-source.dist
  • nix-update.dist
  • npins
  • nvfetcher
  • outline
  • prefetch-yarn-deps
  • prowlarr
  • python312Packages.pymeshlab
  • python313Packages.nixpkgs-updaters-library
  • python313Packages.nixpkgs-updaters-library.dist
  • python313Packages.pymeshlab
  • radarr
  • sonarr
  • sus-compiler
  • tests.fetchFromBitbucket.withEncodedWhitespaceGit
  • tests.fetchFromGitHub.fetchTags
  • tests.fetchFromGitHub.leave-git
  • tests.fetchFromGitHub.rootDir
  • tests.fetchFromGitHub.sparseCheckout
  • tests.fetchFromGitHub.sparseCheckoutNonConeMode
  • tests.fetchFromGitHub.submodule-deep
  • tests.fetchFromGitHub.submodule-leave-git
  • tests.fetchFromGitHub.submodule-leave-git-deep
  • tests.fetchFromGitHub.submodule-simple
  • tests.fetchgit.cached-prefetch-avoids-fetch
  • tests.fetchgit.collect-rev
  • tests.fetchgit.describe-tag
  • tests.fetchgit.dumb-http-signed-tag
  • tests.fetchgit.fetchTags
  • tests.fetchgit.leave-git
  • tests.fetchgit.prefetch-git-no-add-path
  • tests.fetchgit.rootDir
  • tests.fetchgit.simple
  • tests.fetchgit.simple-tag
  • tests.fetchgit.sparseCheckout
  • tests.fetchgit.sparseCheckoutNonConeMode
  • tests.fetchgit.submodule-deep
  • tests.fetchgit.submodule-leave-git
  • tests.fetchgit.submodule-leave-git-deep
  • tests.fetchgit.submodule-revision-count
  • tests.fetchgit.submodule-simple
  • tests.fetchgit.withGitConfig
  • tests.fetchurl.header
  • tests.haskell.cabalSdist.assumptionLocalHasDirectReference
  • tests.haskell.cabalSdist.localHasNoDirectReference
  • tests.testers.runCommand.bork
  • typescript-language-server
  • update-nix-fetchgit
  • update-python-libraries
  • vclab-nexus
  • vclab-nexus.bin
  • vimPluginsUpdater
  • xosd-xft
  • yarn2nix

aarch64-linux

✅ 89 packages built:
  • bundix
  • cabal2nix
  • chirpstack-concentratord
  • corto
  • crate2nix
  • crush
  • crystal2nix
  • dub-to-nix
  • gcalcli
  • gcalcli.dist
  • git-unroll
  • haskellPackages.cli-nix
  • haskellPackages.cli-nix.doc
  • haskellPackages.nix-thunk
  • haskellPackages.nix-thunk.doc
  • haskellPackages.nvfetcher
  • haskellPackages.nvfetcher.doc
  • haskellPackages.update-nix-fetchgit
  • haskellPackages.update-nix-fetchgit.doc
  • kcl
  • lixPackageSets.git.nix-update
  • lixPackageSets.git.nix-update.dist
  • lixPackageSets.latest.nix-update (lixPackageSets.lix_2_94.nix-update)
  • lixPackageSets.latest.nix-update.dist (lixPackageSets.lix_2_94.nix-update.dist)
  • lixPackageSets.stable.nix-update (lixPackageSets.lix_2_93.nix-update)
  • lixPackageSets.stable.nix-update.dist (lixPackageSets.lix_2_93.nix-update.dist)
  • localtunnel
  • lon
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • mdwatch
  • meshlab
  • nim_lk
  • nix-prefetch-git
  • nix-prefetch-scripts
  • nix-update
  • nix-update-source
  • nix-update-source.dist
  • nix-update.dist
  • npins
  • nvfetcher
  • outline
  • prefetch-yarn-deps
  • prowlarr
  • python312Packages.pymeshlab
  • python313Packages.nixpkgs-updaters-library
  • python313Packages.nixpkgs-updaters-library.dist
  • python313Packages.pymeshlab
  • radarr
  • sonarr
  • sus-compiler
  • tests.fetchFromBitbucket.withEncodedWhitespaceGit
  • tests.fetchFromGitHub.fetchTags
  • tests.fetchFromGitHub.leave-git
  • tests.fetchFromGitHub.rootDir
  • tests.fetchFromGitHub.sparseCheckout
  • tests.fetchFromGitHub.sparseCheckoutNonConeMode
  • tests.fetchFromGitHub.submodule-deep
  • tests.fetchFromGitHub.submodule-leave-git
  • tests.fetchFromGitHub.submodule-leave-git-deep
  • tests.fetchFromGitHub.submodule-simple
  • tests.fetchgit.cached-prefetch-avoids-fetch
  • tests.fetchgit.collect-rev
  • tests.fetchgit.describe-tag
  • tests.fetchgit.dumb-http-signed-tag
  • tests.fetchgit.fetchTags
  • tests.fetchgit.leave-git
  • tests.fetchgit.prefetch-git-no-add-path
  • tests.fetchgit.rootDir
  • tests.fetchgit.simple
  • tests.fetchgit.simple-tag
  • tests.fetchgit.sparseCheckout
  • tests.fetchgit.sparseCheckoutNonConeMode
  • tests.fetchgit.submodule-deep
  • tests.fetchgit.submodule-leave-git
  • tests.fetchgit.submodule-leave-git-deep
  • tests.fetchgit.submodule-revision-count
  • tests.fetchgit.submodule-simple
  • tests.fetchgit.withGitConfig
  • tests.fetchurl.header
  • tests.testers.runCommand.bork
  • typescript-language-server
  • update-nix-fetchgit
  • update-python-libraries
  • vclab-nexus
  • vclab-nexus.bin
  • vimPluginsUpdater
  • xosd-xft
  • yarn2nix

x86_64-darwin (sandbox = relaxed)

❌ 3 packages failed to build:
  • radarr
  • sonarr
  • tests.testers.runCommand.bork
✅ 83 packages built:
  • bundix
  • cabal2nix
  • corto
  • crate2nix
  • crush
  • crystal2nix
  • dub-to-nix
  • gcalcli
  • gcalcli.dist
  • git-unroll
  • haskellPackages.cli-nix
  • haskellPackages.cli-nix.doc
  • haskellPackages.nix-thunk
  • haskellPackages.nix-thunk.doc
  • haskellPackages.nvfetcher
  • haskellPackages.nvfetcher.doc
  • haskellPackages.update-nix-fetchgit
  • haskellPackages.update-nix-fetchgit.doc
  • kcl
  • lixPackageSets.git.nix-update
  • lixPackageSets.git.nix-update.dist
  • lixPackageSets.latest.nix-update (lixPackageSets.lix_2_94.nix-update)
  • lixPackageSets.latest.nix-update.dist (lixPackageSets.lix_2_94.nix-update.dist)
  • lixPackageSets.stable.nix-update (lixPackageSets.lix_2_93.nix-update)
  • lixPackageSets.stable.nix-update.dist (lixPackageSets.lix_2_93.nix-update.dist)
  • localtunnel
  • lon
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • mdwatch
  • meshlab
  • nim_lk
  • nix-prefetch-git
  • nix-prefetch-scripts
  • nix-update
  • nix-update-source
  • nix-update-source.dist
  • nix-update.dist
  • npins
  • nvfetcher
  • prefetch-yarn-deps
  • prowlarr
  • python312Packages.pymeshlab
  • python313Packages.nixpkgs-updaters-library
  • python313Packages.nixpkgs-updaters-library.dist
  • python313Packages.pymeshlab
  • sus-compiler
  • tests.fetchFromBitbucket.withEncodedWhitespaceGit
  • tests.fetchFromGitHub.fetchTags
  • tests.fetchFromGitHub.leave-git
  • tests.fetchFromGitHub.rootDir
  • tests.fetchFromGitHub.sparseCheckout
  • tests.fetchFromGitHub.sparseCheckoutNonConeMode
  • tests.fetchFromGitHub.submodule-deep
  • tests.fetchFromGitHub.submodule-leave-git
  • tests.fetchFromGitHub.submodule-leave-git-deep
  • tests.fetchFromGitHub.submodule-simple
  • tests.fetchgit.cached-prefetch-avoids-fetch
  • tests.fetchgit.collect-rev
  • tests.fetchgit.describe-tag
  • tests.fetchgit.dumb-http-signed-tag
  • tests.fetchgit.fetchTags
  • tests.fetchgit.leave-git
  • tests.fetchgit.prefetch-git-no-add-path
  • tests.fetchgit.rootDir
  • tests.fetchgit.simple
  • tests.fetchgit.simple-tag
  • tests.fetchgit.sparseCheckout
  • tests.fetchgit.sparseCheckoutNonConeMode
  • tests.fetchgit.submodule-deep
  • tests.fetchgit.submodule-leave-git
  • tests.fetchgit.submodule-leave-git-deep
  • tests.fetchgit.submodule-revision-count
  • tests.fetchgit.submodule-simple
  • tests.fetchgit.withGitConfig
  • tests.fetchurl.header
  • typescript-language-server
  • update-nix-fetchgit
  • update-python-libraries
  • vclab-nexus
  • vclab-nexus.bin
  • vimPluginsUpdater
  • yarn2nix

Error logs: `x86_64-darwin`
radarr
        modules by path ./frontend/src/Styles/Variables/*.js 1.52 KiB 2 modules
      + 5 modules
    + 7 modules
  css modules 230 KiB 420 modules
webpack 5.95.0 compiled successfully in 176631 ms
✨  Done in 187.34s.
Finished dotnetBuildHook
buildPhase completed in 8 minutes 40 seconds
Running phase: checkPhase
@nix { "action": "setPhase", "phase": "checkPhase" }
Executing dotnetCheckHook
�=�=Test run for /nix/build/nix-19185-598443314/source-patched/_tests/net8.0/osx-x64/Radarr.Api.Test.dll (.NETCoreApp,Version=v8.0)
�=VSTest version 17.11.1 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
vstest.console process failed to connect to testhost process after 90 seconds. This may occur due to machine slowness, please set environment variable VSTEST_CONNECTION_TIMEOUT to increase timeout.
�=
Test Run Aborted.
�=

sonarr
    util (ignored) 15 bytes [built] [code generated]
    util (ignored) 15 bytes [optional] [built] [code generated]
    ./util.inspect (ignored) 15 bytes [built] [code generated]
  css modules 212 KiB 400 modules
webpack 5.95.0 compiled successfully in 629396 ms
✨  Done in 654.41s.
Finished dotnetBuildHook
buildPhase completed in 20 minutes 56 seconds
Running phase: checkPhase
@nix { "action": "setPhase", "phase": "checkPhase" }
Executing dotnetCheckHook
�=�=Test run for /nix/build/nix-19185-598443319/source-patched/_tests/net8.0/osx-x64/Sonarr.Api.Test.dll (.NETCoreApp,Version=v8.0)
�=VSTest version 17.11.1 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
vstest.console process failed to connect to testhost process after 90 seconds. This may occur due to machine slowness, please set environment variable VSTEST_CONNECTION_TIMEOUT to increase timeout.
�=
Test Run Aborted.
�=

tests.testers.runCommand.bork
                    exc.stdout, exc.stderr = process.communicate()
                else:
                    # POSIX _communicate already populated the output so
                    # far into the TimeoutExpired exception.
                    process.wait()
                raise
            except:  # Including KeyboardInterrupt, communicate handled that.
                process.kill()
                # We don't call process.wait() as .__exit__ does that for us.
                raise
            retcode = process.poll()
            if check and retcode:
>               raise CalledProcessError(retcode, process.args,
                                         output=stdout, stderr=stderr)
E               subprocess.CalledProcessError: Command '['/nix/store/84s01mzl74vh69aphpl3rf07pp49pkz0-python3-3.13.9/bin/python3.13', '-m', 'bork', 'download', 'gh:duckinator/emanate', 'v7.0.0']' returned non-zero exit status 1.

/nix/store/84s01mzl74vh69aphpl3rf07pp49pkz0-python3-3.13.9/lib/python3.13/subprocess.py:577: CalledProcessError
=========================== short test summary info ============================
FAILED bork/tests/test_cmd_download.py::test_download - subprocess.CalledProcessError: Command '['/nix/store/84s01mzl74vh69aphpl3rf...
============ 1 failed, 3 passed, 5 deselected in 170.91s (0:02:50) =============


aarch64-darwin (sandbox = relaxed)

❌ 3 packages failed to build:
  • radarr
  • sonarr
  • tests.testers.runCommand.bork
✅ 83 packages built:
  • bundix
  • cabal2nix
  • corto
  • crate2nix
  • crush
  • crystal2nix
  • dub-to-nix
  • gcalcli
  • gcalcli.dist
  • git-unroll
  • haskellPackages.cli-nix
  • haskellPackages.cli-nix.doc
  • haskellPackages.nix-thunk
  • haskellPackages.nix-thunk.doc
  • haskellPackages.nvfetcher
  • haskellPackages.nvfetcher.doc
  • haskellPackages.update-nix-fetchgit
  • haskellPackages.update-nix-fetchgit.doc
  • kcl
  • lixPackageSets.git.nix-update
  • lixPackageSets.git.nix-update.dist
  • lixPackageSets.latest.nix-update (lixPackageSets.lix_2_94.nix-update)
  • lixPackageSets.latest.nix-update.dist (lixPackageSets.lix_2_94.nix-update.dist)
  • lixPackageSets.stable.nix-update (lixPackageSets.lix_2_93.nix-update)
  • lixPackageSets.stable.nix-update.dist (lixPackageSets.lix_2_93.nix-update.dist)
  • localtunnel
  • lon
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • mdwatch
  • meshlab
  • nim_lk
  • nix-prefetch-git
  • nix-prefetch-scripts
  • nix-update
  • nix-update-source
  • nix-update-source.dist
  • nix-update.dist
  • npins
  • nvfetcher
  • prefetch-yarn-deps
  • prowlarr
  • python312Packages.pymeshlab
  • python313Packages.nixpkgs-updaters-library
  • python313Packages.nixpkgs-updaters-library.dist
  • python313Packages.pymeshlab
  • sus-compiler
  • tests.fetchFromBitbucket.withEncodedWhitespaceGit
  • tests.fetchFromGitHub.fetchTags
  • tests.fetchFromGitHub.leave-git
  • tests.fetchFromGitHub.rootDir
  • tests.fetchFromGitHub.sparseCheckout
  • tests.fetchFromGitHub.sparseCheckoutNonConeMode
  • tests.fetchFromGitHub.submodule-deep
  • tests.fetchFromGitHub.submodule-leave-git
  • tests.fetchFromGitHub.submodule-leave-git-deep
  • tests.fetchFromGitHub.submodule-simple
  • tests.fetchgit.cached-prefetch-avoids-fetch
  • tests.fetchgit.collect-rev
  • tests.fetchgit.describe-tag
  • tests.fetchgit.dumb-http-signed-tag
  • tests.fetchgit.fetchTags
  • tests.fetchgit.leave-git
  • tests.fetchgit.prefetch-git-no-add-path
  • tests.fetchgit.rootDir
  • tests.fetchgit.simple
  • tests.fetchgit.simple-tag
  • tests.fetchgit.sparseCheckout
  • tests.fetchgit.sparseCheckoutNonConeMode
  • tests.fetchgit.submodule-deep
  • tests.fetchgit.submodule-leave-git
  • tests.fetchgit.submodule-leave-git-deep
  • tests.fetchgit.submodule-revision-count
  • tests.fetchgit.submodule-simple
  • tests.fetchgit.withGitConfig
  • tests.fetchurl.header
  • typescript-language-server
  • update-nix-fetchgit
  • update-python-libraries
  • vclab-nexus
  • vclab-nexus.bin
  • vimPluginsUpdater
  • yarn2nix

Error logs: `aarch64-darwin`
radarr
        modules by path ./frontend/src/Styles/Variables/*.js 1.52 KiB 2 modules
      + 5 modules
    + 7 modules
  css modules 230 KiB 420 modules
webpack 5.95.0 compiled successfully in 162242 ms
✨  Done in 169.85s.
Finished dotnetBuildHook
buildPhase completed in 6 minutes 24 seconds
Running phase: checkPhase
@nix { "action": "setPhase", "phase": "checkPhase" }
Executing dotnetCheckHook
�=�=Test run for /nix/build/nix-11754-2609593854/source-patched/_tests/net8.0/osx-arm64/Radarr.Api.Test.dll (.NETCoreApp,Version=v8.0)
�=VSTest version 17.11.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
vstest.console process failed to connect to testhost process after 90 seconds. This may occur due to machine slowness, please set environment variable VSTEST_CONNECTION_TIMEOUT to increase timeout.
�=
Test Run Aborted.
�=

sonarr
    util (ignored) 15 bytes [built] [code generated]
    util (ignored) 15 bytes [optional] [built] [code generated]
    ./util.inspect (ignored) 15 bytes [built] [code generated]
  css modules 212 KiB 400 modules
webpack 5.95.0 compiled successfully in 162758 ms
✨  Done in 171.12s.
Finished dotnetBuildHook
buildPhase completed in 5 minutes 33 seconds
Running phase: checkPhase
@nix { "action": "setPhase", "phase": "checkPhase" }
Executing dotnetCheckHook
�=�=Test run for /nix/build/nix-11754-2609593855/source-patched/_tests/net8.0/osx-arm64/Sonarr.Api.Test.dll (.NETCoreApp,Version=v8.0)
�=VSTest version 17.11.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
vstest.console process failed to connect to testhost process after 90 seconds. This may occur due to machine slowness, please set environment variable VSTEST_CONNECTION_TIMEOUT to increase timeout.
�=
Test Run Aborted.
�=

tests.testers.runCommand.bork
                    exc.stdout, exc.stderr = process.communicate()
                else:
                    # POSIX _communicate already populated the output so
                    # far into the TimeoutExpired exception.
                    process.wait()
                raise
            except:  # Including KeyboardInterrupt, communicate handled that.
                process.kill()
                # We don't call process.wait() as .__exit__ does that for us.
                raise
            retcode = process.poll()
            if check and retcode:
>               raise CalledProcessError(retcode, process.args,
                                         output=stdout, stderr=stderr)
E               subprocess.CalledProcessError: Command '['/nix/store/xcjk9ill54kjk8mzgq6yydnx9015lidg-python3-3.13.9/bin/python3.13', '-m', 'bork', 'download', 'gh:duckinator/emanate', 'v7.0.0']' returned non-zero exit status 1.

/nix/store/xcjk9ill54kjk8mzgq6yydnx9015lidg-python3-3.13.9/lib/python3.13/subprocess.py:577: CalledProcessError
=========================== short test summary info ============================
FAILED bork/tests/test_cmd_download.py::test_download - subprocess.CalledProcessError: Command '['/nix/store/xcjk9ill54kjk8mzgq6yyd...
============= 1 failed, 3 passed, 5 deselected in 66.93s (0:01:06) =============

@me-and
Copy link
Member

me-and commented Dec 23, 2025

Confirmed this change fixes things in my tests, although I've not verified anything using a tag as a ref.

@ShamrockLee ShamrockLee marked this pull request as ready for review December 23, 2025 14:50
@nixpkgs-ci nixpkgs-ci bot requested a review from philiptaron December 23, 2025 14:55
@ShamrockLee ShamrockLee changed the title nix-prefetch-git: Name FETCHED_HEAD "$ref" only for refs/tags/* nix-prefetch-git: fix tag fetching and restore .git hash compatibility for postVhechout PR Dec 24, 2025
@ShamrockLee ShamrockLee changed the title nix-prefetch-git: fix tag fetching and restore .git hash compatibility for postVhechout PR nix-prefetch-git: fix tag fetching and restore .git hash compatibility for postChechout PR Dec 24, 2025
@qubitnano
Copy link
Contributor

Thanks, restores previous behavior for my derivations without having to manually set fetchTags.

@ShamrockLee
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 473411
Commit: d87c7638ebefcc808d36d104cd57abd153cb2c65 (subsequent changes)
Merge: 9e7921ce23b1e4d02867b62e2be6f23ed2fa7607

Logs: https://github.com/ShamrockLee/nixpkgs-review-gha/actions/runs/20474959510


x86_64-linux

✅ 92 packages built:
  • bundix
  • cabal2nix
  • chirpstack-concentratord
  • corto
  • crate2nix
  • crush
  • crystal2nix
  • dub-to-nix
  • gcalcli
  • gcalcli.dist
  • git-unroll
  • haskellPackages.cli-nix
  • haskellPackages.cli-nix.doc
  • haskellPackages.nix-thunk
  • haskellPackages.nix-thunk.doc
  • haskellPackages.nvfetcher
  • haskellPackages.nvfetcher.doc
  • haskellPackages.update-nix-fetchgit
  • haskellPackages.update-nix-fetchgit.doc
  • kcl
  • lixPackageSets.git.nix-update
  • lixPackageSets.git.nix-update.dist
  • lixPackageSets.latest.nix-update (lixPackageSets.lix_2_94.nix-update)
  • lixPackageSets.latest.nix-update.dist (lixPackageSets.lix_2_94.nix-update.dist)
  • lixPackageSets.stable.nix-update (lixPackageSets.lix_2_93.nix-update)
  • lixPackageSets.stable.nix-update.dist (lixPackageSets.lix_2_93.nix-update.dist)
  • localtunnel
  • lon
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • mdwatch
  • meshlab
  • mlv-app
  • nim_lk
  • nix-prefetch-git
  • nix-prefetch-scripts
  • nix-update
  • nix-update-source
  • nix-update-source.dist
  • nix-update.dist
  • npins
  • nvfetcher
  • outline
  • prefetch-yarn-deps
  • prowlarr
  • python312Packages.pymeshlab
  • python313Packages.nixpkgs-updaters-library
  • python313Packages.nixpkgs-updaters-library.dist
  • python313Packages.pymeshlab
  • radarr
  • sonarr
  • sus-compiler
  • tests.fetchFromBitbucket.withEncodedWhitespaceGit
  • tests.fetchFromGitHub.fetchTags
  • tests.fetchFromGitHub.leave-git
  • tests.fetchFromGitHub.rootDir
  • tests.fetchFromGitHub.sparseCheckout
  • tests.fetchFromGitHub.sparseCheckoutNonConeMode
  • tests.fetchFromGitHub.submodule-deep
  • tests.fetchFromGitHub.submodule-leave-git
  • tests.fetchFromGitHub.submodule-leave-git-deep
  • tests.fetchFromGitHub.submodule-simple
  • tests.fetchgit.cached-prefetch-avoids-fetch
  • tests.fetchgit.collect-rev
  • tests.fetchgit.describe-tag
  • tests.fetchgit.dumb-http-signed-tag
  • tests.fetchgit.fetchTags
  • tests.fetchgit.leave-git
  • tests.fetchgit.prefetch-git-no-add-path
  • tests.fetchgit.rootDir
  • tests.fetchgit.simple
  • tests.fetchgit.simple-tag
  • tests.fetchgit.sparseCheckout
  • tests.fetchgit.sparseCheckoutNonConeMode
  • tests.fetchgit.submodule-deep
  • tests.fetchgit.submodule-leave-git
  • tests.fetchgit.submodule-leave-git-deep
  • tests.fetchgit.submodule-revision-count
  • tests.fetchgit.submodule-simple
  • tests.fetchgit.withGitConfig
  • tests.fetchurl.header
  • tests.haskell.cabalSdist.assumptionLocalHasDirectReference
  • tests.haskell.cabalSdist.localHasNoDirectReference
  • tests.testers.runCommand.bork
  • typescript-language-server
  • update-nix-fetchgit
  • update-python-libraries
  • vclab-nexus
  • vclab-nexus.bin
  • vimPluginsUpdater
  • xosd-xft
  • yarn2nix

aarch64-linux

✅ 89 packages built:
  • bundix
  • cabal2nix
  • chirpstack-concentratord
  • corto
  • crate2nix
  • crush
  • crystal2nix
  • dub-to-nix
  • gcalcli
  • gcalcli.dist
  • git-unroll
  • haskellPackages.cli-nix
  • haskellPackages.cli-nix.doc
  • haskellPackages.nix-thunk
  • haskellPackages.nix-thunk.doc
  • haskellPackages.nvfetcher
  • haskellPackages.nvfetcher.doc
  • haskellPackages.update-nix-fetchgit
  • haskellPackages.update-nix-fetchgit.doc
  • kcl
  • lixPackageSets.git.nix-update
  • lixPackageSets.git.nix-update.dist
  • lixPackageSets.latest.nix-update (lixPackageSets.lix_2_94.nix-update)
  • lixPackageSets.latest.nix-update.dist (lixPackageSets.lix_2_94.nix-update.dist)
  • lixPackageSets.stable.nix-update (lixPackageSets.lix_2_93.nix-update)
  • lixPackageSets.stable.nix-update.dist (lixPackageSets.lix_2_93.nix-update.dist)
  • localtunnel
  • lon
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • mdwatch
  • meshlab
  • nim_lk
  • nix-prefetch-git
  • nix-prefetch-scripts
  • nix-update
  • nix-update-source
  • nix-update-source.dist
  • nix-update.dist
  • npins
  • nvfetcher
  • outline
  • prefetch-yarn-deps
  • prowlarr
  • python312Packages.pymeshlab
  • python313Packages.nixpkgs-updaters-library
  • python313Packages.nixpkgs-updaters-library.dist
  • python313Packages.pymeshlab
  • radarr
  • sonarr
  • sus-compiler
  • tests.fetchFromBitbucket.withEncodedWhitespaceGit
  • tests.fetchFromGitHub.fetchTags
  • tests.fetchFromGitHub.leave-git
  • tests.fetchFromGitHub.rootDir
  • tests.fetchFromGitHub.sparseCheckout
  • tests.fetchFromGitHub.sparseCheckoutNonConeMode
  • tests.fetchFromGitHub.submodule-deep
  • tests.fetchFromGitHub.submodule-leave-git
  • tests.fetchFromGitHub.submodule-leave-git-deep
  • tests.fetchFromGitHub.submodule-simple
  • tests.fetchgit.cached-prefetch-avoids-fetch
  • tests.fetchgit.collect-rev
  • tests.fetchgit.describe-tag
  • tests.fetchgit.dumb-http-signed-tag
  • tests.fetchgit.fetchTags
  • tests.fetchgit.leave-git
  • tests.fetchgit.prefetch-git-no-add-path
  • tests.fetchgit.rootDir
  • tests.fetchgit.simple
  • tests.fetchgit.simple-tag
  • tests.fetchgit.sparseCheckout
  • tests.fetchgit.sparseCheckoutNonConeMode
  • tests.fetchgit.submodule-deep
  • tests.fetchgit.submodule-leave-git
  • tests.fetchgit.submodule-leave-git-deep
  • tests.fetchgit.submodule-revision-count
  • tests.fetchgit.submodule-simple
  • tests.fetchgit.withGitConfig
  • tests.fetchurl.header
  • tests.testers.runCommand.bork
  • typescript-language-server
  • update-nix-fetchgit
  • update-python-libraries
  • vclab-nexus
  • vclab-nexus.bin
  • vimPluginsUpdater
  • xosd-xft
  • yarn2nix

x86_64-darwin (sandbox = relaxed)

❌ 3 packages failed to build:
  • radarr
  • sonarr
  • tests.testers.runCommand.bork
✅ 83 packages built:
  • bundix
  • cabal2nix
  • corto
  • crate2nix
  • crush
  • crystal2nix
  • dub-to-nix
  • gcalcli
  • gcalcli.dist
  • git-unroll
  • haskellPackages.cli-nix
  • haskellPackages.cli-nix.doc
  • haskellPackages.nix-thunk
  • haskellPackages.nix-thunk.doc
  • haskellPackages.nvfetcher
  • haskellPackages.nvfetcher.doc
  • haskellPackages.update-nix-fetchgit
  • haskellPackages.update-nix-fetchgit.doc
  • kcl
  • lixPackageSets.git.nix-update
  • lixPackageSets.git.nix-update.dist
  • lixPackageSets.latest.nix-update (lixPackageSets.lix_2_94.nix-update)
  • lixPackageSets.latest.nix-update.dist (lixPackageSets.lix_2_94.nix-update.dist)
  • lixPackageSets.stable.nix-update (lixPackageSets.lix_2_93.nix-update)
  • lixPackageSets.stable.nix-update.dist (lixPackageSets.lix_2_93.nix-update.dist)
  • localtunnel
  • lon
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • mdwatch
  • meshlab
  • nim_lk
  • nix-prefetch-git
  • nix-prefetch-scripts
  • nix-update
  • nix-update-source
  • nix-update-source.dist
  • nix-update.dist
  • npins
  • nvfetcher
  • prefetch-yarn-deps
  • prowlarr
  • python312Packages.pymeshlab
  • python313Packages.nixpkgs-updaters-library
  • python313Packages.nixpkgs-updaters-library.dist
  • python313Packages.pymeshlab
  • sus-compiler
  • tests.fetchFromBitbucket.withEncodedWhitespaceGit
  • tests.fetchFromGitHub.fetchTags
  • tests.fetchFromGitHub.leave-git
  • tests.fetchFromGitHub.rootDir
  • tests.fetchFromGitHub.sparseCheckout
  • tests.fetchFromGitHub.sparseCheckoutNonConeMode
  • tests.fetchFromGitHub.submodule-deep
  • tests.fetchFromGitHub.submodule-leave-git
  • tests.fetchFromGitHub.submodule-leave-git-deep
  • tests.fetchFromGitHub.submodule-simple
  • tests.fetchgit.cached-prefetch-avoids-fetch
  • tests.fetchgit.collect-rev
  • tests.fetchgit.describe-tag
  • tests.fetchgit.dumb-http-signed-tag
  • tests.fetchgit.fetchTags
  • tests.fetchgit.leave-git
  • tests.fetchgit.prefetch-git-no-add-path
  • tests.fetchgit.rootDir
  • tests.fetchgit.simple
  • tests.fetchgit.simple-tag
  • tests.fetchgit.sparseCheckout
  • tests.fetchgit.sparseCheckoutNonConeMode
  • tests.fetchgit.submodule-deep
  • tests.fetchgit.submodule-leave-git
  • tests.fetchgit.submodule-leave-git-deep
  • tests.fetchgit.submodule-revision-count
  • tests.fetchgit.submodule-simple
  • tests.fetchgit.withGitConfig
  • tests.fetchurl.header
  • typescript-language-server
  • update-nix-fetchgit
  • update-python-libraries
  • vclab-nexus
  • vclab-nexus.bin
  • vimPluginsUpdater
  • yarn2nix

Error logs: `x86_64-darwin`
radarr
        modules by path ./frontend/src/Styles/Variables/*.js 1.52 KiB 2 modules
      + 5 modules
    + 7 modules
  css modules 230 KiB 420 modules
webpack 5.95.0 compiled successfully in 224024 ms
✨  Done in 233.44s.
Finished dotnetBuildHook
buildPhase completed in 11 minutes 20 seconds
Running phase: checkPhase
@nix { "action": "setPhase", "phase": "checkPhase" }
Executing dotnetCheckHook
�=�=Test run for /nix/build/nix-32473-2822629894/source-patched/_tests/net8.0/osx-x64/Radarr.Api.Test.dll (.NETCoreApp,Version=v8.0)
�=VSTest version 17.11.1 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
vstest.console process failed to connect to testhost process after 90 seconds. This may occur due to machine slowness, please set environment variable VSTEST_CONNECTION_TIMEOUT to increase timeout.
�=
Test Run Aborted.
�=

sonarr
    util (ignored) 15 bytes [built] [code generated]
    util (ignored) 15 bytes [optional] [built] [code generated]
    ./util.inspect (ignored) 15 bytes [built] [code generated]
  css modules 212 KiB 400 modules
webpack 5.95.0 compiled successfully in 419033 ms
✨  Done in 432.95s.
Finished dotnetBuildHook
buildPhase completed in 14 minutes 6 seconds
Running phase: checkPhase
@nix { "action": "setPhase", "phase": "checkPhase" }
Executing dotnetCheckHook
�=�=Test run for /nix/build/nix-32473-2822629897/source-patched/_tests/net8.0/osx-x64/Sonarr.Api.Test.dll (.NETCoreApp,Version=v8.0)
�=VSTest version 17.11.1 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
vstest.console process failed to connect to testhost process after 90 seconds. This may occur due to machine slowness, please set environment variable VSTEST_CONNECTION_TIMEOUT to increase timeout.
�=
Test Run Aborted.
�=

tests.testers.runCommand.bork
                    exc.stdout, exc.stderr = process.communicate()
                else:
                    # POSIX _communicate already populated the output so
                    # far into the TimeoutExpired exception.
                    process.wait()
                raise
            except:  # Including KeyboardInterrupt, communicate handled that.
                process.kill()
                # We don't call process.wait() as .__exit__ does that for us.
                raise
            retcode = process.poll()
            if check and retcode:
>               raise CalledProcessError(retcode, process.args,
                                         output=stdout, stderr=stderr)
E               subprocess.CalledProcessError: Command '['/nix/store/84s01mzl74vh69aphpl3rf07pp49pkz0-python3-3.13.9/bin/python3.13', '-m', 'bork', 'download', 'gh:duckinator/emanate', 'v7.0.0']' returned non-zero exit status 1.

/nix/store/84s01mzl74vh69aphpl3rf07pp49pkz0-python3-3.13.9/lib/python3.13/subprocess.py:577: CalledProcessError
=========================== short test summary info ============================
FAILED bork/tests/test_cmd_download.py::test_download - subprocess.CalledProcessError: Command '['/nix/store/84s01mzl74vh69aphpl3rf...
============ 1 failed, 3 passed, 5 deselected in 101.03s (0:01:41) =============


aarch64-darwin (sandbox = relaxed)

❌ 3 packages failed to build:
  • radarr
  • sonarr
  • tests.testers.runCommand.bork
✅ 83 packages built:
  • bundix
  • cabal2nix
  • corto
  • crate2nix
  • crush
  • crystal2nix
  • dub-to-nix
  • gcalcli
  • gcalcli.dist
  • git-unroll
  • haskellPackages.cli-nix
  • haskellPackages.cli-nix.doc
  • haskellPackages.nix-thunk
  • haskellPackages.nix-thunk.doc
  • haskellPackages.nvfetcher
  • haskellPackages.nvfetcher.doc
  • haskellPackages.update-nix-fetchgit
  • haskellPackages.update-nix-fetchgit.doc
  • kcl
  • lixPackageSets.git.nix-update
  • lixPackageSets.git.nix-update.dist
  • lixPackageSets.latest.nix-update (lixPackageSets.lix_2_94.nix-update)
  • lixPackageSets.latest.nix-update.dist (lixPackageSets.lix_2_94.nix-update.dist)
  • lixPackageSets.stable.nix-update (lixPackageSets.lix_2_93.nix-update)
  • lixPackageSets.stable.nix-update.dist (lixPackageSets.lix_2_93.nix-update.dist)
  • localtunnel
  • lon
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • mdwatch
  • meshlab
  • nim_lk
  • nix-prefetch-git
  • nix-prefetch-scripts
  • nix-update
  • nix-update-source
  • nix-update-source.dist
  • nix-update.dist
  • npins
  • nvfetcher
  • prefetch-yarn-deps
  • prowlarr
  • python312Packages.pymeshlab
  • python313Packages.nixpkgs-updaters-library
  • python313Packages.nixpkgs-updaters-library.dist
  • python313Packages.pymeshlab
  • sus-compiler
  • tests.fetchFromBitbucket.withEncodedWhitespaceGit
  • tests.fetchFromGitHub.fetchTags
  • tests.fetchFromGitHub.leave-git
  • tests.fetchFromGitHub.rootDir
  • tests.fetchFromGitHub.sparseCheckout
  • tests.fetchFromGitHub.sparseCheckoutNonConeMode
  • tests.fetchFromGitHub.submodule-deep
  • tests.fetchFromGitHub.submodule-leave-git
  • tests.fetchFromGitHub.submodule-leave-git-deep
  • tests.fetchFromGitHub.submodule-simple
  • tests.fetchgit.cached-prefetch-avoids-fetch
  • tests.fetchgit.collect-rev
  • tests.fetchgit.describe-tag
  • tests.fetchgit.dumb-http-signed-tag
  • tests.fetchgit.fetchTags
  • tests.fetchgit.leave-git
  • tests.fetchgit.prefetch-git-no-add-path
  • tests.fetchgit.rootDir
  • tests.fetchgit.simple
  • tests.fetchgit.simple-tag
  • tests.fetchgit.sparseCheckout
  • tests.fetchgit.sparseCheckoutNonConeMode
  • tests.fetchgit.submodule-deep
  • tests.fetchgit.submodule-leave-git
  • tests.fetchgit.submodule-leave-git-deep
  • tests.fetchgit.submodule-revision-count
  • tests.fetchgit.submodule-simple
  • tests.fetchgit.withGitConfig
  • tests.fetchurl.header
  • typescript-language-server
  • update-nix-fetchgit
  • update-python-libraries
  • vclab-nexus
  • vclab-nexus.bin
  • vimPluginsUpdater
  • yarn2nix

Error logs: `aarch64-darwin`
radarr
        modules by path ./frontend/src/Styles/Variables/*.js 1.52 KiB 2 modules
      + 5 modules
    + 7 modules
  css modules 230 KiB 420 modules
webpack 5.95.0 compiled successfully in 171398 ms
✨  Done in 178.02s.
Finished dotnetBuildHook
buildPhase completed in 5 minutes 10 seconds
Running phase: checkPhase
@nix { "action": "setPhase", "phase": "checkPhase" }
Executing dotnetCheckHook
�=�=Test run for /nix/build/nix-5041-732687960/source-patched/_tests/net8.0/osx-arm64/Radarr.Api.Test.dll (.NETCoreApp,Version=v8.0)
�=VSTest version 17.11.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
vstest.console process failed to connect to testhost process after 90 seconds. This may occur due to machine slowness, please set environment variable VSTEST_CONNECTION_TIMEOUT to increase timeout.
�=
Test Run Aborted.
�=

sonarr
    util (ignored) 15 bytes [built] [code generated]
    util (ignored) 15 bytes [optional] [built] [code generated]
    ./util.inspect (ignored) 15 bytes [built] [code generated]
  css modules 212 KiB 400 modules
webpack 5.95.0 compiled successfully in 122220 ms
✨  Done in 128.81s.
Finished dotnetBuildHook
buildPhase completed in 4 minutes 43 seconds
Running phase: checkPhase
@nix { "action": "setPhase", "phase": "checkPhase" }
Executing dotnetCheckHook
�=�=Test run for /nix/build/nix-5041-732687962/source-patched/_tests/net8.0/osx-arm64/Sonarr.Api.Test.dll (.NETCoreApp,Version=v8.0)
�=VSTest version 17.11.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
vstest.console process failed to connect to testhost process after 90 seconds. This may occur due to machine slowness, please set environment variable VSTEST_CONNECTION_TIMEOUT to increase timeout.
�=
Test Run Aborted.
�=

tests.testers.runCommand.bork
                    exc.stdout, exc.stderr = process.communicate()
                else:
                    # POSIX _communicate already populated the output so
                    # far into the TimeoutExpired exception.
                    process.wait()
                raise
            except:  # Including KeyboardInterrupt, communicate handled that.
                process.kill()
                # We don't call process.wait() as .__exit__ does that for us.
                raise
            retcode = process.poll()
            if check and retcode:
>               raise CalledProcessError(retcode, process.args,
                                         output=stdout, stderr=stderr)
E               subprocess.CalledProcessError: Command '['/nix/store/xcjk9ill54kjk8mzgq6yydnx9015lidg-python3-3.13.9/bin/python3.13', '-m', 'bork', 'download', 'gh:duckinator/emanate', 'v7.0.0']' returned non-zero exit status 1.

/nix/store/xcjk9ill54kjk8mzgq6yydnx9015lidg-python3-3.13.9/lib/python3.13/subprocess.py:577: CalledProcessError
=========================== short test summary info ============================
FAILED bork/tests/test_cmd_download.py::test_download - subprocess.CalledProcessError: Command '['/nix/store/xcjk9ill54kjk8mzgq6yyd...
================== 1 failed, 3 passed, 5 deselected in 50.05s ==================

@ShamrockLee
Copy link
Contributor Author

I squashed the last two commits into one.

@ShamrockLee
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 473411
Commit: 9b00e7e1cfd9b4f80548345d44bde9d20b46aaf2 (subsequent changes)
Merge: 7b616916e9f6d62dfc0af7ad4efda1e4b61ac515

Logs: https://github.com/ShamrockLee/nixpkgs-review-gha/actions/runs/20484514062


x86_64-linux

✅ 92 packages built:
  • bundix
  • cabal2nix
  • chirpstack-concentratord
  • corto
  • crate2nix
  • crush
  • crystal2nix
  • dub-to-nix
  • gcalcli
  • gcalcli.dist
  • git-unroll
  • haskellPackages.cli-nix
  • haskellPackages.cli-nix.doc
  • haskellPackages.nix-thunk
  • haskellPackages.nix-thunk.doc
  • haskellPackages.nvfetcher
  • haskellPackages.nvfetcher.doc
  • haskellPackages.update-nix-fetchgit
  • haskellPackages.update-nix-fetchgit.doc
  • kcl
  • lixPackageSets.git.nix-update
  • lixPackageSets.git.nix-update.dist
  • lixPackageSets.latest.nix-update (lixPackageSets.lix_2_94.nix-update)
  • lixPackageSets.latest.nix-update.dist (lixPackageSets.lix_2_94.nix-update.dist)
  • lixPackageSets.stable.nix-update (lixPackageSets.lix_2_93.nix-update)
  • lixPackageSets.stable.nix-update.dist (lixPackageSets.lix_2_93.nix-update.dist)
  • localtunnel
  • lon
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • mdwatch
  • meshlab
  • mlv-app
  • nim_lk
  • nix-prefetch-git
  • nix-prefetch-scripts
  • nix-update
  • nix-update-source
  • nix-update-source.dist
  • nix-update.dist
  • npins
  • nvfetcher
  • outline
  • prefetch-yarn-deps
  • prowlarr
  • python312Packages.pymeshlab
  • python313Packages.nixpkgs-updaters-library
  • python313Packages.nixpkgs-updaters-library.dist
  • python313Packages.pymeshlab
  • radarr
  • sonarr
  • sus-compiler
  • tests.fetchFromBitbucket.withEncodedWhitespaceGit
  • tests.fetchFromGitHub.fetchTags
  • tests.fetchFromGitHub.leave-git
  • tests.fetchFromGitHub.rootDir
  • tests.fetchFromGitHub.sparseCheckout
  • tests.fetchFromGitHub.sparseCheckoutNonConeMode
  • tests.fetchFromGitHub.submodule-deep
  • tests.fetchFromGitHub.submodule-leave-git
  • tests.fetchFromGitHub.submodule-leave-git-deep
  • tests.fetchFromGitHub.submodule-simple
  • tests.fetchgit.cached-prefetch-avoids-fetch
  • tests.fetchgit.collect-rev
  • tests.fetchgit.describe-tag
  • tests.fetchgit.dumb-http-signed-tag
  • tests.fetchgit.fetchTags
  • tests.fetchgit.leave-git
  • tests.fetchgit.prefetch-git-no-add-path
  • tests.fetchgit.rootDir
  • tests.fetchgit.simple
  • tests.fetchgit.simple-tag
  • tests.fetchgit.sparseCheckout
  • tests.fetchgit.sparseCheckoutNonConeMode
  • tests.fetchgit.submodule-deep
  • tests.fetchgit.submodule-leave-git
  • tests.fetchgit.submodule-leave-git-deep
  • tests.fetchgit.submodule-revision-count
  • tests.fetchgit.submodule-simple
  • tests.fetchgit.withGitConfig
  • tests.fetchurl.header
  • tests.haskell.cabalSdist.assumptionLocalHasDirectReference
  • tests.haskell.cabalSdist.localHasNoDirectReference
  • tests.testers.runCommand.bork
  • typescript-language-server
  • update-nix-fetchgit
  • update-python-libraries
  • vclab-nexus
  • vclab-nexus.bin
  • vimPluginsUpdater
  • xosd-xft
  • yarn2nix

aarch64-linux

✅ 89 packages built:
  • bundix
  • cabal2nix
  • chirpstack-concentratord
  • corto
  • crate2nix
  • crush
  • crystal2nix
  • dub-to-nix
  • gcalcli
  • gcalcli.dist
  • git-unroll
  • haskellPackages.cli-nix
  • haskellPackages.cli-nix.doc
  • haskellPackages.nix-thunk
  • haskellPackages.nix-thunk.doc
  • haskellPackages.nvfetcher
  • haskellPackages.nvfetcher.doc
  • haskellPackages.update-nix-fetchgit
  • haskellPackages.update-nix-fetchgit.doc
  • kcl
  • lixPackageSets.git.nix-update
  • lixPackageSets.git.nix-update.dist
  • lixPackageSets.latest.nix-update (lixPackageSets.lix_2_94.nix-update)
  • lixPackageSets.latest.nix-update.dist (lixPackageSets.lix_2_94.nix-update.dist)
  • lixPackageSets.stable.nix-update (lixPackageSets.lix_2_93.nix-update)
  • lixPackageSets.stable.nix-update.dist (lixPackageSets.lix_2_93.nix-update.dist)
  • localtunnel
  • lon
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • mdwatch
  • meshlab
  • nim_lk
  • nix-prefetch-git
  • nix-prefetch-scripts
  • nix-update
  • nix-update-source
  • nix-update-source.dist
  • nix-update.dist
  • npins
  • nvfetcher
  • outline
  • prefetch-yarn-deps
  • prowlarr
  • python312Packages.pymeshlab
  • python313Packages.nixpkgs-updaters-library
  • python313Packages.nixpkgs-updaters-library.dist
  • python313Packages.pymeshlab
  • radarr
  • sonarr
  • sus-compiler
  • tests.fetchFromBitbucket.withEncodedWhitespaceGit
  • tests.fetchFromGitHub.fetchTags
  • tests.fetchFromGitHub.leave-git
  • tests.fetchFromGitHub.rootDir
  • tests.fetchFromGitHub.sparseCheckout
  • tests.fetchFromGitHub.sparseCheckoutNonConeMode
  • tests.fetchFromGitHub.submodule-deep
  • tests.fetchFromGitHub.submodule-leave-git
  • tests.fetchFromGitHub.submodule-leave-git-deep
  • tests.fetchFromGitHub.submodule-simple
  • tests.fetchgit.cached-prefetch-avoids-fetch
  • tests.fetchgit.collect-rev
  • tests.fetchgit.describe-tag
  • tests.fetchgit.dumb-http-signed-tag
  • tests.fetchgit.fetchTags
  • tests.fetchgit.leave-git
  • tests.fetchgit.prefetch-git-no-add-path
  • tests.fetchgit.rootDir
  • tests.fetchgit.simple
  • tests.fetchgit.simple-tag
  • tests.fetchgit.sparseCheckout
  • tests.fetchgit.sparseCheckoutNonConeMode
  • tests.fetchgit.submodule-deep
  • tests.fetchgit.submodule-leave-git
  • tests.fetchgit.submodule-leave-git-deep
  • tests.fetchgit.submodule-revision-count
  • tests.fetchgit.submodule-simple
  • tests.fetchgit.withGitConfig
  • tests.fetchurl.header
  • tests.testers.runCommand.bork
  • typescript-language-server
  • update-nix-fetchgit
  • update-python-libraries
  • vclab-nexus
  • vclab-nexus.bin
  • vimPluginsUpdater
  • xosd-xft
  • yarn2nix

x86_64-darwin (sandbox = relaxed)

❌ 3 packages failed to build:
  • radarr
  • sonarr
  • tests.testers.runCommand.bork
✅ 83 packages built:
  • bundix
  • cabal2nix
  • corto
  • crate2nix
  • crush
  • crystal2nix
  • dub-to-nix
  • gcalcli
  • gcalcli.dist
  • git-unroll
  • haskellPackages.cli-nix
  • haskellPackages.cli-nix.doc
  • haskellPackages.nix-thunk
  • haskellPackages.nix-thunk.doc
  • haskellPackages.nvfetcher
  • haskellPackages.nvfetcher.doc
  • haskellPackages.update-nix-fetchgit
  • haskellPackages.update-nix-fetchgit.doc
  • kcl
  • lixPackageSets.git.nix-update
  • lixPackageSets.git.nix-update.dist
  • lixPackageSets.latest.nix-update (lixPackageSets.lix_2_94.nix-update)
  • lixPackageSets.latest.nix-update.dist (lixPackageSets.lix_2_94.nix-update.dist)
  • lixPackageSets.stable.nix-update (lixPackageSets.lix_2_93.nix-update)
  • lixPackageSets.stable.nix-update.dist (lixPackageSets.lix_2_93.nix-update.dist)
  • localtunnel
  • lon
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • mdwatch
  • meshlab
  • nim_lk
  • nix-prefetch-git
  • nix-prefetch-scripts
  • nix-update
  • nix-update-source
  • nix-update-source.dist
  • nix-update.dist
  • npins
  • nvfetcher
  • prefetch-yarn-deps
  • prowlarr
  • python312Packages.pymeshlab
  • python313Packages.nixpkgs-updaters-library
  • python313Packages.nixpkgs-updaters-library.dist
  • python313Packages.pymeshlab
  • sus-compiler
  • tests.fetchFromBitbucket.withEncodedWhitespaceGit
  • tests.fetchFromGitHub.fetchTags
  • tests.fetchFromGitHub.leave-git
  • tests.fetchFromGitHub.rootDir
  • tests.fetchFromGitHub.sparseCheckout
  • tests.fetchFromGitHub.sparseCheckoutNonConeMode
  • tests.fetchFromGitHub.submodule-deep
  • tests.fetchFromGitHub.submodule-leave-git
  • tests.fetchFromGitHub.submodule-leave-git-deep
  • tests.fetchFromGitHub.submodule-simple
  • tests.fetchgit.cached-prefetch-avoids-fetch
  • tests.fetchgit.collect-rev
  • tests.fetchgit.describe-tag
  • tests.fetchgit.dumb-http-signed-tag
  • tests.fetchgit.fetchTags
  • tests.fetchgit.leave-git
  • tests.fetchgit.prefetch-git-no-add-path
  • tests.fetchgit.rootDir
  • tests.fetchgit.simple
  • tests.fetchgit.simple-tag
  • tests.fetchgit.sparseCheckout
  • tests.fetchgit.sparseCheckoutNonConeMode
  • tests.fetchgit.submodule-deep
  • tests.fetchgit.submodule-leave-git
  • tests.fetchgit.submodule-leave-git-deep
  • tests.fetchgit.submodule-revision-count
  • tests.fetchgit.submodule-simple
  • tests.fetchgit.withGitConfig
  • tests.fetchurl.header
  • typescript-language-server
  • update-nix-fetchgit
  • update-python-libraries
  • vclab-nexus
  • vclab-nexus.bin
  • vimPluginsUpdater
  • yarn2nix

Error logs: `x86_64-darwin`
radarr
        modules by path ./frontend/src/Styles/Variables/*.js 1.52 KiB 2 modules
      + 5 modules
    + 7 modules
  css modules 230 KiB 420 modules
webpack 5.95.0 compiled successfully in 142844 ms
✨  Done in 152.78s.
Finished dotnetBuildHook
buildPhase completed in 7 minutes 19 seconds
Running phase: checkPhase
@nix { "action": "setPhase", "phase": "checkPhase" }
Executing dotnetCheckHook
�=�=Test run for /nix/build/nix-24615-1159690634/source-patched/_tests/net8.0/osx-x64/Radarr.Api.Test.dll (.NETCoreApp,Version=v8.0)
�=VSTest version 17.11.1 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
vstest.console process failed to connect to testhost process after 90 seconds. This may occur due to machine slowness, please set environment variable VSTEST_CONNECTION_TIMEOUT to increase timeout.
�=
Test Run Aborted.
�=

sonarr
    util (ignored) 15 bytes [built] [code generated]
    util (ignored) 15 bytes [optional] [built] [code generated]
    ./util.inspect (ignored) 15 bytes [built] [code generated]
  css modules 212 KiB 400 modules
webpack 5.95.0 compiled successfully in 154249 ms
✨  Done in 165.83s.
Finished dotnetBuildHook
buildPhase completed in 8 minutes 0 seconds
Running phase: checkPhase
@nix { "action": "setPhase", "phase": "checkPhase" }
Executing dotnetCheckHook
�=�=Test run for /nix/build/nix-24615-1159690635/source-patched/_tests/net8.0/osx-x64/Sonarr.Api.Test.dll (.NETCoreApp,Version=v8.0)
�=VSTest version 17.11.1 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
vstest.console process failed to connect to testhost process after 90 seconds. This may occur due to machine slowness, please set environment variable VSTEST_CONNECTION_TIMEOUT to increase timeout.
�=
Test Run Aborted.
�=

tests.testers.runCommand.bork
                    exc.stdout, exc.stderr = process.communicate()
                else:
                    # POSIX _communicate already populated the output so
                    # far into the TimeoutExpired exception.
                    process.wait()
                raise
            except:  # Including KeyboardInterrupt, communicate handled that.
                process.kill()
                # We don't call process.wait() as .__exit__ does that for us.
                raise
            retcode = process.poll()
            if check and retcode:
>               raise CalledProcessError(retcode, process.args,
                                         output=stdout, stderr=stderr)
E               subprocess.CalledProcessError: Command '['/nix/store/84s01mzl74vh69aphpl3rf07pp49pkz0-python3-3.13.9/bin/python3.13', '-m', 'bork', 'download', 'gh:duckinator/emanate', 'v7.0.0']' returned non-zero exit status 1.

/nix/store/84s01mzl74vh69aphpl3rf07pp49pkz0-python3-3.13.9/lib/python3.13/subprocess.py:577: CalledProcessError
=========================== short test summary info ============================
FAILED bork/tests/test_cmd_download.py::test_download - subprocess.CalledProcessError: Command '['/nix/store/84s01mzl74vh69aphpl3rf...
============= 1 failed, 3 passed, 5 deselected in 93.88s (0:01:33) =============


aarch64-darwin (sandbox = relaxed)

❌ 2 packages failed to build:
  • radarr
  • sonarr
✅ 84 packages built:
  • bundix
  • cabal2nix
  • corto
  • crate2nix
  • crush
  • crystal2nix
  • dub-to-nix
  • gcalcli
  • gcalcli.dist
  • git-unroll
  • haskellPackages.cli-nix
  • haskellPackages.cli-nix.doc
  • haskellPackages.nix-thunk
  • haskellPackages.nix-thunk.doc
  • haskellPackages.nvfetcher
  • haskellPackages.nvfetcher.doc
  • haskellPackages.update-nix-fetchgit
  • haskellPackages.update-nix-fetchgit.doc
  • kcl
  • lixPackageSets.git.nix-update
  • lixPackageSets.git.nix-update.dist
  • lixPackageSets.latest.nix-update (lixPackageSets.lix_2_94.nix-update)
  • lixPackageSets.latest.nix-update.dist (lixPackageSets.lix_2_94.nix-update.dist)
  • lixPackageSets.stable.nix-update (lixPackageSets.lix_2_93.nix-update)
  • lixPackageSets.stable.nix-update.dist (lixPackageSets.lix_2_93.nix-update.dist)
  • localtunnel
  • lon
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • mdwatch
  • meshlab
  • nim_lk
  • nix-prefetch-git
  • nix-prefetch-scripts
  • nix-update
  • nix-update-source
  • nix-update-source.dist
  • nix-update.dist
  • npins
  • nvfetcher
  • prefetch-yarn-deps
  • prowlarr
  • python312Packages.pymeshlab
  • python313Packages.nixpkgs-updaters-library
  • python313Packages.nixpkgs-updaters-library.dist
  • python313Packages.pymeshlab
  • sus-compiler
  • tests.fetchFromBitbucket.withEncodedWhitespaceGit
  • tests.fetchFromGitHub.fetchTags
  • tests.fetchFromGitHub.leave-git
  • tests.fetchFromGitHub.rootDir
  • tests.fetchFromGitHub.sparseCheckout
  • tests.fetchFromGitHub.sparseCheckoutNonConeMode
  • tests.fetchFromGitHub.submodule-deep
  • tests.fetchFromGitHub.submodule-leave-git
  • tests.fetchFromGitHub.submodule-leave-git-deep
  • tests.fetchFromGitHub.submodule-simple
  • tests.fetchgit.cached-prefetch-avoids-fetch
  • tests.fetchgit.collect-rev
  • tests.fetchgit.describe-tag
  • tests.fetchgit.dumb-http-signed-tag
  • tests.fetchgit.fetchTags
  • tests.fetchgit.leave-git
  • tests.fetchgit.prefetch-git-no-add-path
  • tests.fetchgit.rootDir
  • tests.fetchgit.simple
  • tests.fetchgit.simple-tag
  • tests.fetchgit.sparseCheckout
  • tests.fetchgit.sparseCheckoutNonConeMode
  • tests.fetchgit.submodule-deep
  • tests.fetchgit.submodule-leave-git
  • tests.fetchgit.submodule-leave-git-deep
  • tests.fetchgit.submodule-revision-count
  • tests.fetchgit.submodule-simple
  • tests.fetchgit.withGitConfig
  • tests.fetchurl.header
  • tests.testers.runCommand.bork
  • typescript-language-server
  • update-nix-fetchgit
  • update-python-libraries
  • vclab-nexus
  • vclab-nexus.bin
  • vimPluginsUpdater
  • yarn2nix

Error logs: `aarch64-darwin`
radarr
        modules by path ./frontend/src/Styles/Variables/*.js 1.52 KiB 2 modules
      + 5 modules
    + 7 modules
  css modules 230 KiB 420 modules
webpack 5.95.0 compiled successfully in 174423 ms
✨  Done in 186.02s.
Finished dotnetBuildHook
buildPhase completed in 6 minutes 15 seconds
Running phase: checkPhase
@nix { "action": "setPhase", "phase": "checkPhase" }
Executing dotnetCheckHook
�=�=Test run for /nix/build/nix-7963-47948926/source-patched/_tests/net8.0/osx-arm64/Radarr.Api.Test.dll (.NETCoreApp,Version=v8.0)
�=VSTest version 17.11.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
vstest.console process failed to connect to testhost process after 90 seconds. This may occur due to machine slowness, please set environment variable VSTEST_CONNECTION_TIMEOUT to increase timeout.
�=
Test Run Aborted.
�=

sonarr
    util (ignored) 15 bytes [built] [code generated]
    util (ignored) 15 bytes [optional] [built] [code generated]
    ./util.inspect (ignored) 15 bytes [built] [code generated]
  css modules 212 KiB 400 modules
webpack 5.95.0 compiled successfully in 132001 ms
✨  Done in 137.82s.
Finished dotnetBuildHook
buildPhase completed in 4 minutes 32 seconds
Running phase: checkPhase
@nix { "action": "setPhase", "phase": "checkPhase" }
Executing dotnetCheckHook
�=�=Test run for /nix/build/nix-7963-47948927/source-patched/_tests/net8.0/osx-arm64/Sonarr.Api.Test.dll (.NETCoreApp,Version=v8.0)
�=VSTest version 17.11.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
vstest.console process failed to connect to testhost process after 90 seconds. This may occur due to machine slowness, please set environment variable VSTEST_CONNECTION_TIMEOUT to increase timeout.
�=
Test Run Aborted.
�=

@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Dec 24, 2025

radarr and sonarr fail to build on Darwin, complaining test timeout.

Could someone with MacOS hardware help verify

  • Whether these packages build with the --rebuild flag.
  • Whether they build locally on top of this PR.

Pinging @purcell @nyanloutre @tie (maintainers) and @veprbl (people I know with a working MacOS setup).

When leaveDotGit == true,
restore the cloning behaviour before
commit 7e08567 ("nix-prefetch-git: dont't fetch tags when deep clone unless leaving .git")
to preserve the fragile hashes of .git sources.

Clean up fetchTagsCompat,
as fetchTagsCompat is no longer needed
after restoring the old tag-fetching flags.
@philiptaron philiptaron changed the title nix-prefetch-git: fix tag fetching and restore .git hash compatibility for postChechout PR nix-prefetch-git: fix tag fetching and restore .git hash compatibility for postCheckout PR Dec 24, 2025
@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Dec 24, 2025

although I've not verified anything using a tag as a ref.

tests.fetchgit.describe-tag should guard it.

@philiptaron
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 473411
Commit: 09030960d56e73f712bf9926985cfa5a86109c01


x86_64-darwin

✅ 86 packages built:
  • bundix
  • cabal2nix
  • corto
  • crate2nix
  • crush
  • crystal2nix
  • dub-to-nix
  • gcalcli
  • gcalcli.dist
  • git-unroll
  • haskellPackages.cli-nix
  • haskellPackages.cli-nix.doc
  • haskellPackages.nix-thunk
  • haskellPackages.nix-thunk.doc
  • haskellPackages.nvfetcher
  • haskellPackages.nvfetcher.doc
  • haskellPackages.update-nix-fetchgit
  • haskellPackages.update-nix-fetchgit.doc
  • kcl
  • lixPackageSets.git.nix-update
  • lixPackageSets.git.nix-update.dist
  • lixPackageSets.latest.nix-update (lixPackageSets.lix_2_94.nix-update)
  • lixPackageSets.latest.nix-update.dist (lixPackageSets.lix_2_94.nix-update.dist)
  • lixPackageSets.stable.nix-update (lixPackageSets.lix_2_93.nix-update)
  • lixPackageSets.stable.nix-update.dist (lixPackageSets.lix_2_93.nix-update.dist)
  • localtunnel
  • lon
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • mdwatch
  • meshlab
  • nim_lk
  • nix-prefetch-git
  • nix-prefetch-scripts
  • nix-update
  • nix-update-source
  • nix-update-source.dist
  • nix-update.dist
  • npins
  • nvfetcher
  • prefetch-yarn-deps
  • prowlarr
  • python312Packages.pymeshlab
  • python313Packages.nixpkgs-updaters-library
  • python313Packages.nixpkgs-updaters-library.dist
  • python313Packages.pymeshlab
  • radarr
  • sonarr
  • sus-compiler
  • tests.fetchFromBitbucket.withEncodedWhitespaceGit
  • tests.fetchFromGitHub.fetchTags
  • tests.fetchFromGitHub.leave-git
  • tests.fetchFromGitHub.rootDir
  • tests.fetchFromGitHub.sparseCheckout
  • tests.fetchFromGitHub.sparseCheckoutNonConeMode
  • tests.fetchFromGitHub.submodule-deep
  • tests.fetchFromGitHub.submodule-leave-git
  • tests.fetchFromGitHub.submodule-leave-git-deep
  • tests.fetchFromGitHub.submodule-simple
  • tests.fetchgit.cached-prefetch-avoids-fetch
  • tests.fetchgit.collect-rev
  • tests.fetchgit.describe-tag
  • tests.fetchgit.dumb-http-signed-tag
  • tests.fetchgit.fetchTags
  • tests.fetchgit.leave-git
  • tests.fetchgit.prefetch-git-no-add-path
  • tests.fetchgit.rootDir
  • tests.fetchgit.simple
  • tests.fetchgit.simple-tag
  • tests.fetchgit.sparseCheckout
  • tests.fetchgit.sparseCheckoutNonConeMode
  • tests.fetchgit.submodule-deep
  • tests.fetchgit.submodule-leave-git
  • tests.fetchgit.submodule-leave-git-deep
  • tests.fetchgit.submodule-revision-count
  • tests.fetchgit.submodule-simple
  • tests.fetchgit.withGitConfig
  • tests.fetchurl.header
  • tests.testers.runCommand.bork
  • typescript-language-server
  • update-nix-fetchgit
  • update-python-libraries
  • vclab-nexus
  • vclab-nexus.bin
  • vimPluginsUpdater
  • yarn2nix

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 25, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Dec 25, 2025
@ShamrockLee ShamrockLee added this pull request to the merge queue Dec 26, 2025
Merged via the queue into NixOS:master with commit 57e5df3 Dec 26, 2025
33 of 35 checks passed
@ShamrockLee ShamrockLee deleted the fetchgit-ref-tag-fix branch December 26, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nix-prefetch-git: cannot fetch branch when using --deepClone

4 participants