patchPpdFilesHook: fix path (and use getExe')#472356
Merged
HeitorAugustoLN merged 2 commits intoNixOS:masterfrom Dec 19, 2025
Merged
patchPpdFilesHook: fix path (and use getExe')#472356HeitorAugustoLN merged 2 commits intoNixOS:masterfrom
getExe')#472356HeitorAugustoLN merged 2 commits intoNixOS:masterfrom
Conversation
This was an oversight in commit 335a908 . The Wikipedia article referenced there https://en.wikipedia.org/wiki/PostScript_Printer_Description#CUPS clearly states that ppd file locations are `/usr/share/ppd/` or `/usr/share/cups/model/`. Even the version of that article from that commit's time says so. I don't know what dark force made me consistently change that to `/usr/share/ppds/`. *sigh*.
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
nixpkgs-ci
bot
added
12.approvals: 1
Member
|
From what I searched /share/ppd is indeed correct, I am running nixpkgs-review on aarch64-linux after it succeeds I am merging it |
Member
|
Contributor
|
Successfully created backport PR for |
github-actions
bot
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug in
patchPpdFilesHook: It looks for PPD files in the wrong directory (see also commit message). I recognized that bug while reviewing a pull request that utilizespatchPpdFilesHook.Replace
${diffutils}/bin/cmpwithgetExe' diffutils "cmp"in the test recipe.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.nixpkgs-reviewresultGenerated using
nixpkgs-review.Command:
nixpkgs-reviewCommit:
39dc238759bbc151d2c9e2506552c2c779d6a911x86_64-linux✅ 9 packages built:
More
I have build each package that got listed by
nixpkgs-review(see above): They all use the directoryshare/cups/model. So none of the packages inside nixpkgs is affected by the change, i.e., this pull request should cause no breakage. It might -- however -- affect private packages that also use the (wrong) directoryshare/ppds. I consider that risk to be very small.Add a 👍 reaction to pull requests you find important.