hp-unified-linux-driver: init at 1.00.39.12_00.15#468537
hp-unified-linux-driver: init at 1.00.39.12_00.15#468537SuperSandro2000 merged 2 commits intoNixOS:masterfrom
Conversation
danberdev
changed the title
danberdev
force-pushed
the
create-hp-uld-package
branch
from
560f11e to
391f76d
Compare
nixpkgs-ci
bot
added
the
12.first-time contribution
danberdev
force-pushed
the
create-hp-uld-package
branch
2 times, most recently
from
1e4df94 to
87a7875
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
danberdev
force-pushed
the
create-hp-uld-package
branch
2 times, most recently
from
e47b870 to
e9cb10e
Compare
dotlambda
changed the title
Yarny0
left a comment
Yarny0
left a comment
There was a problem hiding this comment.
Wow, this is quite involved! Welcome and thanks for contributing your solution to nixpkgs.
I have some remarks that -- hopefully -- help to improve your package.
Note that I cannot test it (due to lack of hardware) and that all my suggestions should not be be considered blockers, i.e., don't need to be followed for this to be merged (IMHO .. ultimatelly, it's not my call as I'm not a committer).
nixpkgs-ci
bot
removed
the
9.needs: reviewer
danberdev
force-pushed
the
create-hp-uld-package
branch
2 times, most recently
from
3a47985 to
21a0f5c
Compare
danberdev
force-pushed
the
create-hp-uld-package
branch
5 times, most recently
from
d563cd7 to
62c8afb
Compare
Yarny0
left a comment
Yarny0
left a comment
There was a problem hiding this comment.
Some small things, but in essence, it looks alright from my perspective.
danberdev
force-pushed
the
create-hp-uld-package
branch
from
62c8afb to
a50cd94
Compare
Add myself as a new maintainer due to introducing a new package.
danberdev
force-pushed
the
create-hp-uld-package
branch
2 times, most recently
from
93d0772 to
7ad0079
Compare
danberdev
force-pushed
the
create-hp-uld-package
branch
from
7ad0079 to
823a971
Compare
Yarny0
left a comment
Yarny0
left a comment
There was a problem hiding this comment.
That looks very beautiful now, especially replaceVars makes the code much more readable -- thank you.
Unfortunatelly, I uncovered another problem -- see inline comment.
danberdev
force-pushed
the
create-hp-uld-package
branch
from
2f3a097 to
7bca908
Compare
Yarny0
left a comment
Yarny0
left a comment
There was a problem hiding this comment.
Great! I tested all four ppd files (not with real hardware, but I printed into files). In all four cases, cups produces data without reporting any error. So as far as I can judge, this works! I cannot test the scanner functionality.
Thanks again for your contribution.
For me, this is ready for merging. I will now report this pull request in the "already reviewed" thread in NixOS Discourse, hopefully attracting a committer that pushes the merge button (or that has additional change requests).
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2700 |
nixpkgs-ci
bot
added
the
12.approvals: 1
There are some HP printers that are actually Samsung printers in disguise (because HP bought Samsung printer division). These printers are not supported by HPLIP. To use them, one must obtain a special driver: hp-uld (unified linux driver), which is a modified samsung driver. This driver introduces support for - HP Color Laser 15x Series - HP Color Laser MFP 17x Series - HP Laser 10x Series - HP Laser MFP 13x Series Where x stands for various model numbers from the lineup. This derivation does some ugly library patching, because the scanner library needs some hardcoded paths. In inspiration from similar packages in the collection, the patch was written. The driver uses libxml2.so.2, which is provided by an older libxml2 version.
danberdev
force-pushed
the
create-hp-uld-package
branch
from
e921c50 to
9ad97e2
Compare
nixpkgs-ci
bot
added
12.approvals: 2
5 participants
Hello!
I've been migrating to NixOS and encountered a problem setting up my HP printer (Laser MFP 135r to be precise). I've always had problems with it, needing to install some strange hp-uld driver instead of using the hplip suite on other distributions.
I've started to dig into it, because the package collection didn't have this driver, and it turned out, that my HP was a Samsung in disguise all this time :D. That's why it needs a special driver among some other HP models.
I tried to write a derivation to package the driver for my machine, and it worked (but it wasn't easy, some ugly library patching, ugh). As I've managed to write the derivation and package the driver, I thought that it would be nice to offer it to the community (and maintain it, of course).
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.