Revert "fetchurl, fetchgitlab: fix curlOpts extension"#470831
Merged
ShamrockLee merged 1 commit intomasterfrom Dec 15, 2025
Merged
Revert "fetchurl, fetchgitlab: fix curlOpts extension"#470831ShamrockLee merged 1 commit intomasterfrom
ShamrockLee merged 1 commit intomasterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
MattSturgeon
approved these changes
Dec 15, 2025
Contributor
MattSturgeon
left a comment
MattSturgeon
left a comment
There was a problem hiding this comment.
Thanks for clarifying and reverting! Sorry for the confusion.
However, curlOpts is only passed as a Bash array if it is specified as a list
I still think the bash code should attempt to handle it being an array if we still permit it to be passed as a list. If the bash code doesn't handle it being an array, then the warning ought to be a throw.
In this case that probably means using ${curlOpts[*]} expansion?
nixpkgs-ci
bot
added
the
12.approvals: 1
Contributor
Author
Let's settle that in PR #471172. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #470550
PR #470550 is based on the assumption that
curlOptsis passed as a Bash array since PR #464475 sets__structuredAttrs = truefor allfetchurl-constructed FODs. However,curlOptsis only passed as a Bash array if it is specified as a list, and passingcurlOptshas already been warned against before PR #464475.