Skip to content

fetchurl, fetchgitlab: fix curlOpts extension#470550

Merged
MattSturgeon merged 1 commit intoNixOS:masterfrom
panicgh:curlopts-array-extension
Dec 13, 2025
Merged

fetchurl, fetchgitlab: fix curlOpts extension#470550
MattSturgeon merged 1 commit intoNixOS:masterfrom
panicgh:curlopts-array-extension

Conversation

@panicgh
Copy link
Contributor

@panicgh panicgh commented Dec 13, 2025 •
edited
Loading

PR #464475 enables __structuredAttrs and makes curlOpts a bash array. Consequently, it must be extended as such to be effective.

See also #464475 (comment)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@panicgh
fetchurl, fetchgitlab: fix curlOpts extension
3db1176 
PR NixOS#464475 enables __structuredAttrs and makes curlOpts a bash array.
Consequently, it must be extended as such to be effective.

See also NixOS#464475 (comment)
@nixpkgs-ci nixpkgs-ci bot requested a review from philiptaron December 13, 2025 21:56
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) labels Dec 13, 2025
@panicgh panicgh requested a review from MattSturgeon December 13, 2025 21:59
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 13, 2025
@MattSturgeon MattSturgeon added this pull request to the merge queue Dec 13, 2025
Merged via the queue into NixOS:master with commit 55172e9 Dec 13, 2025
49 of 54 checks passed
@panicgh panicgh deleted the curlopts-array-extension branch December 13, 2025 22:39
@ShamrockLee ShamrockLee mentioned this pull request Dec 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MattSturgeon MattSturgeon MattSturgeon approved these changes

@philiptaron philiptaron Awaiting requested review from philiptaron

@ShamrockLee ShamrockLee Awaiting requested review from ShamrockLee

Assignees

No one assigned

Labels

6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@panicgh @MattSturgeon