Skip to content

[25.05] ciscoPacketTracer{7,8}: mark as vulnerable#465424

Closed
mdaniels5757 wants to merge 3 commits intoNixOS:release-25.05from
mdaniels5757:backport-456622-to-release-25.05
Closed

[25.05] ciscoPacketTracer{7,8}: mark as vulnerable#465424
mdaniels5757 wants to merge 3 commits intoNixOS:release-25.05from
mdaniels5757:backport-456622-to-release-25.05

Conversation

@mdaniels5757
Copy link
Member

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@mdaniels5757 mdaniels5757 added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Nov 26, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This report is automatically generated by the PR / Check / cherry-pick CI workflow.

Some of the commits in this PR require the author's and reviewer's attention.

Sometimes it is not possible to cherry-pick exactly the same patch.
This most frequently happens when resolving merge conflicts.
The range-diff will help to review the resolution of conflicts.

If you need to merge this PR despite the warnings, please dismiss this review shortly before merging.

Warning

Difference between 1f18d1b and original 6ceac84 may warrant inspection.

Show diff
@@ Metadata
  ## Commit message ##
     ciscoPacketTracer7: add maintainer gepbird
 
+    (cherry picked from commit 6ceac84a51a2eb5dd177eadc5090e47a3adeb00f)
+
  ## pkgs/by-name/ci/ciscoPacketTracer7/package.nix ##
 @@ pkgs/by-name/ci/ciscoPacketTracer7/package.nix: stdenv.mkDerivation {
+   meta = with lib; {
+     description = "Network simulation tool from Cisco";
      homepage = "https://www.netacad.com/courses/packet-tracer";
-     license = lib.licenses.unfree;
-     maintainers = with lib.maintainers; [
+-    sourceProvenance = with sourceTypes; [ binaryNativeCode ];
+-    license = licenses.unfree;
+-    maintainers = [ ];
++    license = lib.licenses.unfree;
++    maintainers = with lib.maintainers; [
 +      gepbird
-     ];
++    ];
      platforms = [ "x86_64-linux" ];
-     sourceProvenance = with lib.sourceTypes; [ binaryNativeCode ];
+   };
+ }

Hint: The full diffs are also available in the runner logs with slightly better highlighting.

@mdaniels5757 mdaniels5757 force-pushed the backport-456622-to-release-25.05 branch from 60542ca to 8e348f8 Compare November 26, 2025 23:42
@mdaniels5757
Copy link
Member Author

mdaniels5757 commented Nov 26, 2025

Blocked on #439081? Feels weird to mark as vulnerable when the package that causes it is a-ok on stable.

@mdaniels5757 mdaniels5757 deleted the backport-456622-to-release-25.05 branch January 1, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants