[25.05] ciscoPacketTracer{7,8}: mark as vulnerable#465424
[25.05] ciscoPacketTracer{7,8}: mark as vulnerable#465424mdaniels5757 wants to merge 3 commits intoNixOS:release-25.05from
Conversation
(cherry picked from commit 6ceac84)
There was a problem hiding this comment.
This report is automatically generated by the PR / Check / cherry-pick CI workflow.
Some of the commits in this PR require the author's and reviewer's attention.
Sometimes it is not possible to cherry-pick exactly the same patch.
This most frequently happens when resolving merge conflicts.
The range-diff will help to review the resolution of conflicts.
If you need to merge this PR despite the warnings, please dismiss this review shortly before merging.
Warning
Difference between 1f18d1b and original 6ceac84 may warrant inspection.
Show diff
@@ Metadata
## Commit message ##
ciscoPacketTracer7: add maintainer gepbird
+ (cherry picked from commit 6ceac84a51a2eb5dd177eadc5090e47a3adeb00f)
+
## pkgs/by-name/ci/ciscoPacketTracer7/package.nix ##
@@ pkgs/by-name/ci/ciscoPacketTracer7/package.nix: stdenv.mkDerivation {
+ meta = with lib; {
+ description = "Network simulation tool from Cisco";
homepage = "https://www.netacad.com/courses/packet-tracer";
- license = lib.licenses.unfree;
- maintainers = with lib.maintainers; [
+- sourceProvenance = with sourceTypes; [ binaryNativeCode ];
+- license = licenses.unfree;
+- maintainers = [ ];
++ license = lib.licenses.unfree;
++ maintainers = with lib.maintainers; [
+ gepbird
- ];
++ ];
platforms = [ "x86_64-linux" ];
- sourceProvenance = with lib.sourceTypes; [ binaryNativeCode ];
+ };
+ }
Hint: The full diffs are also available in the runner logs with slightly better highlighting.
60542ca to
8e348f8
Compare
|
Blocked on #439081? Feels weird to mark as vulnerable when the package that causes it is a-ok on stable. |
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.