ciscoPacketTracer{7,8}: use libxml2_13 that has patches for CVEs, fix desktop icons, refactor

[gepbird]

• Depends on/follow up for: libxml2: split to multiple versions, init libxml2_13, add patch for 5 CVEs #421740 (this has hit staging-next)

This fixes the security warning, as libxml2_13 includes CVE patches. I also made some other refactoring changes and smaller fixes.

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and others READMEs.

---

Add a 👍 reaction to pull requests you find important.

[gepbird]

I'm wondering when #421740 will be merged from staging to staging-next or where can I track this, recently a PR was merged from staging-next to master.

[Lokito23]

I'm wondering when #421740 will be merged from staging to staging-next or where can I track this, recently a PR was merged from staging-next to master.

It can be tracked with nixpk.gs, when specifying the PR number.

[gepbird]

I'm not sure why eval fails and what can we do about it, it should be unrelated to the PR

[gepbird]

cc previous reviewers and mergers: @jopejoe1 @griffi-gh @khaneliman @ryand56

[ryand56]

Eval failure looks to be #432489 (comment)
Looks like it was fixed, rebase once staging-next is merged into staging

[fabianhjr]

I think it would be better to rebase into staging-next, it is acceptable to merge into staging-next non-mass rebuilds that depend on something already on staging-next

[fabianhjr]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 426866
Commit: 0088256fe3b0237bb3e2b8e4a0616f45d8f59d2c

---

x86_64-linux

❌ 2 packages failed to build:

• ciscoPacketTracer7
• ciscoPacketTracer8

[fabianhjr]

Unable to build following instructions but nix-prefetch-url --type sha256 file:///path/to/CiscoPacketTracer822_amd64_signed.deb did match the expected hash.

Getting the message:

       > ***
       > Unfortunately, we cannot download file CiscoPacketTracer822_amd64_signed.deb automatically.
       > Please go to https://www.netacad.com to download it yourself, and add it to the Nix store
       > using either
       >   nix-store --add-fixed sha256 CiscoPacketTracer822_amd64_signed.deb
       > or
       >   nix-prefetch-url --type sha256 file:///path/to/CiscoPacketTracer822_amd64_signed.deb
       >
       > ***

[fabianhjr]

LGTM

[fabianhjr]

Thanks for volunteering as a maintainer

[gepbird]

Unable to build following instructions but nix-prefetch-url --type sha256 file:///path/to/CiscoPacketTracer822_amd64_signed.deb did match the expected hash.

Getting the message:

       > ***
       > Unfortunately, we cannot download file CiscoPacketTracer822_amd64_signed.deb automatically.
       > Please go to https://www.netacad.com to download it yourself, and add it to the Nix store
       > using either
       >   nix-store --add-fixed sha256 CiscoPacketTracer822_amd64_signed.deb
       > or
       >   nix-prefetch-url --type sha256 file:///path/to/CiscoPacketTracer822_amd64_signed.deb
       >
       > ***

When I last tried it, going to https://netacad.com was like navigating a maze, but I think for legal reasons we should still keep that.

To easily download it, you can find the .deb file for the version you see in the error message on this site: https://www.computernetworkingnotes.com/ccna-study-guide/download-packet-tracer-for-windows-and-linux.html
Then run the nix-store --add-fixed ... command from the error message, then build it again :)

[fabianhjr]

No yeah I did that, got the correct hash but for some reason nixpkgs-review wasn't picking it up :c