Skip to content

Revert "curl: enable c-ares"#462692

Merged
Scrumplex merged 1 commit intostagingfrom
revert-451579-curlFull
Nov 17, 2025
Merged

Revert "curl: enable c-ares"#462692
Scrumplex merged 1 commit intostagingfrom
revert-451579-curlFull

Conversation

@Scrumplex
Copy link
Member

Reverts #451579

Fixes #462625

@Scrumplex Scrumplex added the backport staging-25.11 Backport PR automatically label Nov 17, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Nov 17, 2025
Copy link
Member

@me-and me-and left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as a quick and relatively safe fix for 25.11.

I don't have any particular opinion on whether curlFull should support c-ares in a future release, or if that support should be a separate package, but if we decide to add c-ares support in curlFull, that clearly needs a bit more thought than we can manage in time for 25.11 while avoiding regressions.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Nov 17, 2025
@Scrumplex Scrumplex added this pull request to the merge queue Nov 17, 2025
Merged via the queue into staging with commit 8a6eb85 Nov 17, 2025
32 checks passed
@Scrumplex Scrumplex deleted the revert-451579-curlFull branch November 17, 2025 21:35
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Nov 17, 2025

Successfully created backport PR for staging-25.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. backport staging-25.11 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants