Skip to content

curl: enable c-ares#451579

Merged
Scrumplex merged 1 commit intoNixOS:stagingfrom
ungeskriptet:curlFull
Oct 18, 2025
Merged

curl: enable c-ares#451579
Scrumplex merged 1 commit intoNixOS:stagingfrom
ungeskriptet:curlFull

Conversation

@ungeskriptet
Copy link
Member

This enables the --dns-servers option.

Fixes: #451543

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 13, 2025
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 451579
Commit: f782f9149b99cd88a787e96b1425f7f70bc893a6 (subsequent changes)
Merge: df3108e595221d5fbfd3ca6efbbedef372fefffe

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18480840467


x86_64-linux

✅ 7 packages built:
  • chiaki-ng
  • curlFull
  • curlFull.bin
  • curlFull.debug
  • curlFull.dev
  • curlFull.devdoc
  • curlFull.man

aarch64-linux

✅ 7 packages built:
  • chiaki-ng
  • curlFull
  • curlFull.bin
  • curlFull.debug
  • curlFull.dev
  • curlFull.devdoc
  • curlFull.man

x86_64-darwin (sandbox = true)

✅ 5 packages built:
  • curlFull
  • curlFull.bin
  • curlFull.dev
  • curlFull.devdoc
  • curlFull.man

aarch64-darwin (sandbox = true)

✅ 5 packages built:
  • curlFull
  • curlFull.bin
  • curlFull.dev
  • curlFull.devdoc
  • curlFull.man

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 16, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Oct 17, 2025
This enables the `--dns-servers` option.

Fixes: NixOS#451543
Signed-off-by: David Wronek <david.wronek@mainlining.org>
github-actions[bot]

This comment was marked as resolved.

@ungeskriptet ungeskriptet changed the base branch from master to staging October 18, 2025 06:47
@nixpkgs-ci nixpkgs-ci bot closed this Oct 18, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Oct 18, 2025
@github-actions github-actions bot dismissed their stale review October 18, 2025 06:48

All good now, thank you!

Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Haven't built it yet

@Scrumplex Scrumplex changed the title curlFull: enable c-ares curl: enable c-ares Oct 18, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 18, 2025
@Scrumplex Scrumplex added this pull request to the merge queue Oct 18, 2025
Merged via the queue into NixOS:staging with commit b5b99c7 Oct 18, 2025
39 of 42 checks passed
lf- pushed a commit to lix-project/lix that referenced this pull request Nov 17, 2025
NixOS/nixpkgs#451579 PR
enabled c-aresSupport for curl on darwin which ended up breaking
DNS resolution in FOD sandboxes:

```
nix-run> exporting https://tangled.org/@weethet.bsky.social/nix-run (rev 73d7bf6b58848fb8f42e3a69816e0847f041c689) into /nix/store/m4m951648wmipxgwrgsml9gzjwfpfhm7-nix-run-73d7bf6
nix-run> Initialized empty Git repository in /nix/store/m4m951648wmipxgwrgsml9gzjwfpfhm7-nix-run-73d7bf6/.git/
nix-run> fatal: unable to access 'https://tangled.org/@weethet.bsky.social/nix-run/': Could not resolve host: tangled.org (Could not contact DNS servers)
nix-run> fatal: unable to access 'https://tangled.org/@weethet.bsky.social/nix-run/': Could not resolve host: tangled.org (Could not contact DNS servers)
nix-run> fatal: unable to access 'https://tangled.org/@weethet.bsky.social/nix-run/': Could not resolve host: tangled.org (Could not contact DNS servers)
nix-run> Unable to checkout 73d7bf6b58848fb8f42e3a69816e0847f041c689 from https://tangled.org/@weethet.bsky.social/nix-run.
```

with these sandbox failures:
```
deny mach-lookup com.apple.SystemConfiguration.DNSConfiguration
deny file-read-metadata /private/etc/hosts
deny file-read-data /private/etc/hosts
```

We allow those so that DNS resolution work fine

Change-Id: I9102293691972feb085adf8e9b1ad915bb3a36ab
@ungeskriptet ungeskriptet deleted the curlFull branch February 22, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

curlFull: option --dns-servers: the installed libcurl version does not support this

3 participants