Conversation
Member
|
Scrumplex
reviewed
Oct 17, 2025
f782f91 to
b623207
Compare
This enables the `--dns-servers` option. Fixes: NixOS#451543 Signed-off-by: David Wronek <david.wronek@mainlining.org>
b623207 to
766df53
Compare
Scrumplex
approved these changes
Oct 18, 2025
Member
Scrumplex
left a comment
There was a problem hiding this comment.
Changes LGTM. Haven't built it yet
13 tasks
3 tasks
lf-
pushed a commit
to lix-project/lix
that referenced
this pull request
Nov 17, 2025
NixOS/nixpkgs#451579 PR enabled c-aresSupport for curl on darwin which ended up breaking DNS resolution in FOD sandboxes: ``` nix-run> exporting https://tangled.org/@weethet.bsky.social/nix-run (rev 73d7bf6b58848fb8f42e3a69816e0847f041c689) into /nix/store/m4m951648wmipxgwrgsml9gzjwfpfhm7-nix-run-73d7bf6 nix-run> Initialized empty Git repository in /nix/store/m4m951648wmipxgwrgsml9gzjwfpfhm7-nix-run-73d7bf6/.git/ nix-run> fatal: unable to access 'https://tangled.org/@weethet.bsky.social/nix-run/': Could not resolve host: tangled.org (Could not contact DNS servers) nix-run> fatal: unable to access 'https://tangled.org/@weethet.bsky.social/nix-run/': Could not resolve host: tangled.org (Could not contact DNS servers) nix-run> fatal: unable to access 'https://tangled.org/@weethet.bsky.social/nix-run/': Could not resolve host: tangled.org (Could not contact DNS servers) nix-run> Unable to checkout 73d7bf6b58848fb8f42e3a69816e0847f041c689 from https://tangled.org/@weethet.bsky.social/nix-run. ``` with these sandbox failures: ``` deny mach-lookup com.apple.SystemConfiguration.DNSConfiguration deny file-read-metadata /private/etc/hosts deny file-read-data /private/etc/hosts ``` We allow those so that DNS resolution work fine Change-Id: I9102293691972feb085adf8e9b1ad915bb3a36ab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the
--dns-serversoption.Fixes: #451543
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.