Skip to content

ocamlPackages.nonstd: remove at 0.0.3#460251

Merged
alexfmpe merged 1 commit intoNixOS:masterfrom
vbgl:ocaml-nonstd-exit
Nov 12, 2025
Merged

ocamlPackages.nonstd: remove at 0.0.3#460251
alexfmpe merged 1 commit intoNixOS:masterfrom
vbgl:ocaml-nonstd-exit

Conversation

@vbgl
Copy link
Contributor

@vbgl vbgl commented Nov 10, 2025 •
edited
Loading

This is broken (unavailable for OCaml ≥ 5.0), unused in nixpkgs, and depends on dune_1.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@vbgl vbgl added 8.has: clean-up This PR removes packages or removes other cruft 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. labels Nov 10, 2025
@vbgl vbgl requested a review from alexfmpe November 10, 2025 04:53
@nixpkgs-ci nixpkgs-ci bot requested a review from ulrikstrid November 10, 2025 04:54
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 10, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 10, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 10, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Nov 11, 2025
@alexfmpe
Copy link
Member

alexfmpe commented Nov 12, 2025 •
edited
Loading

Looks like there's a conflict due to #406555 landing on master.
Other than that LGTM

@vbgl vbgl force-pushed the ocaml-nonstd-exit branch from 1ff8939 to cedb6d8 Compare November 12, 2025 19:30
@vbgl
Copy link
Contributor Author

vbgl commented Nov 12, 2025

Rebased and conflicts fixed.

@alexfmpe alexfmpe added this pull request to the merge queue Nov 12, 2025
Merged via the queue into NixOS:master with commit b4528dd Nov 12, 2025
26 of 30 checks passed
@vbgl vbgl deleted the ocaml-nonstd-exit branch November 13, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ulrikstrid ulrikstrid ulrikstrid approved these changes

@alexfmpe alexfmpe alexfmpe approved these changes

+2 more reviewers

@DieracDelta DieracDelta DieracDelta approved these changes

@redianthus redianthus redianthus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vbgl @alexfmpe @ulrikstrid @DieracDelta @redianthus