ocamlPackages: fix eval and let ci check that it still evals#406555
ocamlPackages: fix eval and let ci check that it still evals#406555wolfgangwalther merged 4 commits intoNixOS:stagingfrom
Conversation
7a2d709 to
2a9d909
Compare
|
A few packages do not build. It could be better to disable them. For instance |
|
Marked the ones failing to build with nixpkgs-review as broken |
f714544 to
3e3089f
Compare
|
@wolfgangwalther now with #426629 this would fail CI, as OCaml packages use a throw to chech which version they are compatible with Any idea how this could be otherwise handled in ocamlPackages so that it conforms to the better ci? |
3e3089f to
3ad3598
Compare
I dealt with a similar cases in #426640 for I'm still investigating these things myself, so there's not a 100%-ish "do it like this" answer, yet. Open to suggestions, too. |
65b0540 to
ccbb5fc
Compare
ccbb5fc to
d2f3f19
Compare
|
To the best of my knowledge, packages marked with |
|
Would like to get this merged soonish if no-one else wants to take a stab at implementing this in a better way, following this comment from @wolfgangwalther. |
wolfgangwalther
left a comment
There was a problem hiding this comment.
I don't see anyone coming up with a more principled approach, so let's do it this way.
Went through the changes, got some feedback.
dfc3aa7 to
fd497cf
Compare
6078605 to
2f3051a
Compare
|
This gets way too many merge conflicts. I would really like to get this merged soon. |
|
I'm happy with commits 3 & 4. I think we are very close, the first two commits should be fixable. I'm happy to merge soon once they are. |
2f3051a to
64bf39a
Compare
64bf39a to
d224516
Compare
throws no longer work with the current ci we have in nixpkgs
eval of ocamlPackages was broken, let's enable it to be checked by ci
d224516 to
b32b1dc
Compare
|
Thank you for this PR and all the other small fixes to release stuff / recursion etc. - very much appreciated. |
The OCaml package set currently does not get tested by CI or build by hydra, let's change that so that no new errors are silently sneaking them self in.
Closes #277698
Closes #126934
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.