warnAlias -> lib.warnings.warnAlias#457656
Closed
PerchunPak wants to merge 2 commits intoNixOS:masterfrom
Closed
Conversation
emilazy
reviewed
Nov 1, 2025
Member
emilazy
left a comment
There was a problem hiding this comment.
I would rather not codify this hack as public API with stability promises; it’s a temporary convenience to work around awkward Nix behaviour and the interaction between the imperfect script’s simple logic and existing aliases affected by the lack of structure in our package set. I’d expect structured aliases to handle this differently.
`warnAlias` was added exclusively to `pkgs/top-level/aliases.nix` but I think it will be useful in stdlib. Also comes with tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
warnAliaswas added in #456527 exclusively topkgs/top-level/aliases.nixbut I think it will be useful in stdlib.Also comes with tests!
#457349 is included in this PR, because tests fail otherwise.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.