Skip to content

warnAlias -> lib.warnings.warnAlias#457656

Closed
PerchunPak wants to merge 2 commits intoNixOS:masterfrom
PerchunPak:warnalias
Closed

warnAlias -> lib.warnings.warnAlias#457656
PerchunPak wants to merge 2 commits intoNixOS:masterfrom
PerchunPak:warnalias

Conversation

@PerchunPak
Copy link
Member

warnAlias was added in #456527 exclusively to pkgs/top-level/aliases.nix but I think it will be useful in stdlib.

Also comes with tests!

#457349 is included in this PR, because tests fail otherwise.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 6.topic: lib The Nixpkgs function library 6.topic: policy discussion Discuss policies to work in and around Nixpkgs labels Nov 1, 2025
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather not codify this hack as public API with stability promises; it’s a temporary convenience to work around awkward Nix behaviour and the interaction between the imperfect script’s simple logic and existing aliases affected by the lack of structure in our package set. I’d expect structured aliases to handle this differently.

`warnAlias` was added exclusively to `pkgs/top-level/aliases.nix` but I
think it will be useful in stdlib.

Also comes with tests!
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 1, 2025
@PerchunPak PerchunPak closed this Nov 2, 2025
@PerchunPak PerchunPak deleted the warnalias branch November 2, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: lib The Nixpkgs function library 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants